From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 33BCCC77B7A for ; Wed, 17 May 2023 08:38:10 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229691AbjEQIiI (ORCPT ); Wed, 17 May 2023 04:38:08 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:52740 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230310AbjEQIhv (ORCPT ); Wed, 17 May 2023 04:37:51 -0400 Received: from mail-ed1-x531.google.com (mail-ed1-x531.google.com [IPv6:2a00:1450:4864:20::531]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 7C0DF35AE for ; Wed, 17 May 2023 01:36:45 -0700 (PDT) Received: by mail-ed1-x531.google.com with SMTP id 4fb4d7f45d1cf-50bcb00a4c2so678746a12.1 for ; Wed, 17 May 2023 01:36:45 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1684312604; x=1686904604; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=g7ruM67WgRDIXbVKb/F6e9gFEQIj+XoUWJErkIr/uRg=; b=ItSaBxJTJ1tBihpooE/eT24WtPMlJ5sdTHYC9l471aIHQkuvYcRgVDLGm7zaeDx0Bc a36OA5ogxSHq9sO1144MHXOcUG5Y3QLpR0e9Nik2MR31WkUIXZCe22sI2gI5wNCKz9kr VZFFD4gmzMImzYaEayluE6x8Bj/dRjpcOwJJ0I2IaJyRb5IQlBbalaf975PvfR5UQzvO QDftdV7RP/vABR+XhsI+BRLDSXSbgoK7J8NZfoBdlxRZV25GHkcooq7gvv7SUuZgHDrF rGnC1nOr+QXN37dAKP6xpSljkn9O6VjZGEA2ymJpMtcTFUyxMhZkBFxEmJGsuFMnqlNx P3cg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1684312604; x=1686904604; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=g7ruM67WgRDIXbVKb/F6e9gFEQIj+XoUWJErkIr/uRg=; b=XT4dxtevQsbGAV2H8BaN/+dXjNYMjzwaVquNqsvXq6QHooTFfI3Vr59fSeEHOCqtKJ GpS2S1zuRqo4tDV/rGcgodPD31DNmiKfX4mmfH76y+zYBJUqrMs6az3XtYcN2L8vtVln qHh6a03FoSiAJAGgA2r5y6wquA72MAbPudUXqVoksekLh7SbpgANmKyZY+x7XkuziwHn u+xeDsN1m6mpx22ce82qDHFWIVkt4kq9ImFiNPXM4hPBc6tnBoPfhhQhGo0uWZmSI8tL 0RTmtU1RTWB0NrXiKC40rjwmnN0l9UjN6Ul9zbbTZd3KfRJ3DBAmS51F3fBLBG/1ot3h JHBg== X-Gm-Message-State: AC+VfDz+iRhjAAuTIvb9g80B4cZmDo/qIBWusy79+U182II5xmd+k/5F ipDeUfDgKGgJFRTcBsvIhUYDAQ== X-Google-Smtp-Source: ACHHUZ7mi58zcftzLkvCYSEZqALyJYLyJJAqnIEVZEYRSCl/2H4HV/w7hE9ZWWBQ9pRBw86G0ihu6Q== X-Received: by 2002:a17:907:8a14:b0:94f:6218:191f with SMTP id sc20-20020a1709078a1400b0094f6218191fmr39457018ejc.52.1684312603985; Wed, 17 May 2023 01:36:43 -0700 (PDT) Received: from ?IPV6:2a02:810d:15c0:828:c9ff:4c84:dd21:568d? ([2a02:810d:15c0:828:c9ff:4c84:dd21:568d]) by smtp.gmail.com with ESMTPSA id ta26-20020a1709078c1a00b009663b1addb0sm11911626ejc.224.2023.05.17.01.36.42 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 17 May 2023 01:36:43 -0700 (PDT) Message-ID: <38ae4ceb-da21-d73e-9625-1918b4ab4e16@linaro.org> Date: Wed, 17 May 2023 10:36:42 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.11.0 Subject: Re: [PATCH v2 3/5] dt-bindings: net: add mac-address-increment option Content-Language: en-US To: Ivan Mikhaylov , Samuel Mendoza-Jonas , "David S . Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Rob Herring , Krzysztof Kozlowski Cc: netdev@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, openbmc@lists.ozlabs.org, Paul Fertser References: <20230509143504.30382-1-fr0st61te@gmail.com> <20230509143504.30382-4-fr0st61te@gmail.com> <6b5be71e-141e-c02a-8cba-a528264b26c2@linaro.org> <8de01e81-43dc-71af-f56f-4fba957b0b0b@linaro.org> <5b826dc7-2d02-d4ed-3b6a-63737abe732b@linaro.org> From: Krzysztof Kozlowski In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On 16/05/2023 13:47, Ivan Mikhaylov wrote: hy this is property of the hardware. I >>>> understand >>>> that this is something you want Linux to do, but DT is not for >>>> that >>>> purpose. Do not encode system policies into DT and what above >>>> commit >>>> says is a policy. >>>> >>> >>> Krzysztof, okay then to which DT subsystem it should belong? To >>> ftgmac100 after conversion? >> >> To my understanding, decision to add some numbers to MAC address does >> not look like DT property at all. Otherwise please help me to >> understand >> - why different boards with same device should have different >> offset/value? >> >> Anyway, commit msg also lacks any justification for this. >> >> Best regards, >> Krzysztof >> > > Krzysztof, essentially some PCIe network cards have like an additional > *MII interface which connects directly to a BMC (separate SoC for > managing a motherboard) and by sending special ethernet type frames > over that connection (called NC-SI) the BMC can obtain MAC, get link > parameters etc. So it's natural for a vendor to allocate two MACs per > such a board with PCIe card intergrated, with one MAC "flashed into" > the network card, under the assumption that the BMC should Who makes the assumption that next MAC should differ by 1 or 2? > automatically use the next MAC. So it's the property of the hardware as > the vendor designs it, not a matter of usage policy. > > Also at the nvmem binding tree is "nvmem-cell-cells" which is literally > the same as what was proposed but on different level. > > https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/Documentation/devicetree/bindings/nvmem?id=7e2805c203a6c8dc85c1cfda205161ed39ae82d5 How is this similar? This points the location of mac address on some NV storage. You add fixed value which should be added to the Ethernet. I might be missing the context but there is no DTS example nor user of this property, so how can I get such? Best regards, Krzysztof