From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id DBA45C43219 for ; Fri, 21 Oct 2022 14:37:03 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230236AbiJUOhC (ORCPT ); Fri, 21 Oct 2022 10:37:02 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:41852 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230162AbiJUOhA (ORCPT ); Fri, 21 Oct 2022 10:37:00 -0400 Received: from mail-qv1-xf31.google.com (mail-qv1-xf31.google.com [IPv6:2607:f8b0:4864:20::f31]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id E715F253BDA for ; Fri, 21 Oct 2022 07:36:58 -0700 (PDT) Received: by mail-qv1-xf31.google.com with SMTP id x15so1953393qvp.1 for ; Fri, 21 Oct 2022 07:36:58 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=JGMtp++eUJrez8pXYEPV6WEAnFwRbRNcptsUSZmXZKk=; b=GsGZuSfgkoadv7b/I2ks5EtBOIE8t2wfungIcWlrdh6fe45Zr6GSixCPHCHxofPeKL Fk6JE9sj96ws3+5HyHxkB0o4sWv9K2i/pISnK/KQ0DPyWB6g19CC/0s2Bs7CJhni5wRf wLbB+rqL7KQuDKi0UoFh4Mt9vNV+jtcIGjO8B2OPWWMGNDtQFFqGE1IZ/DajlrEepoTI G5+Edxq0i1oBrUbG1vxADhJbF/Qx9araR8SOvfm10CZRG8oLbUj6ZjUcgiBMcNwmLnQs M0Gu1Y/DAr9mkm7g3dR7drj7lTHJRnKsTCskbGHxjVczleqmF8DrB+Pg27oyPVgUR8gP i59g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=JGMtp++eUJrez8pXYEPV6WEAnFwRbRNcptsUSZmXZKk=; b=AhsOGz3X2oHPJeQgWTfCdTgXh6M/X1CR3PpXbfn+mUomIrVdG9fyHXCo+6qyROe8T2 KXBo6VkgjqxHZeLJE06jEseTn89kmcxJdOWpdgSh9BHGiBSFhHpfBnqFC//IEJcq2hVo JpK3y6hd0jrMyAaoxdGJaIXruO044udw8jP62UDYItGneJs03xJisbIq80MdXnQaWAUP kblFOPFw/gYdf8/3tQR7jyM1qV+poGTNWtmLrzGkDoBcXJECA83YVdcscKJy6cCVD7Jk 0r/Wcz2CfefbJTZ1xdnAdA7HCH07SYBYLzeCWn/6Fd2RWVTQXV5mBnnHHC1XGxfsqgBN UUIg== X-Gm-Message-State: ACrzQf191qRbEbfKqDz4+P3vs3Oveil7SrcR/Z2bhDGQyKAzrhtYeuag LJTHWBaHVi3orqnbKChAwhnMwg== X-Google-Smtp-Source: AMsMyM5VxtnCRA1go0k1ExMwMW9WYEP72w2A8FnkTd4/JdewFCbJWIw5uDCF2SgBtXifA6vuXEuvyA== X-Received: by 2002:a05:6214:c68:b0:4b4:156a:cdac with SMTP id t8-20020a0562140c6800b004b4156acdacmr16489819qvj.115.1666363017979; Fri, 21 Oct 2022 07:36:57 -0700 (PDT) Received: from [192.168.10.124] (pool-72-83-177-149.washdc.east.verizon.net. [72.83.177.149]) by smtp.gmail.com with ESMTPSA id m21-20020ac866d5000000b0039cbd3e4ed1sm8074512qtp.6.2022.10.21.07.36.55 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 21 Oct 2022 07:36:56 -0700 (PDT) Message-ID: <38c21467-8970-eefa-7dd2-3f2ed3364afb@linaro.org> Date: Fri, 21 Oct 2022 10:36:50 -0400 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.4.0 Subject: Re: [PATCH 2/4] arm64: boot: dts: msm8996: add blsp1_i2c6 node Content-Language: en-US To: Harry Austen , Bjorn Andersson , Rob Herring , Krzysztof Kozlowski Cc: Yassine Oudjana , Andy Gross , Konrad Dybcio , linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, ~postmarketos/upstreaming@lists.sr.ht, phone-devel@vger.kernel.org References: <20221021142242.129276-1-hpausten@protonmail.com> <20221021142242.129276-3-hpausten@protonmail.com> From: Krzysztof Kozlowski In-Reply-To: <20221021142242.129276-3-hpausten@protonmail.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On 21/10/2022 10:24, Harry Austen wrote: > Add support for the sixth I2C interface on the MSM8996 SoC. > > Signed-off-by: Harry Austen > --- > arch/arm64/boot/dts/qcom/msm8996.dtsi | 31 +++++++++++++++++++++++++++ > 1 file changed, 31 insertions(+) > > diff --git a/arch/arm64/boot/dts/qcom/msm8996.dtsi b/arch/arm64/boot/dts/qcom/msm8996.dtsi > index 80590267dfd0..70c0eae17360 100644 > --- a/arch/arm64/boot/dts/qcom/msm8996.dtsi > +++ b/arch/arm64/boot/dts/qcom/msm8996.dtsi > @@ -1400,6 +1400,20 @@ pwdn { > }; > }; > > + blsp1_i2c6_default: blsp1_i2c6 { No underscores in node names. Missing "state" suffix. See: https://lore.kernel.org/linux-arm-msm/20221018155721.47140-1-krzysztof.kozlowski@linaro.org/ Bindings are already in next. Does not look like you tested the DTS against bindings. Please run `make dtbs_check` (see Documentation/devicetree/bindings/writing-schema.rst for instructions). > + pins = "gpio27", "gpio28"; > + function = "blsp_i2c6"; > + drive-strength = <16>; > + bias-disable; > + }; > + > + blsp1_i2c6_sleep: blsp1_i2c6_sleep { > + pins = "gpio27", "gpio28"; > + function = "gpio"; > + drive-strength = <2>; > + bias-pull-up; > + }; > + Best regards, Krzysztof