From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: Pranavi Somisetty <pranavi.somisetty@amd.com>
Cc: pabeni@redhat.com, netdev@vger.kernel.org, edumazet@google.com,
davem@davemloft.net, kuba@kernel.org,
nicolas.ferre@microchip.com, michal.simek@amd.com,
harini.katakam@amd.com, robh+dt@kernel.org,
devicetree@vger.kernel.org, claudiu.beznea@microchip.com,
radhey.shyam.pandey@amd.com, linux-kernel@vger.kernel.org,
krzysztof.kozlowski+dt@linaro.org, git@amd.com
Subject: Re: [PATCH net-next v3 1/2] dt-bindings: net: cdns,macb: Add rx-watermark property
Date: Wed, 31 May 2023 09:17:11 +0200 [thread overview]
Message-ID: <38c9dfb3-e1c6-8a2d-993f-b6930bd0d8fa@linaro.org> (raw)
In-Reply-To: <20230530122559.o2nvvtkf2gddvjkz@krzk-bin>
On 30/05/2023 14:25, Krzysztof Kozlowski wrote:
> On Tue, 30 May 2023 03:51:37 -0600, Pranavi Somisetty wrote:
>> watermark value is the minimum amount of packet data
>> required to activate the forwarding process. The watermark
>> implementation and maximum size is dependent on the device
>> where Cadence MACB/GEM is used.
>>
>> Signed-off-by: Pranavi Somisetty <pranavi.somisetty@amd.com>
>> ---
>> Changes v2:
>> None (patch added in v2)
>>
>> Changes v3:
>> 1. Fixed DT schema error: "scalar properties shouldn't have array keywords".
>> 2. Modified description of rx-watermark to include units of the watermark value.
>> 3. Modified the DT property name corresponding to rx_watermark in
>> pbuf_rxcutthru to "cdns,rx-watermark".
>> 4. Modified commit description to remove references to Xilinx platforms,
>> since the changes aren't platform specific.
>> ---
>> Documentation/devicetree/bindings/net/cdns,macb.yaml | 9 +++++++++
>> 1 file changed, 9 insertions(+)
>>
>
> Running 'make dtbs_check' with the schema in this patch gives the
> following warnings. Consider if they are expected or the schema is
> incorrect. These may not be new warnings.
>
> Note that it is not yet a requirement to have 0 warnings for dtbs_check.
> This will change in the future.
>
> Full log is available here: https://patchwork.ozlabs.org/patch/1787378
>
>
> ethernet@e000b000: ethernet-phy@0: Unevaluated properties are not allowed ('device_type', 'marvell,reg-init' were unexpected)
> arch/arm/boot/dts/zynq-parallella.dtb
>
Unrelated warnings, can be ignored.
Best regards,
Krzysztof
next prev parent reply other threads:[~2023-05-31 7:17 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-05-30 9:51 [PATCH net-next v3 0/2] Add support for partial store and forward Pranavi Somisetty
2023-05-30 9:51 ` [PATCH net-next v3 1/2] dt-bindings: net: cdns,macb: Add rx-watermark property Pranavi Somisetty
2023-05-30 12:25 ` Krzysztof Kozlowski
2023-05-31 7:17 ` Krzysztof Kozlowski [this message]
2023-05-31 6:31 ` Claudiu.Beznea
2023-05-31 7:18 ` Krzysztof Kozlowski
2023-05-30 9:51 ` [PATCH net-next v3 2/2] net: macb: Add support for partial store and forward Pranavi Somisetty
2023-05-30 19:22 ` Simon Horman
2023-05-31 6:56 ` Claudiu.Beznea
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=38c9dfb3-e1c6-8a2d-993f-b6930bd0d8fa@linaro.org \
--to=krzysztof.kozlowski@linaro.org \
--cc=claudiu.beznea@microchip.com \
--cc=davem@davemloft.net \
--cc=devicetree@vger.kernel.org \
--cc=edumazet@google.com \
--cc=git@amd.com \
--cc=harini.katakam@amd.com \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=michal.simek@amd.com \
--cc=netdev@vger.kernel.org \
--cc=nicolas.ferre@microchip.com \
--cc=pabeni@redhat.com \
--cc=pranavi.somisetty@amd.com \
--cc=radhey.shyam.pandey@amd.com \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).