From: Krzysztof Kozlowski <krzk@kernel.org>
To: Arnab Layek <arnab.layek@mediatek.com>
Cc: devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-mediatek@lists.infradead.org, robh@kernel.org,
krzk+dt@kernel.org, conor+dt@kernel.org, matthias.bgg@gmail.com,
angelogioacchino.delregno@collabora.com, andersson@kernel.org,
mathieu.poirier@linaro.org, linux-remoteproc@vger.kernel.org,
Project_Global_Chrome_Upstream_Group@mediatek.com
Subject: Re: [PATCH v3 1/1] dt-bindings: remoteproc: mtk,scp: Allow multiple memory regions for MT8188
Date: Thu, 14 May 2026 14:32:28 +0200 [thread overview]
Message-ID: <38d29061-64a4-45e8-891f-d688716058a5@kernel.org> (raw)
In-Reply-To: <20260514-poised-green-beagle-79cb9c@quoll>
On 14/05/2026 14:30, Krzysztof Kozlowski wrote:
> On Thu, May 14, 2026 at 07:45:33PM +0800, Arnab Layek wrote:
>> The MT8188 SCP requires support for 1-2 reserved memory regions, while
>> other MediaTek SoCs use only a single memory region.
>>
>> The schema uses a permissive base with restrictive conditionals:
>> 1) Base schema allows all devices minItems: 1, maxItems: 2
>> 2) Non-MT8188 devices (mt8183, mt8186, mt8192, mt8195, mt8195-dual) are
>> restricted to maxItems: 1, overriding the base
>> 3) MT8188 devices (mt8188, mt8188-dual) set minItems: 1 with item
>> descriptions, inheriting maxItems: 2 from base, making the second
>> L1TCM region optional
>>
>> This follows the same pattern as other MediaTek dt-bindings such as
>> mediatek,jpeg-encoder.yaml which uses conditional schemas to support
>> different numbers of iommus per device variant.
>>
>
> So I just reviewed v2, because it appeared in patchwork thread...
> because you just threaded v3 there.
>
> No, really, this was repeated also to Mediatek so many times.
>
> Implement v2 review.
>
Heh, and now I noticed that you just merged THREE versions in one thread
leading to complete mess in this entire thread.
Best regards,
Krzysztof
prev parent reply other threads:[~2026-05-14 12:32 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-05-06 13:31 [PATCH] dt-bindings: remoteproc: mtk,scp: Allow multiple memory regions Arnab Layek
2026-05-06 13:36 ` Krzysztof Kozlowski
2026-05-11 12:10 ` [PATCH v2 0/1] dt-bindings: remoteproc: mtk,scp: Allow multiple memory regions for MT8188 Arnab Layek
2026-05-11 12:10 ` [PATCH v2 1/1] " Arnab Layek
2026-05-11 16:27 ` Conor Dooley
2026-05-12 2:46 ` sashiko-bot
2026-05-14 12:29 ` Krzysztof Kozlowski
2026-05-14 11:45 ` [PATCH v3 0/1] " Arnab Layek
2026-05-14 11:45 ` [PATCH v3 1/1] " Arnab Layek
2026-05-14 12:30 ` Krzysztof Kozlowski
2026-05-14 12:32 ` Krzysztof Kozlowski [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=38d29061-64a4-45e8-891f-d688716058a5@kernel.org \
--to=krzk@kernel.org \
--cc=Project_Global_Chrome_Upstream_Group@mediatek.com \
--cc=andersson@kernel.org \
--cc=angelogioacchino.delregno@collabora.com \
--cc=arnab.layek@mediatek.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=krzk+dt@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=linux-remoteproc@vger.kernel.org \
--cc=mathieu.poirier@linaro.org \
--cc=matthias.bgg@gmail.com \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox