From: Srinivas Kandagatla <srinivas.kandagatla@linaro.org>
To: Lee Jones <lee.jones@linaro.org>
Cc: robh@kernel.org, broonie@kernel.org, linus.walleij@linaro.org,
vinod.koul@linaro.org, alsa-devel@alsa-project.org,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
spapothi@codeaurora.org, bgoswami@codeaurora.org,
linux-gpio@vger.kernel.org
Subject: Re: [PATCH v2 02/11] mfd: wcd934x: add support to wcd9340/wcd9341 codec
Date: Mon, 21 Oct 2019 13:14:09 +0100 [thread overview]
Message-ID: <38dde3d9-8d7e-7dc0-7cba-137b43cea9d1@linaro.org> (raw)
In-Reply-To: <20191021114520.GD4365@dell>
On 21/10/2019 12:45, Lee Jones wrote:
> On Mon, 21 Oct 2019, Srinivas Kandagatla wrote:
>
>> Thanks Lee for taking time to review.
>>
>> I agree with most of the style related comments, will fix them in next
>> version. For others I have replied it inline.
>
> [...]
>
>>>> +static int wcd934x_slim_status(struct slim_device *sdev,
>>>> + enum slim_device_status status)
>>>> +{
>>>> + struct device *dev = &sdev->dev;
>>>> + struct wcd934x_data *wcd;
>>>> + int ret;
>>>
>>> This is semantically odd! Why are you doing most of the
>>> initialisation and bring-up in 'status' and not 'probe'. Seems
>>> broken to me.
>>
>> SLIMBus device will not be in a state to communicate before enumeration (at
>> probe), so all the device initialization is done in status callback where it
>> is ready for communication.
>
> Why do we need the device to be up *before* calling probe?
>
To Initialize the device.
And SLIMbus device registers access can not be done before enumeration.
>> This is same with SoundWire Bus as well!
>
> [...]
>
>>>> + struct device *dev;
>>>> + struct clk *extclk;
>>>> + struct regmap *regmap;
>>>> + struct slim_device *sdev;
>>>
>>> You don't need 'sdev' and 'dev'.
>>
>> slim_device instance (sdev) is required by audio codec driver to allocate
>> stream runtime.
>
> You can extrapolate one from the other.
That is possible to do! I can give that a try and see in next version!
>
next prev parent reply other threads:[~2019-10-21 12:14 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-18 0:18 [PATCH v2 00/11] ASoC: Add support to WCD9340/WCD9341 codec Srinivas Kandagatla
2019-10-18 0:18 ` [PATCH v2 01/11] ASoC: dt-bindings: add dt bindings for WCD9340/WCD9341 audio codec Srinivas Kandagatla
2019-10-25 20:43 ` Rob Herring
2019-10-28 12:40 ` Srinivas Kandagatla
2019-10-28 12:45 ` Srinivas Kandagatla
2019-10-29 20:47 ` Rob Herring
2019-10-30 9:55 ` Srinivas Kandagatla
2019-11-05 19:08 ` Rob Herring
2019-11-06 18:09 ` Srinivas Kandagatla
2019-11-06 19:20 ` Rob Herring
2019-10-18 0:18 ` [PATCH v2 02/11] mfd: wcd934x: add support to wcd9340/wcd9341 codec Srinivas Kandagatla
2019-10-21 10:46 ` Lee Jones
2019-10-21 11:25 ` Srinivas Kandagatla
2019-10-21 11:45 ` Lee Jones
2019-10-21 12:14 ` Srinivas Kandagatla [this message]
2019-10-21 13:19 ` Lee Jones
2019-10-18 0:18 ` [PATCH v2 03/11] ASoC: " Srinivas Kandagatla
2019-10-18 0:18 ` [PATCH v2 04/11] ASoC: wcd934x: add basic controls Srinivas Kandagatla
2019-10-18 0:18 ` [PATCH v2 05/11] ASoC: wcd934x: add playback dapm widgets Srinivas Kandagatla
2019-10-20 20:05 ` Cezary Rojewski
2019-10-21 9:46 ` Srinivas Kandagatla
2019-10-18 0:18 ` [PATCH v2 06/11] ASoC: wcd934x: add capture " Srinivas Kandagatla
2019-10-18 0:18 ` [PATCH v2 07/11] ASoC: wcd934x: add audio routings Srinivas Kandagatla
2019-10-18 0:18 ` [PATCH v2 08/11] dt-bindings: pinctrl: qcom-wcd934x: Add bindings for gpio Srinivas Kandagatla
2019-10-25 21:00 ` Rob Herring
2019-10-28 12:41 ` Srinivas Kandagatla
2019-10-18 0:18 ` [PATCH v2 09/11] pinctrl: qcom-wcd934x: Add support to wcd934x pinctrl driver Srinivas Kandagatla
2019-10-18 0:18 ` [PATCH v2 10/11] ASoC: dt-bindings: Add compatible for DB845c and Lenovo Yoga Srinivas Kandagatla
2019-10-25 21:01 ` Rob Herring
2019-10-18 0:18 ` [PATCH v2 11/11] ASoC: qcom: sdm845: add support to " Srinivas Kandagatla
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=38dde3d9-8d7e-7dc0-7cba-137b43cea9d1@linaro.org \
--to=srinivas.kandagatla@linaro.org \
--cc=alsa-devel@alsa-project.org \
--cc=bgoswami@codeaurora.org \
--cc=broonie@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=lee.jones@linaro.org \
--cc=linus.walleij@linaro.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=robh@kernel.org \
--cc=spapothi@codeaurora.org \
--cc=vinod.koul@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).