From mboxrd@z Thu Jan 1 00:00:00 1970 From: Arnd Bergmann Subject: Re: [resend v2: PATCH 1/2] dt-bindings: Document the hi3660 reset bindings Date: Thu, 01 Dec 2016 13:05:03 +0100 Message-ID: <3900806.3NUubBDb0Q@wuerfel> References: <1480553321-17400-1-git-send-email-zhangfei.gao@linaro.org> <1480553321-17400-2-git-send-email-zhangfei.gao@linaro.org> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7Bit Return-path: In-Reply-To: <1480553321-17400-2-git-send-email-zhangfei.gao-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org> Sender: devicetree-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Zhangfei Gao Cc: Rob Herring , Philipp Zabel , linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org, devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org List-Id: devicetree@vger.kernel.org On Thursday, December 1, 2016 8:48:40 AM CET Zhangfei Gao wrote: > + hisi,reset-bits = <0x20 0x8 /* 0: i2c0 */ > + 0x20 0x10 /* 1: i2c1 */ > + 0x20 0x20 /* 2: i2c2 */ > + 0x20 0x8000000>; /* 3: i2c6 */ > + }; > + > +Specifying reset lines connected to IP modules > +============================================== > +example: > + > + i2c0: i2c@..... { > + ... > + resets = <&iomcu_rst 0>; > + ... > + }; I don't really like this approach, since now the information is in two places. Why not put the data into the reset specifier directly when it is used? Also the format seems a little too close to the actual register layout and could be a little more abstract, using bit numbers instead of a bitmask and register numbers instead of offsets. Arnd -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html