devicetree.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH 0/4] Add R5F and C7xv device nodes
@ 2025-01-27 22:16 Judith Mendez
  2025-01-27 22:16 ` [PATCH 1/4] arm64: dts: ti: k3-am62-wakeup: Add wakeup r5f node Judith Mendez
                   ` (4 more replies)
  0 siblings, 5 replies; 13+ messages in thread
From: Judith Mendez @ 2025-01-27 22:16 UTC (permalink / raw)
  To: Nishanth Menon, Vignesh Raghavendra
  Cc: Rob Herring, Krzysztof Kozlowski, Conor Dooley, linux-arm-kernel,
	devicetree, linux-kernel, Devarsh Thakkar, Hari Nagalla

For am62x and am62ax devices, this patch series adds device
nodes for the R5 cores and C7xv DSP subsystem found in their
respective voltage domain, based on the device TRMs [0][1].

Boot tested on am62x SK and am62ax SK boards.

[0] https://www.ti.com/lit/pdf/spruj16
[1] https://www.ti.com/lit/pdf/spruiv7

Devarsh Thakkar (1):
  arm64: dts: ti: k3-am62a-wakeup: Add R5F device node

Hari Nagalla (2):
  arm64: dts: ti: k3-am62-wakeup: Add wakeup r5f node
  arm64: dts: ti: k3-am62a-mcu: Add R5F remote proc node

Jai Luthra (1):
  arm64: dts: ti: k3-am62a-main: Add C7xv device node

 arch/arm64/boot/dts/ti/k3-am62-wakeup.dtsi  | 24 ++++++++++++++
 arch/arm64/boot/dts/ti/k3-am62a-main.dtsi   | 11 +++++++
 arch/arm64/boot/dts/ti/k3-am62a-mcu.dtsi    | 36 +++++++++++++++++++++
 arch/arm64/boot/dts/ti/k3-am62a-wakeup.dtsi | 23 +++++++++++++
 4 files changed, 94 insertions(+)

-- 
2.48.0


^ permalink raw reply	[flat|nested] 13+ messages in thread

* [PATCH 1/4] arm64: dts: ti: k3-am62-wakeup: Add wakeup r5f node
  2025-01-27 22:16 [PATCH 0/4] Add R5F and C7xv device nodes Judith Mendez
@ 2025-01-27 22:16 ` Judith Mendez
  2025-01-28 16:22   ` Andrew Davis
  2025-01-27 22:16 ` [PATCH 2/4] arm64: dts: ti: k3-am62a-mcu: Add R5F remote proc node Judith Mendez
                   ` (3 subsequent siblings)
  4 siblings, 1 reply; 13+ messages in thread
From: Judith Mendez @ 2025-01-27 22:16 UTC (permalink / raw)
  To: Nishanth Menon, Vignesh Raghavendra
  Cc: Rob Herring, Krzysztof Kozlowski, Conor Dooley, linux-arm-kernel,
	devicetree, linux-kernel, Devarsh Thakkar, Hari Nagalla

From: Hari Nagalla <hnagalla@ti.com>

AM62 SoC devices have a single core R5F processor in wakeup domain.
The R5F processor in wakeup domain is used as a device manager
for the SoC.

Co-authored-by: Devarsh Thakkar <devarsht@ti.com>
Signed-off-by: Hari Nagalla <hnagalla@ti.com>
[Judith: Fix commit message header]
Signed-off-by: Judith Mendez <jm@ti.com>
---
 arch/arm64/boot/dts/ti/k3-am62-wakeup.dtsi | 24 ++++++++++++++++++++++
 1 file changed, 24 insertions(+)

diff --git a/arch/arm64/boot/dts/ti/k3-am62-wakeup.dtsi b/arch/arm64/boot/dts/ti/k3-am62-wakeup.dtsi
index 9b8a1f85aa15c..79708c1c214f8 100644
--- a/arch/arm64/boot/dts/ti/k3-am62-wakeup.dtsi
+++ b/arch/arm64/boot/dts/ti/k3-am62-wakeup.dtsi
@@ -106,6 +106,30 @@ wkup_rti0: watchdog@2b000000 {
 		status = "reserved";
 	};
 
+	wkup_r5fss0: r5fss@78000000 {
+		compatible = "ti,am62-r5fss";
+		#address-cells = <1>;
+		#size-cells = <1>;
+		ranges = <0x78000000 0x00 0x78000000 0x8000>,
+				 <0x78100000 0x00 0x78100000 0x8000>;
+		power-domains = <&k3_pds 119 TI_SCI_PD_EXCLUSIVE>;
+
+		wkup_r5fss0_core0: r5f@78000000 {
+			compatible = "ti,am62-r5f";
+			reg = <0x78000000 0x00008000>,
+			      <0x78100000 0x00008000>;
+			reg-names = "atcm", "btcm";
+			ti,sci = <&dmsc>;
+			ti,sci-dev-id = <121>;
+			ti,sci-proc-ids = <0x01 0xff>;
+			resets = <&k3_reset 121 1>;
+			firmware-name = "ti-sysfw/ti-fs-stub-firmware-am62x-gp-signed.bin";
+			ti,atcm-enable = <1>;
+			ti,btcm-enable = <1>;
+			ti,loczrama = <1>;
+		};
+	};
+
 	wkup_vtm0: temperature-sensor@b00000 {
 		compatible = "ti,j7200-vtm";
 		reg = <0x00 0xb00000 0x00 0x400>,
-- 
2.48.0


^ permalink raw reply related	[flat|nested] 13+ messages in thread

* [PATCH 2/4] arm64: dts: ti: k3-am62a-mcu: Add R5F remote proc node
  2025-01-27 22:16 [PATCH 0/4] Add R5F and C7xv device nodes Judith Mendez
  2025-01-27 22:16 ` [PATCH 1/4] arm64: dts: ti: k3-am62-wakeup: Add wakeup r5f node Judith Mendez
@ 2025-01-27 22:16 ` Judith Mendez
  2025-01-28 16:27   ` Andrew Davis
  2025-01-27 22:16 ` [PATCH 3/4] arm64: dts: ti: k3-am62a-wakeup: Add R5F device node Judith Mendez
                   ` (2 subsequent siblings)
  4 siblings, 1 reply; 13+ messages in thread
From: Judith Mendez @ 2025-01-27 22:16 UTC (permalink / raw)
  To: Nishanth Menon, Vignesh Raghavendra
  Cc: Rob Herring, Krzysztof Kozlowski, Conor Dooley, linux-arm-kernel,
	devicetree, linux-kernel, Devarsh Thakkar, Hari Nagalla

From: Hari Nagalla <hnagalla@ti.com>

AM62A SoCs have a single R5F core in the MCU voltage domain. The MCU
domain also has a 512KB sram memory, the R5F core can use for
applications needing fast memory access.

Signed-off-by: Hari Nagalla <hnagalla@ti.com>
[Judith: Fix commit message header]
Signed-off-by: Judith Mendez <jm@ti.com>
---
 arch/arm64/boot/dts/ti/k3-am62a-mcu.dtsi | 36 ++++++++++++++++++++++++
 1 file changed, 36 insertions(+)

diff --git a/arch/arm64/boot/dts/ti/k3-am62a-mcu.dtsi b/arch/arm64/boot/dts/ti/k3-am62a-mcu.dtsi
index 0469c766b769e..9a20f75e48063 100644
--- a/arch/arm64/boot/dts/ti/k3-am62a-mcu.dtsi
+++ b/arch/arm64/boot/dts/ti/k3-am62a-mcu.dtsi
@@ -6,6 +6,18 @@
  */
 
 &cbass_mcu {
+	mcu_ram: sram@79100000 {
+		compatible = "mmio-sram";
+		reg = <0x00 0x79100000 0x00 0x80000>;
+		ranges = <0x00 0x00 0x79100000 0x80000>;
+		#address-cells = <1>;
+		#size-cells = <1>;
+
+		mcu1-sram@0 {
+			reg = <0x0 0x80000>;
+		};
+	};
+
 	mcu_pmx0: pinctrl@4084000 {
 		compatible = "pinctrl-single";
 		reg = <0x00 0x04084000 0x00 0x88>;
@@ -175,4 +187,28 @@ mcu_mcan1: can@4e18000 {
 		bosch,mram-cfg = <0x0 128 64 64 64 64 32 32>;
 		status = "disabled";
 	};
+
+	mcu_r5fss0: r5fss@79000000 {
+		compatible = "ti,am62-r5fss";
+		#address-cells = <1>;
+		#size-cells = <1>;
+		ranges = <0x79000000 0x00 0x79000000 0x8000>,
+			 <0x79020000 0x00 0x79020000 0x8000>;
+		power-domains = <&k3_pds 7 TI_SCI_PD_EXCLUSIVE>;
+		mcu_r5fss0_core0: r5f@79000000 {
+			compatible = "ti,am62-r5f";
+			reg = <0x79000000 0x00008000>,
+				<0x79020000 0x00008000>;
+			reg-names = "atcm", "btcm";
+			ti,sci = <&dmsc>;
+			ti,sci-dev-id = <9>;
+			ti,sci-proc-ids = <0x03 0xff>;
+			resets = <&k3_reset 9 1>;
+			firmware-name = "am62a-mcu-r5f0_0-fw";
+			ti,atcm-enable = <0>;
+			ti,btcm-enable = <1>;
+			ti,loczrama = <0>;
+			sram = <&mcu_ram>;
+		};
+	};
 };
-- 
2.48.0


^ permalink raw reply related	[flat|nested] 13+ messages in thread

* [PATCH 3/4] arm64: dts: ti: k3-am62a-wakeup: Add R5F device node
  2025-01-27 22:16 [PATCH 0/4] Add R5F and C7xv device nodes Judith Mendez
  2025-01-27 22:16 ` [PATCH 1/4] arm64: dts: ti: k3-am62-wakeup: Add wakeup r5f node Judith Mendez
  2025-01-27 22:16 ` [PATCH 2/4] arm64: dts: ti: k3-am62a-mcu: Add R5F remote proc node Judith Mendez
@ 2025-01-27 22:16 ` Judith Mendez
  2025-01-27 22:16 ` [PATCH 4/4] arm64: dts: ti: k3-am62a-main: Add C7xv " Judith Mendez
  2025-01-27 22:37 ` [PATCH 0/4] Add R5F and C7xv device nodes Rob Herring (Arm)
  4 siblings, 0 replies; 13+ messages in thread
From: Judith Mendez @ 2025-01-27 22:16 UTC (permalink / raw)
  To: Nishanth Menon, Vignesh Raghavendra
  Cc: Rob Herring, Krzysztof Kozlowski, Conor Dooley, linux-arm-kernel,
	devicetree, linux-kernel, Devarsh Thakkar, Hari Nagalla

From: Devarsh Thakkar <devarsht@ti.com>

AM62A SoCs have a single R5F core in wakeup domain. This core is
also used as a device manager for the SoC.

Signed-off-by: Devarsh Thakkar <devarsht@ti.com>
Signed-off-by: Hari Nagalla <hnagalla@ti.com>
[Judith: Fix commit message header]
Signed-off-by: Judith Mendez <jm@ti.com>
---
 arch/arm64/boot/dts/ti/k3-am62a-wakeup.dtsi | 23 +++++++++++++++++++++
 1 file changed, 23 insertions(+)

diff --git a/arch/arm64/boot/dts/ti/k3-am62a-wakeup.dtsi b/arch/arm64/boot/dts/ti/k3-am62a-wakeup.dtsi
index b2c8f53517438..6dc211d485c63 100644
--- a/arch/arm64/boot/dts/ti/k3-am62a-wakeup.dtsi
+++ b/arch/arm64/boot/dts/ti/k3-am62a-wakeup.dtsi
@@ -103,6 +103,29 @@ wkup_rti0: watchdog@2b000000 {
 		status = "reserved";
 	};
 
+	wkup_r5fss0: r5fss@78000000 {
+		compatible = "ti,am62-r5fss";
+		#address-cells = <1>;
+		#size-cells = <1>;
+		ranges = <0x78000000 0x00 0x78000000 0x8000>,
+			 <0x78100000 0x00 0x78100000 0x8000>;
+		power-domains = <&k3_pds 119 TI_SCI_PD_EXCLUSIVE>;
+		wkup_r5fss0_core0: r5f@78000000 {
+			compatible = "ti,am62-r5f";
+			reg = <0x78000000 0x00008000>,
+				<0x78100000 0x00008000>;
+			reg-names = "atcm", "btcm";
+			ti,sci = <&dmsc>;
+			ti,sci-dev-id = <121>;
+			ti,sci-proc-ids = <0x01 0xff>;
+			resets = <&k3_reset 121 1>;
+			firmware-name = "am62-wkup-r5f0_0-fw";
+			ti,atcm-enable = <1>;
+			ti,btcm-enable = <1>;
+			ti,loczrama = <1>;
+		};
+	};
+
 	wkup_vtm0: temperature-sensor@b00000 {
 		compatible = "ti,j7200-vtm";
 		reg = <0x00 0xb00000 0x00 0x400>,
-- 
2.48.0


^ permalink raw reply related	[flat|nested] 13+ messages in thread

* [PATCH 4/4] arm64: dts: ti: k3-am62a-main: Add C7xv device node
  2025-01-27 22:16 [PATCH 0/4] Add R5F and C7xv device nodes Judith Mendez
                   ` (2 preceding siblings ...)
  2025-01-27 22:16 ` [PATCH 3/4] arm64: dts: ti: k3-am62a-wakeup: Add R5F device node Judith Mendez
@ 2025-01-27 22:16 ` Judith Mendez
  2025-01-27 22:37 ` [PATCH 0/4] Add R5F and C7xv device nodes Rob Herring (Arm)
  4 siblings, 0 replies; 13+ messages in thread
From: Judith Mendez @ 2025-01-27 22:16 UTC (permalink / raw)
  To: Nishanth Menon, Vignesh Raghavendra
  Cc: Rob Herring, Krzysztof Kozlowski, Conor Dooley, linux-arm-kernel,
	devicetree, linux-kernel, Devarsh Thakkar, Hari Nagalla

From: Jai Luthra <j-luthra@ti.com>

AM62A SoCs have a C7xv DSP subsystem with Analytics engine capability.
This subsystem is intended for deep learning purposes. Define the
device node for C7xv DSP.

Signed-off-by: Jai Luthra <j-luthra@ti.com>
Signed-off-by: Hari Nagalla <hnagalla@ti.com>
[Judith: Fix commit message header]
Signed-off-by: Judith Mendez <jm@ti.com>
---
 arch/arm64/boot/dts/ti/k3-am62a-main.dtsi | 11 +++++++++++
 1 file changed, 11 insertions(+)

diff --git a/arch/arm64/boot/dts/ti/k3-am62a-main.dtsi b/arch/arm64/boot/dts/ti/k3-am62a-main.dtsi
index a1daba7b1fad5..08ce57daab1ed 100644
--- a/arch/arm64/boot/dts/ti/k3-am62a-main.dtsi
+++ b/arch/arm64/boot/dts/ti/k3-am62a-main.dtsi
@@ -1123,6 +1123,17 @@ vpu: video-codec@30210000 {
 		power-domains = <&k3_pds 204 TI_SCI_PD_EXCLUSIVE>;
 	};
 
+	c7x_0: dsp@7e000000 {
+		compatible = "ti,am62a-c7xv-dsp";
+		reg = <0x00 0x7e000000 0x00 0x00100000>;
+		reg-names = "l2sram";
+		ti,sci = <&dmsc>;
+		ti,sci-dev-id = <208>;
+		ti,sci-proc-ids = <0x04 0xff>;
+		resets = <&k3_reset 208 1>;
+		firmware-name = "am62a-c71_0-fw";
+	};
+
 	e5010: jpeg-encoder@fd20000 {
 		compatible = "ti,am62a-jpeg-enc", "img,e5010-jpeg-enc";
 		reg = <0x00 0xfd20000 0x00 0x100>,
-- 
2.48.0


^ permalink raw reply related	[flat|nested] 13+ messages in thread

* Re: [PATCH 0/4] Add R5F and C7xv device nodes
  2025-01-27 22:16 [PATCH 0/4] Add R5F and C7xv device nodes Judith Mendez
                   ` (3 preceding siblings ...)
  2025-01-27 22:16 ` [PATCH 4/4] arm64: dts: ti: k3-am62a-main: Add C7xv " Judith Mendez
@ 2025-01-27 22:37 ` Rob Herring (Arm)
  4 siblings, 0 replies; 13+ messages in thread
From: Rob Herring (Arm) @ 2025-01-27 22:37 UTC (permalink / raw)
  To: Judith Mendez
  Cc: linux-kernel, Hari Nagalla, devicetree, Conor Dooley,
	linux-arm-kernel, Devarsh Thakkar, Nishanth Menon,
	Vignesh Raghavendra, Krzysztof Kozlowski


On Mon, 27 Jan 2025 16:16:27 -0600, Judith Mendez wrote:
> For am62x and am62ax devices, this patch series adds device
> nodes for the R5 cores and C7xv DSP subsystem found in their
> respective voltage domain, based on the device TRMs [0][1].
> 
> Boot tested on am62x SK and am62ax SK boards.
> 
> [0] https://www.ti.com/lit/pdf/spruj16
> [1] https://www.ti.com/lit/pdf/spruiv7
> 
> Devarsh Thakkar (1):
>   arm64: dts: ti: k3-am62a-wakeup: Add R5F device node
> 
> Hari Nagalla (2):
>   arm64: dts: ti: k3-am62-wakeup: Add wakeup r5f node
>   arm64: dts: ti: k3-am62a-mcu: Add R5F remote proc node
> 
> Jai Luthra (1):
>   arm64: dts: ti: k3-am62a-main: Add C7xv device node
> 
>  arch/arm64/boot/dts/ti/k3-am62-wakeup.dtsi  | 24 ++++++++++++++
>  arch/arm64/boot/dts/ti/k3-am62a-main.dtsi   | 11 +++++++
>  arch/arm64/boot/dts/ti/k3-am62a-mcu.dtsi    | 36 +++++++++++++++++++++
>  arch/arm64/boot/dts/ti/k3-am62a-wakeup.dtsi | 23 +++++++++++++
>  4 files changed, 94 insertions(+)
> 
> --
> 2.48.0
> 
> 
> 


My bot found new DTB warnings on the .dts files added or changed in this
series.

Some warnings may be from an existing SoC .dtsi. Or perhaps the warnings
are fixed by another series. Ultimately, it is up to the platform
maintainer whether these warnings are acceptable or not. No need to reply
unless the platform maintainer has comments.

If you already ran DT checks and didn't see these error(s), then
make sure dt-schema is up to date:

  pip3 install dtschema --upgrade


New warnings running 'make CHECK_DTBS=y for arch/arm64/boot/dts/ti/' for 20250127221631.3974583-1-jm@ti.com:

arch/arm64/boot/dts/ti/k3-am62a7-sk.dtb: dsp@7e000000: 'mboxes' is a required property
	from schema $id: http://devicetree.org/schemas/remoteproc/ti,k3-dsp-rproc.yaml#
arch/arm64/boot/dts/ti/k3-am62a7-sk.dtb: dsp@7e000000: 'memory-region' is a required property
	from schema $id: http://devicetree.org/schemas/remoteproc/ti,k3-dsp-rproc.yaml#
arch/arm64/boot/dts/ti/k3-am62a7-phyboard-lyra-rdk.dtb: dsp@7e000000: 'mboxes' is a required property
	from schema $id: http://devicetree.org/schemas/remoteproc/ti,k3-dsp-rproc.yaml#
arch/arm64/boot/dts/ti/k3-am62a7-phyboard-lyra-rdk.dtb: dsp@7e000000: 'memory-region' is a required property
	from schema $id: http://devicetree.org/schemas/remoteproc/ti,k3-dsp-rproc.yaml#






^ permalink raw reply	[flat|nested] 13+ messages in thread

* Re: [PATCH 1/4] arm64: dts: ti: k3-am62-wakeup: Add wakeup r5f node
  2025-01-27 22:16 ` [PATCH 1/4] arm64: dts: ti: k3-am62-wakeup: Add wakeup r5f node Judith Mendez
@ 2025-01-28 16:22   ` Andrew Davis
  2025-01-28 16:27     ` Judith Mendez
  0 siblings, 1 reply; 13+ messages in thread
From: Andrew Davis @ 2025-01-28 16:22 UTC (permalink / raw)
  To: Judith Mendez, Nishanth Menon, Vignesh Raghavendra
  Cc: Rob Herring, Krzysztof Kozlowski, Conor Dooley, linux-arm-kernel,
	devicetree, linux-kernel, Devarsh Thakkar, Hari Nagalla

On 1/27/25 4:16 PM, Judith Mendez wrote:
> From: Hari Nagalla <hnagalla@ti.com>
> 
> AM62 SoC devices have a single core R5F processor in wakeup domain.
> The R5F processor in wakeup domain is used as a device manager
> for the SoC.
> 
> Co-authored-by: Devarsh Thakkar <devarsht@ti.com>
> Signed-off-by: Hari Nagalla <hnagalla@ti.com>
> [Judith: Fix commit message header]
> Signed-off-by: Judith Mendez <jm@ti.com>
> ---
>   arch/arm64/boot/dts/ti/k3-am62-wakeup.dtsi | 24 ++++++++++++++++++++++
>   1 file changed, 24 insertions(+)
> 
> diff --git a/arch/arm64/boot/dts/ti/k3-am62-wakeup.dtsi b/arch/arm64/boot/dts/ti/k3-am62-wakeup.dtsi
> index 9b8a1f85aa15c..79708c1c214f8 100644
> --- a/arch/arm64/boot/dts/ti/k3-am62-wakeup.dtsi
> +++ b/arch/arm64/boot/dts/ti/k3-am62-wakeup.dtsi
> @@ -106,6 +106,30 @@ wkup_rti0: watchdog@2b000000 {
>   		status = "reserved";
>   	};
>   
> +	wkup_r5fss0: r5fss@78000000 {
> +		compatible = "ti,am62-r5fss";
> +		#address-cells = <1>;
> +		#size-cells = <1>;
> +		ranges = <0x78000000 0x00 0x78000000 0x8000>,
> +				 <0x78100000 0x00 0x78100000 0x8000>;
> +		power-domains = <&k3_pds 119 TI_SCI_PD_EXCLUSIVE>;
> +
> +		wkup_r5fss0_core0: r5f@78000000 {
> +			compatible = "ti,am62-r5f";
> +			reg = <0x78000000 0x00008000>,
> +			      <0x78100000 0x00008000>;
> +			reg-names = "atcm", "btcm";
> +			ti,sci = <&dmsc>;
> +			ti,sci-dev-id = <121>;
> +			ti,sci-proc-ids = <0x01 0xff>;
> +			resets = <&k3_reset 121 1>;
> +			firmware-name = "ti-sysfw/ti-fs-stub-firmware-am62x-gp-signed.bin";

What is this firmware name? This doesn't exist in linux-firmware,
should use the normal name like "am62-wkup-r5f0_0-fw", then we
can use symlinks in our userspace to map to whatever firmware we
want to run.

Andrew

> +			ti,atcm-enable = <1>;
> +			ti,btcm-enable = <1>;
> +			ti,loczrama = <1>;
> +		};
> +	};
> +
>   	wkup_vtm0: temperature-sensor@b00000 {
>   		compatible = "ti,j7200-vtm";
>   		reg = <0x00 0xb00000 0x00 0x400>,

^ permalink raw reply	[flat|nested] 13+ messages in thread

* Re: [PATCH 1/4] arm64: dts: ti: k3-am62-wakeup: Add wakeup r5f node
  2025-01-28 16:22   ` Andrew Davis
@ 2025-01-28 16:27     ` Judith Mendez
  0 siblings, 0 replies; 13+ messages in thread
From: Judith Mendez @ 2025-01-28 16:27 UTC (permalink / raw)
  To: Andrew Davis, Nishanth Menon, Vignesh Raghavendra
  Cc: Rob Herring, Krzysztof Kozlowski, Conor Dooley, linux-arm-kernel,
	devicetree, linux-kernel, Devarsh Thakkar, Hari Nagalla

Hi Andrew,

On 1/28/25 10:22 AM, Andrew Davis wrote:
> On 1/27/25 4:16 PM, Judith Mendez wrote:
>> From: Hari Nagalla <hnagalla@ti.com>
>>
>> AM62 SoC devices have a single core R5F processor in wakeup domain.
>> The R5F processor in wakeup domain is used as a device manager
>> for the SoC.
>>
>> Co-authored-by: Devarsh Thakkar <devarsht@ti.com>
>> Signed-off-by: Hari Nagalla <hnagalla@ti.com>
>> [Judith: Fix commit message header]
>> Signed-off-by: Judith Mendez <jm@ti.com>
>> ---
>>   arch/arm64/boot/dts/ti/k3-am62-wakeup.dtsi | 24 ++++++++++++++++++++++
>>   1 file changed, 24 insertions(+)
>>
>> diff --git a/arch/arm64/boot/dts/ti/k3-am62-wakeup.dtsi 
>> b/arch/arm64/boot/dts/ti/k3-am62-wakeup.dtsi
>> index 9b8a1f85aa15c..79708c1c214f8 100644
>> --- a/arch/arm64/boot/dts/ti/k3-am62-wakeup.dtsi
>> +++ b/arch/arm64/boot/dts/ti/k3-am62-wakeup.dtsi
>> @@ -106,6 +106,30 @@ wkup_rti0: watchdog@2b000000 {
>>           status = "reserved";
>>       };
>> +    wkup_r5fss0: r5fss@78000000 {
>> +        compatible = "ti,am62-r5fss";
>> +        #address-cells = <1>;
>> +        #size-cells = <1>;
>> +        ranges = <0x78000000 0x00 0x78000000 0x8000>,
>> +                 <0x78100000 0x00 0x78100000 0x8000>;
>> +        power-domains = <&k3_pds 119 TI_SCI_PD_EXCLUSIVE>;
>> +
>> +        wkup_r5fss0_core0: r5f@78000000 {
>> +            compatible = "ti,am62-r5f";
>> +            reg = <0x78000000 0x00008000>,
>> +                  <0x78100000 0x00008000>;
>> +            reg-names = "atcm", "btcm";
>> +            ti,sci = <&dmsc>;
>> +            ti,sci-dev-id = <121>;
>> +            ti,sci-proc-ids = <0x01 0xff>;
>> +            resets = <&k3_reset 121 1>;
>> +            firmware-name = 
>> "ti-sysfw/ti-fs-stub-firmware-am62x-gp-signed.bin";
> 
> What is this firmware name? This doesn't exist in linux-firmware,
> should use the normal name like "am62-wkup-r5f0_0-fw", then we
> can use symlinks in our userspace to map to whatever firmware we
> want to run.

Understood, will respin with fixed name, thanks.

~ Judith

> 
> Andrew
> 
>> +            ti,atcm-enable = <1>;
>> +            ti,btcm-enable = <1>;
>> +            ti,loczrama = <1>;
>> +        };
>> +    };
>> +
>>       wkup_vtm0: temperature-sensor@b00000 {
>>           compatible = "ti,j7200-vtm";
>>           reg = <0x00 0xb00000 0x00 0x400>,


^ permalink raw reply	[flat|nested] 13+ messages in thread

* Re: [PATCH 2/4] arm64: dts: ti: k3-am62a-mcu: Add R5F remote proc node
  2025-01-27 22:16 ` [PATCH 2/4] arm64: dts: ti: k3-am62a-mcu: Add R5F remote proc node Judith Mendez
@ 2025-01-28 16:27   ` Andrew Davis
  2025-01-28 16:52     ` Hari Nagalla
  0 siblings, 1 reply; 13+ messages in thread
From: Andrew Davis @ 2025-01-28 16:27 UTC (permalink / raw)
  To: Judith Mendez, Nishanth Menon, Vignesh Raghavendra
  Cc: Rob Herring, Krzysztof Kozlowski, Conor Dooley, linux-arm-kernel,
	devicetree, linux-kernel, Devarsh Thakkar, Hari Nagalla

On 1/27/25 4:16 PM, Judith Mendez wrote:
> From: Hari Nagalla <hnagalla@ti.com>
> 
> AM62A SoCs have a single R5F core in the MCU voltage domain. The MCU
> domain also has a 512KB sram memory, the R5F core can use for
> applications needing fast memory access.
> 
> Signed-off-by: Hari Nagalla <hnagalla@ti.com>
> [Judith: Fix commit message header]
> Signed-off-by: Judith Mendez <jm@ti.com>
> ---
>   arch/arm64/boot/dts/ti/k3-am62a-mcu.dtsi | 36 ++++++++++++++++++++++++
>   1 file changed, 36 insertions(+)
> 
> diff --git a/arch/arm64/boot/dts/ti/k3-am62a-mcu.dtsi b/arch/arm64/boot/dts/ti/k3-am62a-mcu.dtsi
> index 0469c766b769e..9a20f75e48063 100644
> --- a/arch/arm64/boot/dts/ti/k3-am62a-mcu.dtsi
> +++ b/arch/arm64/boot/dts/ti/k3-am62a-mcu.dtsi
> @@ -6,6 +6,18 @@
>    */
>   
>   &cbass_mcu {
> +	mcu_ram: sram@79100000 {
> +		compatible = "mmio-sram";
> +		reg = <0x00 0x79100000 0x00 0x80000>;
> +		ranges = <0x00 0x00 0x79100000 0x80000>;
> +		#address-cells = <1>;
> +		#size-cells = <1>;
> +
> +		mcu1-sram@0 {
> +			reg = <0x0 0x80000>;
> +		};
> +	};
> +
>   	mcu_pmx0: pinctrl@4084000 {
>   		compatible = "pinctrl-single";
>   		reg = <0x00 0x04084000 0x00 0x88>;
> @@ -175,4 +187,28 @@ mcu_mcan1: can@4e18000 {
>   		bosch,mram-cfg = <0x0 128 64 64 64 64 32 32>;
>   		status = "disabled";
>   	};
> +
> +	mcu_r5fss0: r5fss@79000000 {
> +		compatible = "ti,am62-r5fss";
> +		#address-cells = <1>;
> +		#size-cells = <1>;
> +		ranges = <0x79000000 0x00 0x79000000 0x8000>,
> +			 <0x79020000 0x00 0x79020000 0x8000>;
> +		power-domains = <&k3_pds 7 TI_SCI_PD_EXCLUSIVE>;

Newline here.

Also this should be default "disabled". It can be set to "okay"
in the board DTS file when the needed mboxes and memory-region
are set. Speaking of that, where are those patches? This is
incomplete without them and these nodes will not function.
Same for the DSP patch.

Andrew

> +		mcu_r5fss0_core0: r5f@79000000 {
> +			compatible = "ti,am62-r5f";
> +			reg = <0x79000000 0x00008000>,
> +				<0x79020000 0x00008000>;
> +			reg-names = "atcm", "btcm";
> +			ti,sci = <&dmsc>;
> +			ti,sci-dev-id = <9>;
> +			ti,sci-proc-ids = <0x03 0xff>;
> +			resets = <&k3_reset 9 1>;
> +			firmware-name = "am62a-mcu-r5f0_0-fw";
> +			ti,atcm-enable = <0>;
> +			ti,btcm-enable = <1>;
> +			ti,loczrama = <0>;
> +			sram = <&mcu_ram>;
> +		};
> +	};
>   };

^ permalink raw reply	[flat|nested] 13+ messages in thread

* Re: [PATCH 2/4] arm64: dts: ti: k3-am62a-mcu: Add R5F remote proc node
  2025-01-28 16:27   ` Andrew Davis
@ 2025-01-28 16:52     ` Hari Nagalla
  2025-01-28 17:48       ` Judith Mendez
  0 siblings, 1 reply; 13+ messages in thread
From: Hari Nagalla @ 2025-01-28 16:52 UTC (permalink / raw)
  To: Andrew Davis, Judith Mendez, Nishanth Menon, Vignesh Raghavendra
  Cc: Rob Herring, Krzysztof Kozlowski, Conor Dooley, linux-arm-kernel,
	devicetree, linux-kernel, Devarsh Thakkar

On 1/28/25 10:27, Andrew Davis wrote:
>> +    mcu_r5fss0: r5fss@79000000 {
>> +        compatible = "ti,am62-r5fss";
>> +        #address-cells = <1>;
>> +        #size-cells = <1>;
>> +        ranges = <0x79000000 0x00 0x79000000 0x8000>,
>> +             <0x79020000 0x00 0x79020000 0x8000>;
>> +        power-domains = <&k3_pds 7 TI_SCI_PD_EXCLUSIVE>;
> 
> Newline here.
> 
> Also this should be default "disabled". It can be set to "okay"
> in the board DTS file when the needed mboxes and memory-region
> are set. Speaking of that, where are those patches? This is
> incomplete without them and these nodes will not function.
> Same for the DSP patch.
> 
> Andrew
Yes, by default needs to set the node state to "disabled". This is HW 
description of the wake-up domain components. Memory carve outs and 
mailbox assignments for IPC are a separate patch as it is configurable 
and distro dependent.

^ permalink raw reply	[flat|nested] 13+ messages in thread

* Re: [PATCH 2/4] arm64: dts: ti: k3-am62a-mcu: Add R5F remote proc node
  2025-01-28 16:52     ` Hari Nagalla
@ 2025-01-28 17:48       ` Judith Mendez
  2025-01-30 22:40         ` Judith Mendez
  0 siblings, 1 reply; 13+ messages in thread
From: Judith Mendez @ 2025-01-28 17:48 UTC (permalink / raw)
  To: Hari Nagalla, Andrew Davis, Nishanth Menon, Vignesh Raghavendra
  Cc: Rob Herring, Krzysztof Kozlowski, Conor Dooley, linux-arm-kernel,
	devicetree, linux-kernel, Devarsh Thakkar

Hi Andrew,

On 1/28/25 10:52 AM, Hari Nagalla wrote:
> On 1/28/25 10:27, Andrew Davis wrote:
>>> +    mcu_r5fss0: r5fss@79000000 {
>>> +        compatible = "ti,am62-r5fss";
>>> +        #address-cells = <1>;
>>> +        #size-cells = <1>;
>>> +        ranges = <0x79000000 0x00 0x79000000 0x8000>,
>>> +             <0x79020000 0x00 0x79020000 0x8000>;
>>> +        power-domains = <&k3_pds 7 TI_SCI_PD_EXCLUSIVE>;
>>
>> Newline here.
>>
>> Also this should be default "disabled". It can be set to "okay"
>> in the board DTS file when the needed mboxes and memory-region
>> are set. Speaking of that, where are those patches? This is
>> incomplete without them and these nodes will not function.
>> Same for the DSP patch.
>>
>> Andrew
> Yes, by default needs to set the node state to "disabled". This is HW 
> description of the wake-up domain components. Memory carve outs and 
> mailbox assignments for IPC are a separate patch as it is configurable 
> and distro dependent.

Yes I plan to disable the nodes in each domain .dtsi file.

Also yes, my understanding is that the memory carveouts could
be a separate series if at all. Not sure if those patches can be
sent upstream since they are distro dependent. Can anyone clarify
if this is the case?

~ Judith

^ permalink raw reply	[flat|nested] 13+ messages in thread

* Re: [PATCH 2/4] arm64: dts: ti: k3-am62a-mcu: Add R5F remote proc node
  2025-01-28 17:48       ` Judith Mendez
@ 2025-01-30 22:40         ` Judith Mendez
  2025-01-31 18:25           ` Andrew Davis
  0 siblings, 1 reply; 13+ messages in thread
From: Judith Mendez @ 2025-01-30 22:40 UTC (permalink / raw)
  To: Hari Nagalla, Andrew Davis
  Cc: Rob Herring, Krzysztof Kozlowski, Conor Dooley, linux-arm-kernel,
	linux-kernel, Devarsh Thakkar, Nishanth Menon,
	Vignesh Raghavendra, devicetree

On 1/28/25 11:48 AM, Judith Mendez wrote:
> Hi Andrew,
> 
> On 1/28/25 10:52 AM, Hari Nagalla wrote:
>> On 1/28/25 10:27, Andrew Davis wrote:
>>>> +    mcu_r5fss0: r5fss@79000000 {
>>>> +        compatible = "ti,am62-r5fss";
>>>> +        #address-cells = <1>;
>>>> +        #size-cells = <1>;
>>>> +        ranges = <0x79000000 0x00 0x79000000 0x8000>,
>>>> +             <0x79020000 0x00 0x79020000 0x8000>;
>>>> +        power-domains = <&k3_pds 7 TI_SCI_PD_EXCLUSIVE>;
>>>
>>> Newline here.
>>>
>>> Also this should be default "disabled". It can be set to "okay"
>>> in the board DTS file when the needed mboxes and memory-region
>>> are set. Speaking of that, where are those patches? This is
>>> incomplete without them and these nodes will not function.
>>> Same for the DSP patch.
>>>
>>> Andrew
>> Yes, by default needs to set the node state to "disabled". This is HW 
>> description of the wake-up domain components. Memory carve outs and 
>> mailbox assignments for IPC are a separate patch as it is configurable 
>> and distro dependent.
> 
> Yes I plan to disable the nodes in each domain .dtsi file.
> 
> Also yes, my understanding is that the memory carveouts could
> be a separate series if at all. Not sure if those patches can be
> sent upstream since they are distro dependent. Can anyone clarify
> if this is the case?
> 

As per offline discussion, I will include the memory carveouts in this
same series.
~ Judith

> ~ Judith
> 


^ permalink raw reply	[flat|nested] 13+ messages in thread

* Re: [PATCH 2/4] arm64: dts: ti: k3-am62a-mcu: Add R5F remote proc node
  2025-01-30 22:40         ` Judith Mendez
@ 2025-01-31 18:25           ` Andrew Davis
  0 siblings, 0 replies; 13+ messages in thread
From: Andrew Davis @ 2025-01-31 18:25 UTC (permalink / raw)
  To: Judith Mendez, Hari Nagalla
  Cc: Rob Herring, Krzysztof Kozlowski, Conor Dooley, linux-arm-kernel,
	linux-kernel, Devarsh Thakkar, Nishanth Menon,
	Vignesh Raghavendra, devicetree

On 1/30/25 4:40 PM, Judith Mendez wrote:
> On 1/28/25 11:48 AM, Judith Mendez wrote:
>> Hi Andrew,
>>
>> On 1/28/25 10:52 AM, Hari Nagalla wrote:
>>> On 1/28/25 10:27, Andrew Davis wrote:
>>>>> +    mcu_r5fss0: r5fss@79000000 {
>>>>> +        compatible = "ti,am62-r5fss";
>>>>> +        #address-cells = <1>;
>>>>> +        #size-cells = <1>;
>>>>> +        ranges = <0x79000000 0x00 0x79000000 0x8000>,
>>>>> +             <0x79020000 0x00 0x79020000 0x8000>;
>>>>> +        power-domains = <&k3_pds 7 TI_SCI_PD_EXCLUSIVE>;
>>>>
>>>> Newline here.
>>>>
>>>> Also this should be default "disabled". It can be set to "okay"
>>>> in the board DTS file when the needed mboxes and memory-region
>>>> are set. Speaking of that, where are those patches? This is
>>>> incomplete without them and these nodes will not function.
>>>> Same for the DSP patch.
>>>>
>>>> Andrew
>>> Yes, by default needs to set the node state to "disabled". This is HW description of the wake-up domain components. Memory carve outs and mailbox assignments for IPC are a separate patch as it is configurable and distro dependent.
>>
>> Yes I plan to disable the nodes in each domain .dtsi file.
>>
>> Also yes, my understanding is that the memory carveouts could
>> be a separate series if at all. Not sure if those patches can be
>> sent upstream since they are distro dependent. Can anyone clarify
>> if this is the case?
>>
> 
> As per offline discussion, I will include the memory carveouts in this
> same series.

It's usually good to fill in some details of "offline discussion" for
folks on the list not in that conversation.

By "distro dependent" we really mean firmware dependent. The carveouts
are set in DT and then most firmware follows the same and hardcode
these addresses. For example[0].

This works well as long as all the firmware uses these standard
addresses. Problem is some legacy firmware did not, and so to use
those firmware the DT would need modified.

For AM62 and AM62A I'm not aware of any such firmware. So this
is a bit of a non-issue and we can safely add the carveouts
like we already do for all other K3 devices.

Andrew

[0] https://github.com/zephyrproject-rtos/zephyr/blob/main/boards/beagle/beaglebone_ai64/beaglebone_ai64_j721e_main_r5f0_0.dts#L30

> ~ Judith
> 
>> ~ Judith
>>
> 

^ permalink raw reply	[flat|nested] 13+ messages in thread

end of thread, other threads:[~2025-01-31 18:26 UTC | newest]

Thread overview: 13+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-01-27 22:16 [PATCH 0/4] Add R5F and C7xv device nodes Judith Mendez
2025-01-27 22:16 ` [PATCH 1/4] arm64: dts: ti: k3-am62-wakeup: Add wakeup r5f node Judith Mendez
2025-01-28 16:22   ` Andrew Davis
2025-01-28 16:27     ` Judith Mendez
2025-01-27 22:16 ` [PATCH 2/4] arm64: dts: ti: k3-am62a-mcu: Add R5F remote proc node Judith Mendez
2025-01-28 16:27   ` Andrew Davis
2025-01-28 16:52     ` Hari Nagalla
2025-01-28 17:48       ` Judith Mendez
2025-01-30 22:40         ` Judith Mendez
2025-01-31 18:25           ` Andrew Davis
2025-01-27 22:16 ` [PATCH 3/4] arm64: dts: ti: k3-am62a-wakeup: Add R5F device node Judith Mendez
2025-01-27 22:16 ` [PATCH 4/4] arm64: dts: ti: k3-am62a-main: Add C7xv " Judith Mendez
2025-01-27 22:37 ` [PATCH 0/4] Add R5F and C7xv device nodes Rob Herring (Arm)

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).