From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: Bhavya Kapoor <b-kapoor@ti.com>, nm@ti.com, vigneshr@ti.com
Cc: kristo@kernel.org, p.yadav@ti.com, robh+dt@kernel.org,
krzysztof.kozlowski+dt@linaro.org,
linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [uL PATCH] arm64: dts: ti: k3-j721e-mcu-wakeup: Modified fss compatible to syscon and simple-mfd
Date: Mon, 30 May 2022 13:14:34 +0200 [thread overview]
Message-ID: <390f1bf0-5f8f-840c-ea77-9d24d93f8c22@linaro.org> (raw)
In-Reply-To: <20220530094230.53823-1-b-kapoor@ti.com>
On 30/05/2022 11:42, Bhavya Kapoor wrote:
> The FSS node also contains the Hyperflash controller. Support
> will be added in future. Change the compatible to syscon to
> accommodate that.
>
> Signed-off-by: Bhavya Kapoor <b-kapoor@ti.com>
> ---
> arch/arm64/boot/dts/ti/k3-j721e-mcu-wakeup.dtsi | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/arch/arm64/boot/dts/ti/k3-j721e-mcu-wakeup.dtsi b/arch/arm64/boot/dts/ti/k3-j721e-mcu-wakeup.dtsi
> index b4972dfb7da8..3c68094d835f 100644
> --- a/arch/arm64/boot/dts/ti/k3-j721e-mcu-wakeup.dtsi
> +++ b/arch/arm64/boot/dts/ti/k3-j721e-mcu-wakeup.dtsi
> @@ -169,8 +169,8 @@
> power-domains = <&k3_pds 197 TI_SCI_PD_SHARED>;
> };
>
> - fss: fss@47000000 {
> - compatible = "simple-bus";
> + fss: syscon@47000000 {
> + compatible = "syscon","simple-mfd";
1. Missing space after ,.
2. How does it work now? You expose syscon on this device node with
0x47000000 and the same time have a child device on same address range.
This looks racy and inconsistent.
3. This stops looking like simple-bus or simple-mfd:
https://lore.kernel.org/linux-devicetree/Ynq52E93mcTXcw9H@robh.at.kernel.org/
4. syscon and simple-mfd are not allowed on their own
https://lore.kernel.org/all/Ymf+OmNBaZ+7OrxD@robh.at.kernel.org/
Best regards,
Krzysztof
prev parent reply other threads:[~2022-05-30 11:14 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-05-30 9:42 [uL PATCH] arm64: dts: ti: k3-j721e-mcu-wakeup: Modified fss compatible to syscon and simple-mfd Bhavya Kapoor
2022-05-30 11:14 ` Krzysztof Kozlowski [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=390f1bf0-5f8f-840c-ea77-9d24d93f8c22@linaro.org \
--to=krzysztof.kozlowski@linaro.org \
--cc=b-kapoor@ti.com \
--cc=devicetree@vger.kernel.org \
--cc=kristo@kernel.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=nm@ti.com \
--cc=p.yadav@ti.com \
--cc=robh+dt@kernel.org \
--cc=vigneshr@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).