From: Srinivas Kandagatla <srinivas.kandagatla@linaro.org>
To: Rohit kumar <rohitkr@codeaurora.org>,
lgirdwood@gmail.com, broonie@kernel.org, robh+dt@kernel.org,
mark.rutland@arm.com, plai@codeaurora.org,
bgoswami@codeaurora.org, perex@perex.cz, tiwai@suse.com,
alsa-devel@alsa-project.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3 3/5] ASoC: qcom: add sdm845 sound card support
Date: Mon, 9 Jul 2018 10:06:13 +0100 [thread overview]
Message-ID: <39104e1f-d976-b51d-aa02-932c264070ba@linaro.org> (raw)
In-Reply-To: <1530870195-13576-4-git-send-email-rohitkr@codeaurora.org>
Minor Nits...
On 06/07/18 10:43, Rohit kumar wrote:
> +struct sdm845_snd_data {
> + struct snd_soc_card *card;
> + struct regulator *vdd_supply;
> + uint32_t pri_mi2s_clk_count;
> + uint32_t quat_tdm_clk_count;
> +};
> +
> +
Unnecessary extra line..
> +static unsigned int tdm_slot_offset[8] = {0, 4, 8, 12, 16, 20, 24, 28};
> +
>
> +static struct platform_driver sdm845_snd_driver = {
> + .probe = sdm845_snd_platform_probe,
> + .remove = sdm845_snd_platform_remove,
> + .driver = {
> + .name = "msm-snd-sdm845",
> + .pm = &sdm845_pm_ops,
> + .owner = THIS_MODULE,
setting owner is not required here!
> + .of_match_table = sdm845_snd_device_id,
> + },
> +};
next prev parent reply other threads:[~2018-07-09 9:06 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-07-06 9:43 [PATCH v3 0/5] Add support for audio on SDM845 SoC Rohit kumar
2018-07-06 9:43 ` [PATCH v3 1/5] ASoC: qcom: dt-bindings: Add sdm845 machine bindings Rohit kumar
2018-07-11 15:31 ` Rob Herring
2018-07-06 9:43 ` [PATCH v3 2/5] ASoC: qcom: Add support to parse common audio device nodes Rohit kumar
2018-07-06 17:51 ` Srinivas Kandagatla
2018-07-09 7:43 ` [alsa-devel] " Vinod
2018-07-06 9:43 ` [PATCH v3 3/5] ASoC: qcom: add sdm845 sound card support Rohit kumar
2018-07-09 7:48 ` [alsa-devel] " Vinod
2018-07-09 10:46 ` Rohit Kumar
2018-07-09 14:45 ` Vinod
2018-07-09 9:06 ` Srinivas Kandagatla [this message]
2018-07-09 11:14 ` Mark Brown
2018-07-09 12:01 ` Rohit Kumar
2018-07-09 12:03 ` [alsa-devel] " Mark Brown
2018-07-09 12:34 ` Srinivas Kandagatla
2018-07-09 12:41 ` Mark Brown
2018-07-09 12:47 ` Srinivas Kandagatla
2018-07-09 14:02 ` Srinivas Kandagatla
2018-07-09 16:33 ` Mark Brown
2018-07-10 10:59 ` Srinivas Kandagatla
2018-07-06 9:43 ` [PATCH v3 4/5] ASoC: dt-bindings: Update dt binding name for apq8096 Rohit kumar
2018-07-06 17:51 ` Srinivas Kandagatla
2018-07-11 15:31 ` Rob Herring
2018-07-06 9:43 ` [PATCH v3 5/5] ASoC: qcom: apq8096: Use common APIs to parse device nodes Rohit kumar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=39104e1f-d976-b51d-aa02-932c264070ba@linaro.org \
--to=srinivas.kandagatla@linaro.org \
--cc=alsa-devel@alsa-project.org \
--cc=bgoswami@codeaurora.org \
--cc=broonie@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=perex@perex.cz \
--cc=plai@codeaurora.org \
--cc=robh+dt@kernel.org \
--cc=rohitkr@codeaurora.org \
--cc=tiwai@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).