From: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>
To: Ajit Singh <blfizzyy@gmail.com>,
Bjorn Andersson <andersson@kernel.org>,
Bartosz Golaszewski <bartosz.golaszewski@oss.qualcomm.com>
Cc: Dmitry Baryshkov <dmitry.baryshkov@oss.qualcomm.com>,
Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v4 3/3] arm64: dts: qcom: Add Vicharak Axon Mini
Date: Wed, 10 Jun 2026 14:58:19 +0200 [thread overview]
Message-ID: <39228ace-9404-4ade-bcb1-28e763548b7f@oss.qualcomm.com> (raw)
In-Reply-To: <20260607113658.25117-4-blfizzyy@gmail.com>
On 6/7/26 1:36 PM, Ajit Singh wrote:
> Add DTS for the Vicharak Axon Mini board based on the Qualcomm
> QCS6490 SoC.
>
> This adds debug UART, eMMC, UFS, SDIO WLAN, USB 2.0 host, PCIe
> support along with regulators.
>
> The UFS ICE block is kept disabled because enabling it currently causes
> an SError during qcom_ice_create() on this board. UFS works without ICE.
>
> Signed-off-by: Ajit Singh <blfizzyy@gmail.com>
> ---
[...]
> + vreg_l12c_1p8: ldo12 {
> + regulator-name = "vreg_l12c_1p8";
> + regulator-min-microvolt = <1800000>;
> + regulator-max-microvolt = <2000000>;
> + regulator-initial-mode = <RPMH_REGULATOR_MODE_HPM>;
> +
> + /*
> + * VREG_L12C_1P8 supplies the Ampak WLAN/BT module
> + * VDDIO and the external 32.768 kHz oscillator.
> + */
Sorry for the long review timelines on the previous patch, many of us
were out for conferences..
Is the oscillator used for that WLAN module? Would you ideally like to
be able to turn it on/off?
Perhaps you could get that with a simple pwrseq driver (+Bartosz)
Konrad
next prev parent reply other threads:[~2026-06-10 12:58 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-06-07 11:36 [PATCH v4 0/3] arm64: dts: qcom: Add Vicharak Axon Mini Ajit Singh
2026-06-07 11:36 ` [PATCH v4 1/3] dt-bindings: vendor-prefixes: Add prefix for Vicharak Ajit Singh
2026-06-07 11:36 ` [PATCH v4 2/3] dt-bindings: arm: qcom: Add Vicharak Axon Mini Ajit Singh
2026-06-07 11:36 ` [PATCH v4 3/3] arm64: dts: " Ajit Singh
2026-06-07 18:56 ` Dmitry Baryshkov
2026-06-10 12:58 ` Konrad Dybcio [this message]
2026-06-10 13:01 ` Konrad Dybcio
2026-06-11 9:35 ` Ajit Singh
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=39228ace-9404-4ade-bcb1-28e763548b7f@oss.qualcomm.com \
--to=konrad.dybcio@oss.qualcomm.com \
--cc=andersson@kernel.org \
--cc=bartosz.golaszewski@oss.qualcomm.com \
--cc=blfizzyy@gmail.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=dmitry.baryshkov@oss.qualcomm.com \
--cc=krzk+dt@kernel.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox