Re: [PATCH v10] i2c: exynos5: add High Speed I2C controller driver

Naveen Krishna Ch
2013-08-16T04:58:23Z

On 15 August 2013 18:42, Wolfram Sang <wsa@the-dreams.de> wrote:
> On Mon, Jul 01, 2013 at 12:25:19PM +0200, Tomasz Figa wrote:
>> Hi Naveen,
>>
>> Looks mostly good, but see some comments inline.
>
> Ping?
Hello Wolfram,

I made a patch fixing your comments and from Thomas Figa as well.

Meanwhile, we hit a random crash in exynos5_i2c_irq function.
The "len" variable being is still being near the FIFO_MAX after this condition
len = HSI2C_FIFO_MAX - fifo_level;
+ if (len > i2c->msg->len)
+ len = i2c->msg->len;

Once, we fix this problem. i planned to rebase and submit.

Is it okey with you?

Thanks,
Naveen
>

--
Shine bright,
(: Nav :)