Re: [PATCH v4] i2c: exynos5: add High Speed I2C controller driver

Grant Likely
2013-02-08T13:16:08Z

On Fri, 01 Feb 2013 21:24:44 +0530, Naveen Krishna Chatradhi <ch.naveen@samsung.com> wrote:
> Adds support for High Speed I2C driver found in Exynos5 and later
> SoCs from Samsung. This driver currently supports Auto mode.
>
> Driver only supports Device Tree method.
> Note: Added debugfs support for registers view, not tested.
>
> Signed-off-by: Taekgyun Ko <taeggyun.ko@samsung.com>
> Signed-off-by: Naveen Krishna Chatradhi <ch.naveen@samsung.com>
> ---
> Help please,
>
> Usual reads and writes are happening. But, when i try doing
> i2cdetect -y 0 0x10 0x59; It throws me continous interrupts at 0x1a
> i2cdetect -y 0 0x50 0x64; It throws me continous interrupts at 0x63
>
> There are eeproms from 0x50 till 0x58
> wm8994 codec at 0x1a
>
> Kindly, can anyone explain this behaviour.
>
> drivers/i2c/busses/Kconfig | 7 +
> drivers/i2c/busses/Makefile | 1 +
> drivers/i2c/busses/i2c-exynos5.c | 754 ++++++++++++++++++++++++++++++++++++++

Don't forget you need to document the new compatible string in
Documentation/devicetree/bindings/i2c. That should be part of this
patch.

g.