From: Arnd Bergmann <arnd@arndb.de>
To: Lee Jones <lee.jones@linaro.org>
Cc: linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, kernel@stlinux.com,
jassisinghbrar@gmail.com, devicetree@vger.kernel.org
Subject: Re: [PATCH 3/3] mailbox: Add support for ST's Mailbox IP
Date: Tue, 03 Mar 2015 12:34:37 +0100 [thread overview]
Message-ID: <3926609.Ff6LCkuuMX@wuerfel> (raw)
In-Reply-To: <1425379283-1567-4-git-send-email-lee.jones@linaro.org>
On Tuesday 03 March 2015 10:41:23 Lee Jones wrote:
> +
> +/*
> + * struct sti_mbox_msg - sti mailbox message description
> + * @dsize: data payload size
> + * @pdata: message data payload
> + */
> +struct sti_mbox_msg {
> + u32 dsize;
> + u8 *pdata;
> +};
As mentioned in another thread, we may just want to add a 'size'
argument to the message send function, and a default helper for
messages with size of 32 bits.
I don't think it's good to fragment this further by adding
an indirect message interface in a particular driver.
Arnd
next prev parent reply other threads:[~2015-03-03 11:34 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-03-03 10:41 [PATCH 0/3] mailbox: New mailbox driver for ST Lee Jones
2015-03-03 10:41 ` [PATCH 1/3] ARM: STi: stih407-family: Add nodes for Mailbox Lee Jones
2015-03-03 10:41 ` [PATCH 2/3] mailbox: dt: Supply bindings for ST's Mailbox IP Lee Jones
2015-03-04 13:31 ` Jassi Brar
2015-03-03 10:41 ` [PATCH 3/3] mailbox: Add support " Lee Jones
2015-03-03 11:34 ` Arnd Bergmann [this message]
2015-03-03 15:18 ` Jassi Brar
[not found] ` <CAJe_ZhdjPa3C_TUDAPA3fS3K83FGB-GaAjVBjtsow2mp5h8NRw-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2015-03-18 13:17 ` Lee Jones
2015-03-18 13:53 ` Jassi Brar
2015-03-18 15:34 ` Lee Jones
2015-03-19 5:50 ` Jassi Brar
[not found] ` <CABb+yY0HufMEDy7ANj8KV0hamvM-Tgy4GBkwD73wm3DMumcbaQ-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2015-03-19 9:17 ` Lee Jones
2015-03-19 12:41 ` Jassi Brar
2015-03-23 15:06 ` Lee Jones
[not found] ` <1425379283-1567-4-git-send-email-lee.jones-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>
2015-03-04 13:27 ` Jassi Brar
2015-03-18 13:12 ` Lee Jones
2015-03-18 13:32 ` Jassi Brar
2015-03-18 15:26 ` Lee Jones
2015-03-19 5:13 ` Jassi Brar
2015-03-19 9:57 ` Lee Jones
2015-03-19 12:43 ` Jassi Brar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3926609.Ff6LCkuuMX@wuerfel \
--to=arnd@arndb.de \
--cc=devicetree@vger.kernel.org \
--cc=jassisinghbrar@gmail.com \
--cc=kernel@stlinux.com \
--cc=lee.jones@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).