From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 88801C46467 for ; Wed, 18 Jan 2023 13:23:35 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231225AbjARNXe (ORCPT ); Wed, 18 Jan 2023 08:23:34 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:53738 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231367AbjARNXS (ORCPT ); Wed, 18 Jan 2023 08:23:18 -0500 Received: from mail-wm1-x32b.google.com (mail-wm1-x32b.google.com [IPv6:2a00:1450:4864:20::32b]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 2766E9517E for ; Wed, 18 Jan 2023 04:47:43 -0800 (PST) Received: by mail-wm1-x32b.google.com with SMTP id fl11-20020a05600c0b8b00b003daf72fc844so1358901wmb.0 for ; Wed, 18 Jan 2023 04:47:42 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=gK8o2Y7reHAMOMVQV1NSBRgNT3cGc7DMsQikEldiSbI=; b=jtbzq6oRKAc24SZ+A3rDy+tQplPXJxB3XqhjdRocPvAQVmH7d4Y5IqNPLvywIBa4qn 9vGbE/jjtt8BzzUgKJfYNTwp/i5CG/zYnWXe4bLRLuVA+syACJg/i9ojwv/pB7jefG97 zO+PqHcKWrUKcnaSzlu6OpI9ZSCyMmB6OTDMiW0AsNm5ipqHzI3xYObWBMt9IfD4Dnty jJJop/zZyG+OA82/cMAu50KKtHYUBDtTxt67NIImVfM1HffdIFT+eDzflIiqoOola5l7 GvV/kGv41OathEVFB6UxTjVGOLvnlf6K0LWG9HlAWz5gdq9zwYKXZUrHoHob6M/TqQkE AVsA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=gK8o2Y7reHAMOMVQV1NSBRgNT3cGc7DMsQikEldiSbI=; b=ytlr4GbwHvZp2HHJUf0gTpEYyCESBqbFMkvD+qEducFbaB+5/4kPTYYI+cn+7z0wMh tpNrjQsGErfsKP7rIyyqbmbSydUmG8u5K7D8TFX/fQ/0NWM266OTx08gqTfB2vqkePkg WQuMcGKgc0gnf5kusGoXUIg3UQRb81ryR96GCBCGpMMzANlzvxtZ4bNB/kKfxYfn0+kw EEbu8Mu+ICb9W+bNaPJFXDH0Dn9yvsAkmFJL2jfsF71OBC+DlG5mRKE+v2fsIY6NB4ij U7YnI0sjyhFa8lzuxIAynXw2d2iUFqdB73iVsk6PTPrLMwvJGtkPVkaIUvU/ETxLAR/q FuPg== X-Gm-Message-State: AFqh2ko3h6A5pvB1hcjkZvF0gQdhRGUPwYrDY2VJYBf4yVjhZfF5vpSG cHdYZRgVw+cDzVeUhdmmUthlQw== X-Google-Smtp-Source: AMrXdXuDAKEnalP/OhK8Zy5tavc5exXluG1UAm4pHSXwlJdzB7qa5JtQH+D7YJlwjtCHFr+bpPo96A== X-Received: by 2002:a05:600c:35d5:b0:3db:fc4:d018 with SMTP id r21-20020a05600c35d500b003db0fc4d018mr3028764wmq.40.1674046061596; Wed, 18 Jan 2023 04:47:41 -0800 (PST) Received: from [192.168.1.109] ([178.197.216.144]) by smtp.gmail.com with ESMTPSA id f17-20020a1c6a11000000b003d9fba3c7a4sm1782153wmc.16.2023.01.18.04.47.40 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 18 Jan 2023 04:47:41 -0800 (PST) Message-ID: <392acd9d-ab7e-a5d0-67cd-162f49d2e6b6@linaro.org> Date: Wed, 18 Jan 2023 13:47:39 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.7.0 Subject: Re: [RESEND v3 01/13] dt-binding: mediatek: add bindings for MediaTek mt8195 MDP3 components Content-Language: en-US To: =?UTF-8?B?TW91ZHkgSG8gKOS9leWul+WOnyk=?= , "matthias.bgg@gmail.com" , "mchehab@kernel.org" , "robh+dt@kernel.org" , "krzysztof.kozlowski+dt@linaro.org" Cc: "linux-arm-kernel@lists.infradead.org" , "linux-kernel@vger.kernel.org" , "linux-media@vger.kernel.org" , "linux-mediatek@lists.infradead.org" , "devicetree@vger.kernel.org" , Project_Global_Chrome_Upstream_Group References: <20230116032147.23607-1-moudy.ho@mediatek.com> <20230116032147.23607-2-moudy.ho@mediatek.com> From: Krzysztof Kozlowski In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On 18/01/2023 09:52, Moudy Ho (何宗原) wrote: > On Mon, 2023-01-16 at 09:10 +0100, Krzysztof Kozlowski wrote: >> On 16/01/2023 04:21, Moudy Ho wrote: > > (snip) > >>> + mediatek,gce-client-reg: >>> + description: >>> + The register of client driver can be configured by gce with >>> 4 arguments >>> + defined in this property, such as phandle of gce, subsys id, >>> + register offset and size. >>> + Each subsys id is mapping to a base address of display >>> function blocks >>> + register which is defined in the gce header >>> + include/dt-bindings/gce/-gce.h. >>> + $ref: /schemas/types.yaml#/definitions/phandle-array >>> + maxItems: 1 >> >> items with items syntax instead: >> >> > https://urldefense.com/v3/__https://elixir.bootlin.com/linux/v5.18-rc1/source/Documentation/devicetree/bindings/soc/samsung/exynos-usi.yaml*L42__;Iw!!CTRNKA9wMg0ARbw!lcferrFFP-mshDHNL-rwJLgNKDrXF9fXoljpqL30k5YKTNvCwuC3webzR32VnQQoPeFvSvAewNkeupcT4mjdE_roxWUo$  >> >> >>> + > > (snip) > >>> + >>> + mediatek,gce-client-reg: >>> + description: >>> + The register of client driver can be configured by gce with >>> 4 arguments >>> + defined in this property, such as phandle of gce, subsys id, >>> + register offset and size. >>> + Each subsys id is mapping to a base address of display >>> function blocks >>> + register which is defined in the gce header >>> + include/dt-bindings/gce/-gce.h. >> >> Full, real path please, so it could be validated with tools. >> >> >> Best regards, >> Krzysztof >> > > Hi Krzysztof, > > Sorry to bug you again about this property, could it be changed to > following form. > > mediatek,gce-client-reg: > $ref: /schemas/types.yaml#/definitions/phandle-array > items: > items: > - description: phandle of GCE > - description: GCE subsys id > - description: register offset > - description: register size > description: > ... defined in . > maxItems: 1 > > Also, is the include header path still necessary in this form? No. Best regards, Krzysztof