From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 671AF3D47D8; Tue, 10 Mar 2026 17:38:56 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773164338; cv=none; b=rjCo+agA/XX+R5lXHqmLqgpFqjonfv4WUAHcKXSJBJ6oNDoCHavvwcH4iwEhRNPEX1nZkHN8Y+Q+ZSbfVKrh7GVmusQcjJ77Cydgzc7zN178sUx+FcitGmjyDaHJTfREHloIQPd4tB9k/gkk5dc6bCO6dUToEzd45n53lPHg82E= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773164338; c=relaxed/simple; bh=P5jdMY5TcQs1DhjRb0dewSY3xgk6AntRbMg/wL7POtw=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=l0hlyNgs6qEvxyUvAdavRhhgwJZ8Wj1aQUb+Iylpr/2aRn52QSiVvR0rblExPEuXSbofjQA+V6jVCdBkndGFi1NwM6dt4fjqs35ivRsbMthfqL7zP2cqTUaUndhyWFUPmOl8/T/43k2NiDI+aFYNIwNBpm5K9djiurlTVG/LOqQ= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=ZcN2S+gE; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="ZcN2S+gE" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 3AE46C19425; Tue, 10 Mar 2026 17:38:52 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1773164336; bh=P5jdMY5TcQs1DhjRb0dewSY3xgk6AntRbMg/wL7POtw=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=ZcN2S+gEidzV4BwPh+yfeVydoHqo6riTtspcuMasTedTDtxvTCwwwklmyZ+xxB7tt CEYFKbyFg7f0z7tDn3KxEBFXuVNDQ/63bdcwhUjtDOz91z3aeR/yQa/wDYtKcClIdS 7Gx/DnGyy7Dnvwo+Z5EasmgTXGxBPr5fB9UljRtS9j62J20PMv/dNV9Cg5Ya0Es0qG vlHFifRJoC5Z4u2Mvfb53Uw7PsW41cgly3RpOdUhwQiGS867jlyf++3DPhfVB+91wK EVEhAcFCCjwuJqx9fZVpdTB016CLhRYr896VB/t0XYagyW08N4lD+ejCcpCtFI/Ww/ CBpPRX+x6eeIw== Message-ID: <392ededd-ee73-4afa-88b4-b15fe1dc3457@kernel.org> Date: Tue, 10 Mar 2026 18:38:50 +0100 Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 3/5] dt-bindings: watchdog: renesas,rzn1-wdt: Document the reset line To: "Herve Codina (Schneider Electric)" , Wim Van Sebroeck , Guenter Roeck , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Geert Uytterhoeven , Michael Turquette , Stephen Boyd , Magnus Damm , Wolfram Sang Cc: linux-watchdog@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-renesas-soc@vger.kernel.org, linux-clk@vger.kernel.org, Pascal Eberhard , Miquel Raynal , Thomas Petazzoni References: <20260310173249.161354-1-herve.codina@bootlin.com> <20260310173249.161354-4-herve.codina@bootlin.com> From: Krzysztof Kozlowski Content-Language: en-US Autocrypt: addr=krzk@kernel.org; keydata= xsFNBFVDQq4BEAC6KeLOfFsAvFMBsrCrJ2bCalhPv5+KQF2PS2+iwZI8BpRZoV+Bd5kWvN79 cFgcqTTuNHjAvxtUG8pQgGTHAObYs6xeYJtjUH0ZX6ndJ33FJYf5V3yXqqjcZ30FgHzJCFUu JMp7PSyMPzpUXfU12yfcRYVEMQrmplNZssmYhiTeVicuOOypWugZKVLGNm0IweVCaZ/DJDIH gNbpvVwjcKYrx85m9cBVEBUGaQP6AT7qlVCkrf50v8bofSIyVa2xmubbAwwFA1oxoOusjPIE J3iadrwpFvsZjF5uHAKS+7wHLoW9hVzOnLbX6ajk5Hf8Pb1m+VH/E8bPBNNYKkfTtypTDUCj NYcd27tjnXfG+SDs/EXNUAIRefCyvaRG7oRYF3Ec+2RgQDRnmmjCjoQNbFrJvJkFHlPeHaeS BosGY+XWKydnmsfY7SSnjAzLUGAFhLd/XDVpb1Een2XucPpKvt9ORF+48gy12FA5GduRLhQU vK4tU7ojoem/G23PcowM1CwPurC8sAVsQb9KmwTGh7rVz3ks3w/zfGBy3+WmLg++C2Wct6nM Pd8/6CBVjEWqD06/RjI2AnjIq5fSEH/BIfXXfC68nMp9BZoy3So4ZsbOlBmtAPvMYX6U8VwD TNeBxJu5Ex0Izf1NV9CzC3nNaFUYOY8KfN01X5SExAoVTr09ewARAQABzSVLcnp5c3p0b2Yg S296bG93c2tpIDxrcnprQGtlcm5lbC5vcmc+wsGVBBMBCgA/AhsDBgsJCAcDAgYVCAIJCgsE FgIDAQIeAQIXgBYhBJvQfg4MUfjVlne3VBuTQ307QWKbBQJoF1BKBQkWlnSaAAoJEBuTQ307 QWKbHukP/3t4tRp/bvDnxJfmNdNVn0gv9ep3L39IntPalBFwRKytqeQkzAju0whYWg+R/rwp +r2I1Fzwt7+PTjsnMFlh1AZxGDmP5MFkzVsMnfX1lGiXhYSOMP97XL6R1QSXxaWOpGNCDaUl ajorB0lJDcC0q3xAdwzRConxYVhlgmTrRiD8oLlSCD5baEAt5Zw17UTNDnDGmZQKR0fqLpWy 786Lm5OScb7DjEgcA2PRm17st4UQ1kF0rQHokVaotxRM74PPDB8bCsunlghJl1DRK9s1aSuN hL1Pv9VD8b4dFNvCo7b4hfAANPU67W40AaaGZ3UAfmw+1MYyo4QuAZGKzaP2ukbdCD/DYnqi tJy88XqWtyb4UQWKNoQqGKzlYXdKsldYqrLHGoMvj1UN9XcRtXHST/IaLn72o7j7/h/Ac5EL 8lSUVIG4TYn59NyxxAXa07Wi6zjVL1U11fTnFmE29ALYQEXKBI3KUO1A3p4sQWzU7uRmbuxn naUmm8RbpMcOfa9JjlXCLmQ5IP7Rr5tYZUCkZz08LIfF8UMXwH7OOEX87Y++EkAB+pzKZNNd hwoXulTAgjSy+OiaLtuCys9VdXLZ3Zy314azaCU3BoWgaMV0eAW/+gprWMXQM1lrlzvwlD/k whyy9wGf0AEPpLssLVt9VVxNjo6BIkt6d1pMg6mHsUEVzsFNBFVDXDQBEADNkrQYSREUL4D3 Gws46JEoZ9HEQOKtkrwjrzlw/tCmqVzERRPvz2Xg8n7+HRCrgqnodIYoUh5WsU84N03KlLue MNsWLJBvBaubYN4JuJIdRr4dS4oyF1/fQAQPHh8Thpiz0SAZFx6iWKB7Qrz3OrGCjTPcW6ei OMheesVS5hxietSmlin+SilmIAPZHx7n242u6kdHOh+/SyLImKn/dh9RzatVpUKbv34eP1wA GldWsRxbf3WP9pFNObSzI/Bo3kA89Xx2rO2roC+Gq4LeHvo7ptzcLcrqaHUAcZ3CgFG88CnA 6z6lBZn0WyewEcPOPdcUB2Q7D/NiUY+HDiV99rAYPJztjeTrBSTnHeSBPb+qn5ZZGQwIdUW9 YegxWKvXXHTwB5eMzo/RB6vffwqcnHDoe0q7VgzRRZJwpi6aMIXLfeWZ5Wrwaw2zldFuO4Dt 91pFzBSOIpeMtfgb/Pfe/a1WJ/GgaIRIBE+NUqckM+3zJHGmVPqJP/h2Iwv6nw8U+7Yyl6gU BLHFTg2hYnLFJI4Xjg+AX1hHFVKmvl3VBHIsBv0oDcsQWXqY+NaFahT0lRPjYtrTa1v3tem/ JoFzZ4B0p27K+qQCF2R96hVvuEyjzBmdq2esyE6zIqftdo4MOJho8uctOiWbwNNq2U9pPWmu 4vXVFBYIGmpyNPYzRm0QPwARAQABwsF8BBgBCgAmAhsMFiEEm9B+DgxR+NWWd7dUG5NDfTtB YpsFAmgXUF8FCRaWWyoACgkQG5NDfTtBYptO0w//dlXJs5/42hAXKsk+PDg3wyEFb4NpyA1v qmx7SfAzk9Hf6lWwU1O6AbqNMbh6PjEwadKUk1m04S7EjdQLsj/MBSgoQtCT3MDmWUUtHZd5 RYIPnPq3WVB47GtuO6/u375tsxhtf7vt95QSYJwCB+ZUgo4T+FV4hquZ4AsRkbgavtIzQisg Dgv76tnEv3YHV8Jn9mi/Bu0FURF+5kpdMfgo1sq6RXNQ//TVf8yFgRtTUdXxW/qHjlYURrm2 H4kutobVEIxiyu6m05q3e9eZB/TaMMNVORx+1kM3j7f0rwtEYUFzY1ygQfpcMDPl7pRYoJjB dSsm0ZuzDaCwaxg2t8hqQJBzJCezTOIkjHUsWAK+tEbU4Z4SnNpCyM3fBqsgYdJxjyC/tWVT AQ18NRLtPw7tK1rdcwCl0GFQHwSwk5pDpz1NH40e6lU+NcXSeiqkDDRkHlftKPV/dV+lQXiu jWt87ecuHlpL3uuQ0ZZNWqHgZoQLXoqC2ZV5KrtKWb/jyiFX/sxSrodALf0zf+tfHv0FZWT2 zHjUqd0t4njD/UOsuIMOQn4Ig0SdivYPfZukb5cdasKJukG1NOpbW7yRNivaCnfZz6dTawXw XRIV/KDsHQiyVxKvN73bThKhONkcX2LWuD928tAR6XMM2G5ovxLe09vuOzzfTWQDsm++9UKF a/A= In-Reply-To: <20260310173249.161354-4-herve.codina@bootlin.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 10/03/2026 18:32, Herve Codina (Schneider Electric) wrote: > Watchdogs available in the RZ/N1 SoC can use their specific hardware > reset line to reset the system on watchdog timeout. > > This line is not documented in the current binding. > > Fill this lack and describe this per watchdog reset line. > > Signed-off-by: Herve Codina (Schneider Electric) > --- > .../bindings/watchdog/renesas,rzn1-wdt.yaml | 22 +++++++++++++++++++ > .../dt-bindings/watchdog/renesas,rzn1-wdt.h | 16 ++++++++++++++ > 2 files changed, 38 insertions(+) > create mode 100644 include/dt-bindings/watchdog/renesas,rzn1-wdt.h > > diff --git a/Documentation/devicetree/bindings/watchdog/renesas,rzn1-wdt.yaml b/Documentation/devicetree/bindings/watchdog/renesas,rzn1-wdt.yaml > index 7e3ee533cd56..40a9a4ebc716 100644 > --- a/Documentation/devicetree/bindings/watchdog/renesas,rzn1-wdt.yaml > +++ b/Documentation/devicetree/bindings/watchdog/renesas,rzn1-wdt.yaml > @@ -26,6 +26,26 @@ properties: > > timeout-sec: true > > + renesas,reset-line: > + $ref: /schemas/types.yaml#/definitions/uint32 > + enum: [0, 1] > + description: | > + The watchdog reset line (dt-bindings/watchdog/renesas,rzn1-wdt.h defines > + these values). A wachdog timeout asserts this reset line to perform a > + hardware system reset. Two watchdogs are present in the RZ/N1 SoC and > + each of them has a dedicated reset line. > + > + - 0: RZN1_WDT_A7_0 > + This reset line can be asserted only by the A7 0 watchdog. This > + watchdog is the one mapped at 0x40008000 on RZ/N1 SoCs. > + > + - 1: RZN1_WDT_A7_1 > + This reset line can be asserted only by the A7 1 watchdog. This > + watchdog is the one mapped at 0x40009000 on RZ/N1 SoCs. > + > + If the renesas,reset-line property is not present, the watchdog timeout > + only triggers an interrupt. I don't understand. You have two watchdogs (0x40008000 and 0x40009000) so why you would tell each of them that they can reset line associated with them? Can a watchdog reset other watchdog's line? No, thus code like: watchdog@40008000 { renesas,reset-line = ; }; makes no sense and thus is pointless to specify in DT. What's more, if reset line is always wired (and how could it be since it is fully within the soc), why would this be board-level property? > + > required: > - compatible > - reg > @@ -41,10 +61,12 @@ examples: > - | > #include > #include > + #include > > watchdog@40008000 { > compatible = "renesas,r9a06g032-wdt", "renesas,rzn1-wdt"; > reg = <0x40008000 0x1000>; > interrupts = ; > clocks = <&sysctrl R9A06G032_CLK_WATCHDOG>; > + renesas,reset-line = ; > }; > diff --git a/include/dt-bindings/watchdog/renesas,rzn1-wdt.h b/include/dt-bindings/watchdog/renesas,rzn1-wdt.h > new file mode 100644 > index 000000000000..fe534aff0609 > --- /dev/null > +++ b/include/dt-bindings/watchdog/renesas,rzn1-wdt.h > @@ -0,0 +1,16 @@ > +/* SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) */ > +/* > + * RZ/N1 watchdog reset lines > + * > + * Copyright (C) 2026 Bootlin > + * > + * Herve Codina > + */ > + > +#ifndef __DT_BINDINGS_RZN1_WDT_H__ > +#define __DT_BINDINGS_RZN1_WDT_H__ > + > +#define RZN1_WDT_A7_0 0 > +#define RZN1_WDT_A7_1 1 I also see little value of the binding, but probably because I don't understand the point of this patch. Best regards, Krzysztof