From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id F148C364057 for ; Mon, 16 Mar 2026 23:02:36 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773702159; cv=none; b=oBXm38Mmihb2upwR5ludNgVPrq+jByinwvlCSjmMi3ejiGVYOROVjEzFsxMmI7QLDXfSrSPlw9awxDGAkqsNrcHHM2U4El8XP0hXvwEXIcq4NFQcErHGUrR2WVm1oJXw+BsziTvVfoAp7Z1xKz9hQqMb32ik0NMUCtllKEkoUgk= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773702159; c=relaxed/simple; bh=mfzcGstDrFyFY2Sl2/fGkhRvhr57tmO4LPQdDoY0lXY=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=HDj0ay8ZM4RkaMijJdBc0OBxr04ZMrn2khzHy7wJy6HwhLCpBOnRmSG4aJiLJrihQTe7BWhvoRoujf2/1DnN3J07Wp40vhkDBjrRkVMvT9BFas0tCrpgngAj4mPbaa9sM0Nd7ekuaUHDUL3WFV4stmzdCujnAJXMwUKU/9aBzjo= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=M9KT9F9e; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=MqvaL92/; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="M9KT9F9e"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="MqvaL92/" Received: from pps.filterd (m0279871.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 62GL1dig1622349 for ; Mon, 16 Mar 2026 23:02:36 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= mlchTDxr3z3qRdgb94yGA2QNfyjLI6qsy4bLeJPkpzo=; b=M9KT9F9ewLJ/9dch etaL+nfEl6Ie44a0dNC5UrgWkq/vzzUcnI2g7lXs6rShD5R8IQMxzZIfgk8RY0DT IPjTjn8inkoF61vGENpB/n08ate0ITMtWwRGjjsUS/0qKseDdwum2Cg8BYLjGM/F Nq6y2sJoXlA1OwPyS1HbRgUmhl8SOUSVtJSAzMjCGjdBRJmax5gnLMMtC2XYytuM 7zc+F6Tby7aAbkJ6vPNWLYM59K4rvn69Q31Fxcxa+fYKyaqLoOSsOPb4rDDTG73V zZVM3UBFpN8WgSxgNn5x9QhdoxcV3wMfgLSk+RfM/vGGCMe+TDKykn47Yq7tgSMP gIH4jA== Received: from mail-dy1-f197.google.com (mail-dy1-f197.google.com [74.125.82.197]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4cxhyej2hm-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Mon, 16 Mar 2026 23:02:35 +0000 (GMT) Received: by mail-dy1-f197.google.com with SMTP id 5a478bee46e88-2ba8013a9e3so4216065eec.0 for ; Mon, 16 Mar 2026 16:02:35 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1773702155; x=1774306955; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=mlchTDxr3z3qRdgb94yGA2QNfyjLI6qsy4bLeJPkpzo=; b=MqvaL92/EhWQiuQUo4VMDUYa9jHMJrtemrtwcFjpAGHq+ZUZcPdSKWtCaGmwjLoDZb KFh2X04MxlFd2X3QGlRS/yBzbfmg7XWabkNtzvRBQRXLE7/8Pm5OXwIe9baLsPzoWTJW 879HyfphWEwwEyN0QP8XtMp4DSEWnPn2z+vb5psoHg7u3SxRyiEwCU5z+dgcANy61rrn ZAmKY8DZmSdFGjq2dfjHfv0U0k6aKz79R81qOgY204gpbdIgCoLpz3Cp2jy1o9bLwo5Z /dFA9iyRUy3TtofyMxvJGTnDzV+/ug9dQFd/lY4eRwPrSPw14JtBvWpdDq51oeCvoHs5 xhvg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1773702155; x=1774306955; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=mlchTDxr3z3qRdgb94yGA2QNfyjLI6qsy4bLeJPkpzo=; b=G/mR5/G3D546xQas4JVkMJoXsF+mfkhESfeLIqYDwxcMgpHwvEEsrRYYAgNtY+pD/0 j2nj8H5TT3mftLKA5MjFJkv49+2eC9KSpTveu0bo77QQlPUFzEF5QbqkPiyYU3cULhDZ 7lDo9aqrXoKr8flBYXimYz4bX7OFkPKpB4gLRCdBn+81rgzS7fA5n/U0x+yH6WiMMIqb w19QbCdwSuS5YL98pa9sdr+mSCwfUhVuQFcYUAQy4GCOvOUyqC8G/Wi+MgxgccDw2cU4 yHRp1wtFihmfAepM0j3y9lC0WXDmMPTlYdXF245FJllnff4+1T+ccdFm5AXwINAf9uD1 gG9g== X-Forwarded-Encrypted: i=1; AJvYcCXYupEXSTzj7UxkRLU8NES6GD3MG8c9p7qeVkfNKs4dKB/rWl3UTi6ZdfODQGgMfuxTeAZiH5JxLg2C@vger.kernel.org X-Gm-Message-State: AOJu0YxybdOtcTD+uGi7J7iKldw/Dugmrc/ryYBRS1y9iNotTdXFj6Wi 4ltw2/uiYIuO2R3L9jtQWg227UVawWuXuApNBHMCyybEydmb7XhFKPsF5ViXA6lfrSCPgzKT3GM dWMsvImwtHzMatzCVWIDmlYh/AjcJF5OYZzFyquoRreB6IZRUfYzTk7BcanJPQDqL X-Gm-Gg: ATEYQzxobTTJKZgsw84V0ab8+4tpY7SOMelGz7kRhsDuO3UCm9AIElvnNSEe8SRVbZx fJfHq8eEikbe8+2oW07mTvTeEOJIRYL64vcWhqYU23TysoLdHckSTaSUp811/0cEwIBjobXjERp xL/k3VADp64HWBrBbNkzGwFgS6fZeFu2S2YIU7Ti+TP3s5CX7Kg+VaVF09WOqs9LJBWIEx39snF XPuyPwqszn1l9Rx7EH7jc3BaJFbramxkirdi8G0aZsYP5y02l1BPCVOFAccfOW2LpK+vr7PhjSr m4V7lXPigF2U41MOwGBYi0CSg1BN2Gmvg82tes38hwCcgX3oYcIoQkNjv627i6ZYLLj3T0E0gEB SLThVxy8YOqxIYI//1XTjIZEs0jvflCRFH50oX5kSDNhc55ri6t9OnmsT0HfNnfEJma7yq8L4/t tHQXtM X-Received: by 2002:a05:7300:6ca0:b0:2be:1779:3289 with SMTP id 5a478bee46e88-2bea573d146mr6203989eec.35.1773702154738; Mon, 16 Mar 2026 16:02:34 -0700 (PDT) X-Received: by 2002:a05:7300:6ca0:b0:2be:1779:3289 with SMTP id 5a478bee46e88-2bea573d146mr6203932eec.35.1773702153972; Mon, 16 Mar 2026 16:02:33 -0700 (PDT) Received: from [10.134.65.116] (i-global254.qualcomm.com. [199.106.103.254]) by smtp.gmail.com with ESMTPSA id 5a478bee46e88-2c0bbe04304sm9795623eec.23.2026.03.16.16.02.32 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 16 Mar 2026 16:02:33 -0700 (PDT) Message-ID: <3934e17f-a2fa-423f-898b-a0d89e69f564@oss.qualcomm.com> Date: Mon, 16 Mar 2026 16:02:31 -0700 Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 02/15] firmware: qcom: Add a generic PAS service To: Krzysztof Kozlowski , Sumit Garg , linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, dri-devel@lists.freedesktop.org, freedreno@lists.freedesktop.org, linux-media@vger.kernel.org, netdev@vger.kernel.org, linux-wireless@vger.kernel.org, ath12k@lists.infradead.org, linux-remoteproc@vger.kernel.org Cc: andersson@kernel.org, konradybcio@kernel.org, robh@kernel.org, krzk+dt@kernel.org, conor+dt@kernel.org, robin.clark@oss.qualcomm.com, sean@poorly.run, akhilpo@oss.qualcomm.com, lumag@kernel.org, abhinav.kumar@linux.dev, jesszhan0024@gmail.com, marijn.suijten@somainline.org, airlied@gmail.com, simona@ffwll.ch, vikash.garodia@oss.qualcomm.com, dikshita.agarwal@oss.qualcomm.com, bod@kernel.org, mchehab@kernel.org, elder@kernel.org, andrew+netdev@lunn.ch, davem@davemloft.net, edumazet@google.com, kuba@kernel.org, pabeni@redhat.com, jjohnson@kernel.org, mathieu.poirier@linaro.org, mukesh.ojha@oss.qualcomm.com, pavan.kondeti@oss.qualcomm.com, jorge.ramirez@oss.qualcomm.com, tonyh@qti.qualcomm.com, vignesh.viswanathan@oss.qualcomm.com, srinivas.kandagatla@oss.qualcomm.com, amirreza.zarrabi@oss.qualcomm.com, jens.wiklander@linaro.org, op-tee@lists.trustedfirmware.org, apurupa@qti.qualcomm.com, skare@qti.qualcomm.com, linux-kernel@vger.kernel.org, Sumit Garg References: <20260312062756.694390-1-sumit.garg@kernel.org> <20260312062756.694390-3-sumit.garg@kernel.org> <28d63822-f191-400a-8005-5185dd480dbb@kernel.org> Content-Language: en-US From: Trilok Soni In-Reply-To: <28d63822-f191-400a-8005-5185dd480dbb@kernel.org> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Proofpoint-GUID: s0YoVTdfjNk14k82aurZreThWXlSXTeq X-Proofpoint-ORIG-GUID: s0YoVTdfjNk14k82aurZreThWXlSXTeq X-Authority-Analysis: v=2.4 cv=KLxXzVFo c=1 sm=1 tr=0 ts=69b88c0b cx=c_pps a=Uww141gWH0fZj/3QKPojxA==:117 a=JYp8KDb2vCoCEuGobkYCKw==:17 a=IkcTkHD0fZMA:10 a=Yq5XynenixoA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=3WHJM1ZQz_JShphwDgj5:22 a=EUspDBNiAAAA:8 a=_eXaltnX1kRmSEBu75cA:9 a=QEXdDO2ut3YA:10 a=PxkB5W3o20Ba91AHUih5:22 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwMzE2MDE5MSBTYWx0ZWRfXwb8SA1dpKH23 z8CCzQvQ2fm3hE1feNqz0qtccXeNONHpYeUd38+hX8K1KhrTvLRBZ7QjYN2ZSVlz+rraIWx8+1C WVpYbnV6K5lLTRhrjtoRkTXnfJWVvuN6LRTXX/SRIiR2BpkkJcGJ0iRfnr/zgfofqVUdnBZ0Doh OiO8TNWHuIZ7dV7ewEQ1roJg/snneTKnv9GcIijy5LBSXqYL4WanB0FOdM7fj0F24h9vjh0276K 4EOBfI267G2KoujkXdzCxHze6kC8xOIjXjsFXUup7eXboGTeTGgp4t4DK2WGYmBfI5oesLVUSfE KhjUYryJ8XshrSu4/QR4O0P++n7KnCSq/HYvMcHle66GotYQILYUvZIJ6uYND8Vg/WXWQkJs+8B HjyqKFPxt3dBG986POlZK5GQkd1/sFS7QSg7CxXYjaqo6B6SWwqr29iVGJDRjDZlfuLB9YInFJz YsqVjO6VY2U5jCbkIDA== X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-03-16_06,2026-03-16_06,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 malwarescore=0 phishscore=0 priorityscore=1501 lowpriorityscore=0 suspectscore=0 spamscore=0 clxscore=1015 bulkscore=0 impostorscore=0 adultscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2603050001 definitions=main-2603160191 On 3/16/2026 12:51 AM, Krzysztof Kozlowski wrote: > On 12/03/2026 07:27, Sumit Garg wrote: >> From: Sumit Garg >> >> Qcom platforms has the legacy of using non-standard SCM calls >> splintered over the various kernel drivers. These SCM calls aren't >> compliant with the standard SMC calling conventions which is a >> prerequisite to enable migration to the FF-A specifications from Arm. >> >> OP-TEE as an alternative trusted OS to Qualcomm TEE (QTEE) can't >> support these non-standard SCM calls. And even for newer architectures >> with S-EL2 and Hafnium support, QTEE won't be able to support SCM >> calls either with FF-A requirements coming in. And with both OP-TEE >> and QTEE drivers well integrated in the TEE subsystem, it makes further >> sense to reuse the TEE bus client drivers infrastructure. >> >> The added benefit of TEE bus infrastructure is that there is support >> for discoverable/enumerable services. With that client drivers don't >> have to manually invoke a special SCM call to know the service status. >> >> So enable the generic Peripheral Authentication Service (PAS) provided >> by the firmware. It acts as the common layer with different TZ >> backends plugged in whether it's an SCM implementation or a proper >> TEE bus based PAS service implementation. >> >> Signed-off-by: Sumit Garg >> --- >> drivers/firmware/qcom/Kconfig | 8 + >> drivers/firmware/qcom/Makefile | 1 + >> drivers/firmware/qcom/qcom_pas.c | 298 +++++++++++++++++++++++++ >> drivers/firmware/qcom/qcom_pas.h | 53 +++++ >> include/linux/firmware/qcom/qcom_pas.h | 41 ++++ >> 5 files changed, 401 insertions(+) >> create mode 100644 drivers/firmware/qcom/qcom_pas.c >> create mode 100644 drivers/firmware/qcom/qcom_pas.h >> create mode 100644 include/linux/firmware/qcom/qcom_pas.h >> >> diff --git a/drivers/firmware/qcom/Kconfig b/drivers/firmware/qcom/Kconfig >> index b477d54b495a..8653639d06db 100644 >> --- a/drivers/firmware/qcom/Kconfig >> +++ b/drivers/firmware/qcom/Kconfig >> @@ -6,6 +6,14 @@ >> >> menu "Qualcomm firmware drivers" >> >> +config QCOM_PAS >> + tristate >> + help >> + Enable the generic Peripheral Authentication Service (PAS) provided >> + by the firmware. It acts as the common layer with different TZ >> + backends plugged in whether it's an SCM implementation or a proper >> + TEE bus based PAS service implementation. >> + >> config QCOM_SCM >> select QCOM_TZMEM >> tristate >> diff --git a/drivers/firmware/qcom/Makefile b/drivers/firmware/qcom/Makefile >> index 0be40a1abc13..dc5ab45f906a 100644 >> --- a/drivers/firmware/qcom/Makefile >> +++ b/drivers/firmware/qcom/Makefile >> @@ -8,3 +8,4 @@ qcom-scm-objs += qcom_scm.o qcom_scm-smc.o qcom_scm-legacy.o >> obj-$(CONFIG_QCOM_TZMEM) += qcom_tzmem.o >> obj-$(CONFIG_QCOM_QSEECOM) += qcom_qseecom.o >> obj-$(CONFIG_QCOM_QSEECOM_UEFISECAPP) += qcom_qseecom_uefisecapp.o >> +obj-$(CONFIG_QCOM_PAS) += qcom_pas.o >> diff --git a/drivers/firmware/qcom/qcom_pas.c b/drivers/firmware/qcom/qcom_pas.c >> new file mode 100644 >> index 000000000000..beb1bae55546 >> --- /dev/null >> +++ b/drivers/firmware/qcom/qcom_pas.c >> @@ -0,0 +1,298 @@ >> +// SPDX-License-Identifier: GPL-2.0 >> +/* >> + * Copyright (c) Qualcomm Technologies, Inc. and/or its subsidiaries. >> + */ >> + >> +#include >> +#include >> +#include >> +#include >> + >> +#include "qcom_pas.h" >> + >> +struct qcom_pas_ops *ops_ptr; > > Same comment as before. Don't create singletons. And for sure not global > ones. I agree, no globals here please. > > Best regards, > Krzysztof