From: Michael Walle <michael@walle.cc>
To: Shawn Guo <shawnguo@kernel.org>, Li Yang <leoyang.li@nxp.com>,
Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Vladimir Oltean <vladimir.oltean@nxp.com>
Cc: linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org,
Heiko Thiery <heiko.thiery@gmail.com>
Subject: Re: [PATCH] Revert "arm64: dts: ls1028a: sl28: use ocelot-8021q tagging by default"
Date: Thu, 27 Oct 2022 18:14:02 +0200 [thread overview]
Message-ID: <3938a228c0c136f568b7b0a7d92ff15c@walle.cc> (raw)
In-Reply-To: <20221027113248.420216-1-michael@walle.cc>
Am 2022-10-27 13:32, schrieb Michael Walle:
> This reverts commit be0b178c50c37a666d54f435da71cf9f008362a0.
>
> This commit will break networking on the sl28 boards if the tagger is
> not compiled into the kernel. If a non-default tagger is used, the
> kernel doesn't do a request_module(). Fixing that is also not that
> trivial because the tagger modules are loaded by ids, not by name.
> Thus for now, just revert to the default tagger until that is fixed.
>
> Fixes: be0b178c50c3 ("arm64: dts: ls1028a: sl28: use ocelot-8021q
> tagging by default")
> Reported-by: Heiko Thiery <heiko.thiery@gmail.com>
> Signed-off-by: Michael Walle <michael@walle.cc>
Please disregard this patch. The proper fix is here:
https://lore.kernel.org/netdev/20221027145439.3086017-1-vladimir.oltean@nxp.com/
-michael
prev parent reply other threads:[~2022-10-27 16:14 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-10-27 11:32 [PATCH] Revert "arm64: dts: ls1028a: sl28: use ocelot-8021q tagging by default" Michael Walle
2022-10-27 12:05 ` Vladimir Oltean
2022-10-27 12:27 ` Vladimir Oltean
2022-10-27 12:40 ` Vladimir Oltean
2022-10-27 13:00 ` Michael Walle
2022-10-27 13:54 ` Vladimir Oltean
2022-10-27 16:00 ` Michael Walle
2022-10-27 18:04 ` Vladimir Oltean
2022-10-27 19:10 ` Michael Walle
2022-10-27 20:36 ` Vladimir Oltean
2022-10-27 16:14 ` Michael Walle [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3938a228c0c136f568b7b0a7d92ff15c@walle.cc \
--to=michael@walle.cc \
--cc=devicetree@vger.kernel.org \
--cc=heiko.thiery@gmail.com \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=leoyang.li@nxp.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=robh+dt@kernel.org \
--cc=shawnguo@kernel.org \
--cc=vladimir.oltean@nxp.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).