From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3F3FFC04A94 for ; Wed, 9 Aug 2023 18:15:02 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229459AbjHISPB (ORCPT ); Wed, 9 Aug 2023 14:15:01 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:59692 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230077AbjHISPA (ORCPT ); Wed, 9 Aug 2023 14:15:00 -0400 Received: from mail-ej1-x62e.google.com (mail-ej1-x62e.google.com [IPv6:2a00:1450:4864:20::62e]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 0C4341FC2 for ; Wed, 9 Aug 2023 11:14:59 -0700 (PDT) Received: by mail-ej1-x62e.google.com with SMTP id a640c23a62f3a-99bdf08860dso260145266b.0 for ; Wed, 09 Aug 2023 11:14:58 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1691604897; x=1692209697; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=o5aCxWlinyQcJkM+9Oa2MsH3kjFRE6iVNspKQ8+nH/g=; b=a0RkVZkjTomjJ1Zu4ERiqOKbNgEiYnJQLecWpiPTYExFLhhTnL0OKviRiQpYQZMgx0 1VwXmsPW6LI7ufOqAI5aE2RyOArlYbljBShZX0sK5syNkk12iEm+3RaEotyNw2/uKWP/ axl/4MBtCDPbCaEF6x4J5msxapMzTEO/rc6EGIJZNYLRFWXV6Ot10FOQcD5IxeaT+Ma0 lTHFLj1MdY/Qs1Tx2pZanA03hLSTmpoIm0YVdAqgmWSJd/YwiNYtCCJCvsPu5AZFCPBW K6I6fP25NAVGz8N0wBPcomM3SR3CUY7kwkj8vgwyz7ui9UEZ7Egm1o2UcpnzR/fRIS5p HIzQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1691604897; x=1692209697; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=o5aCxWlinyQcJkM+9Oa2MsH3kjFRE6iVNspKQ8+nH/g=; b=G/Y9BQBlyobwXNlqjcWg5UmRVY8X+HVwK3LowQQ8SF3e4hh4K4zbJMdLOcGpOh5m4Y dH03hS7Km7B0xiGqskX4FIMV5mTjDPxnKisLSS6P4gfiIc8rpGhPPcQXaYDL8Q/uMHmj bDs2bRzeP8W3XYhHLxgv6HVMDmMAFteRk1S7AW67kBmru+kES5ZFsnr4aCYaulCIyNCq eCkM8fYsuscrUjy3hbxwwAjuBxYV8zdRoRMRpkW+c2EJUfeIpFPv08hVw7x2MvJgsZRb RhENx2CY4+N0taWMWhTJr7rm4q55rEc/SK6suPB13BORjI4kEJEYhE36NhE4X5ymH38L Z/tQ== X-Gm-Message-State: AOJu0Yz1ame/FSYSYK/3AM5FnfoaADB0FbujvHqL2Hi68/luWrQ1IugQ WhT8c+PGIaF+0valv5o8JI6HbA== X-Google-Smtp-Source: AGHT+IHsxlXjaIw6U/rG9TFR0w5BMU/zulMhVwKH0f2tyNmMTtv3K/zB0R5LrsUba6Js2JJDxSJGSQ== X-Received: by 2002:a17:906:31ca:b0:99b:4d3d:c9b7 with SMTP id f10-20020a17090631ca00b0099b4d3dc9b7mr184259ejf.31.1691604897370; Wed, 09 Aug 2023 11:14:57 -0700 (PDT) Received: from [192.168.1.20] ([178.197.222.113]) by smtp.gmail.com with ESMTPSA id v8-20020a170906180800b009934855d8f1sm8359001eje.34.2023.08.09.11.14.55 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 09 Aug 2023 11:14:56 -0700 (PDT) Message-ID: <3939bd56-d57d-173e-da78-297ce607f9bc@linaro.org> Date: Wed, 9 Aug 2023 20:14:54 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.14.0 Subject: Re: [PATCH v4 4/4] iio: adc: mcp3911: add support for the whole MCP39xx family Content-Language: en-US To: Jonathan Cameron , Marcus Folkesson Cc: Andy Shevchenko , Kent Gustavsson , Lars-Peter Clausen , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Cosmin Tanislav , Arnd Bergmann , ChiYuan Huang , Haibo Chen , Ramona Bolboaca , Ibrahim Tilki , ChiaEn Wu , William Breathitt Gray , linux-iio@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org References: <20230808110432.240773-1-marcus.folkesson@gmail.com> <20230808110432.240773-4-marcus.folkesson@gmail.com> <20230809190257.67602e55@jic23-huawei> From: Krzysztof Kozlowski In-Reply-To: <20230809190257.67602e55@jic23-huawei> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On 09/08/2023 20:02, Jonathan Cameron wrote: > On Wed, 9 Aug 2023 08:41:05 +0200 > Marcus Folkesson wrote: > >>> ... >>> >>>> +#define MCP3910_OFFCAL(x) (MCP3910_REG_OFFCAL_CH0 + x * 6) >>> >>> Inconsistent macro implementation, i.e. you need to use (x). >> >> Sorry, I do not get you >> >> >> [...] >> >>>> +static int mcp3910_get_osr(struct mcp3911 *adc, int *val) >>>> +{ >>>> + int ret, osr; >>> >>> Strictly speaking osr can't be negative, otherwise it's a UB below. >>> >>> u32 osr = FIELD_GET(MCP3910_CONFIG0_OSR, *val); >>> int ret; >>> >>> and why val is int? >> >> I will change val to u32 for *_get_osr(), *_set_osr() and *_set_scale(). >> >> [...] >> >>>> + if (device_property_read_bool(&adc->spi->dev, "microchip,data-ready-hiz")) >>> >>> This also becomes shorter. >>> >>> One trick to make it even shorter: >>> >>> if (device_property_present(dev, "microchip,data-ready-hiz")) >> >> Thank you, I wasn't aware of device_property_present(). > > I know the read_bool function is direct equivalent of this but where a property > is a flag, it feels more natural to me to check it with that one. > read_present() feels more appropriate for where you want to know a more > complex property is present. > > Doesn't matter that much either way however so up to you. For the OF, of_property_read_bool() is indeed preferred. Is there device-xxx() equivalent? Best regards, Krzysztof