public inbox for devicetree@vger.kernel.org
 help / color / mirror / Atom feed
From: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
To: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
Cc: Mark Rutland <mark.rutland@arm.com>,
	devicetree@vger.kernel.org, David Airlie <airlied@linux.ie>,
	dri-devel@lists.freedesktop.org,
	linux-renesas-soc@vger.kernel.org,
	Rob Herring <robh+dt@kernel.org>
Subject: Re: [PATCH] dt-bindings: display: renesas: du: document R8A77980 bindings
Date: Tue, 05 Jun 2018 13:09:53 +0300	[thread overview]
Message-ID: <3941727.PNGxG4XCLb@avalon> (raw)
In-Reply-To: <2a775652-604c-6379-b807-19979f164f84@cogentembedded.com>

Hi Sergei,

Thank you for the patch.

On Monday, 4 June 2018 22:04:59 EEST Sergei Shtylyov wrote:
> Document the R-Car V3H (R8A77980) SoC in the R-Car DU bindings; the DU
> hardware seems the same as in the R-Car V3M (R8A77970).

How about "the DU hardware has the same topology as in the R-Car V3M 
(R8A77970)" ? "seems" sounds like we're very unsure :-)

> Signed-off-by: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
> 
> ---
> The patch is against the 'drm-next' branch of David Airlie's 'linux.git'
> repo.

Then you might want to switch to git://anongit.freedesktop.org/drm/drm :-)

Apart from that,

Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>

If you agree with the small change to the commit message I'll fix the conflict 
locally, there's no need to resubmit.

>  Documentation/devicetree/bindings/display/renesas,du.txt |    2 ++
>  1 file changed, 2 insertions(+)
> 
> Index: linux/Documentation/devicetree/bindings/display/renesas,du.txt
> ===================================================================
> --- linux.orig/Documentation/devicetree/bindings/display/renesas,du.txt
> +++ linux/Documentation/devicetree/bindings/display/renesas,du.txt
> @@ -14,6 +14,7 @@ Required Properties:
>      - "renesas,du-r8a7795" for R8A7795 (R-Car H3) compatible DU
>      - "renesas,du-r8a7796" for R8A7796 (R-Car M3-W) compatible DU
>      - "renesas,du-r8a77970" for R8A77970 (R-Car V3M) compatible DU
> +    - "renesas,du-r8a77980" for R8A77980 (R-Car V3H) compatible DU
>      - "renesas,du-r8a77995" for R8A77995 (R-Car D3) compatible DU
> 
>    - reg: the memory-mapped I/O registers base address and length
> @@ -60,6 +61,7 @@ corresponding to each DU output.
>   R8A7795 (R-Car H3)   DPAD 0         HDMI 0         HDMI 1         LVDS 0
>   R8A7796 (R-Car M3-W) DPAD 0         HDMI 0         LVDS 0         -
>   R8A77970 (R-Car V3M) DPAD 0         LVDS 0         -              -
> + R8A77980 (R-Car V3H) DPAD 0         LVDS 0         -              -
>   R8A77995 (R-Car D3)  DPAD 0         LVDS 0         LVDS 1         -

-- 
Regards,

Laurent Pinchart



_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

  parent reply	other threads:[~2018-06-05 10:09 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-06-04 19:04 [PATCH] dt-bindings: display: renesas: du: document R8A77980 bindings Sergei Shtylyov
2018-06-05  8:09 ` Simon Horman
2018-06-05 10:09 ` Laurent Pinchart [this message]
2018-06-05 18:57   ` Sergei Shtylyov
2018-06-05 19:16     ` Laurent Pinchart
2018-06-05 19:49       ` Sergei Shtylyov
2018-06-05 20:24         ` Laurent Pinchart
2018-06-06  7:04           ` Geert Uytterhoeven
2018-06-12 21:02 ` Rob Herring

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=3941727.PNGxG4XCLb@avalon \
    --to=laurent.pinchart@ideasonboard.com \
    --cc=airlied@linux.ie \
    --cc=devicetree@vger.kernel.org \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=linux-renesas-soc@vger.kernel.org \
    --cc=mark.rutland@arm.com \
    --cc=robh+dt@kernel.org \
    --cc=sergei.shtylyov@cogentembedded.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox