From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 91835C32796 for ; Wed, 24 Aug 2022 17:44:29 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234166AbiHXRo3 (ORCPT ); Wed, 24 Aug 2022 13:44:29 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:49226 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229542AbiHXRo2 (ORCPT ); Wed, 24 Aug 2022 13:44:28 -0400 Received: from gloria.sntech.de (gloria.sntech.de [185.11.138.130]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id DF70E7FFA2; Wed, 24 Aug 2022 10:44:26 -0700 (PDT) Received: from ip5b412258.dynamic.kabel-deutschland.de ([91.65.34.88] helo=diego.localnet) by gloria.sntech.de with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1oQuQN-0004jX-Da; Wed, 24 Aug 2022 19:44:19 +0200 From: Heiko =?ISO-8859-1?Q?St=FCbner?= To: Thomas Gleixner , Marc Zyngier , Rob Herring , Krzysztof Kozlowski , Palmer Dabbelt , Paul Walmsley , Albert Ou , linux-riscv@lists.infradead.org Cc: Daniel Lezcano , Anup Patel , Conor Dooley , Guo Ren , Sagar Kadam , Jessica Clarke , Andrew Jones , linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, linux-riscv@lists.infradead.org, qemu-riscv@nongnu.org, Rob Herring , Conor Dooley Subject: Re: [PATCH v4 2/4] dt-bindings: interrupt-controller: sifive,plic: add legacy riscv compatible Date: Wed, 24 Aug 2022 19:44:18 +0200 Message-ID: <3948407.AJdgDx1Vlc@diego> In-Reply-To: <20220823183319.3314940-3-mail@conchuod.ie> References: <20220823183319.3314940-1-mail@conchuod.ie> <20220823183319.3314940-3-mail@conchuod.ie> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org Am Dienstag, 23. August 2022, 20:33:18 CEST schrieb Conor Dooley: > From: Conor Dooley > > While "real" hardware might not use the compatible string "riscv,plic0" > it is present in the driver & QEMU uses it for automatically generated > virt machine dtbs. To avoid dt-validate problems with QEMU produced > dtbs, such as the following, add it to the binding. > > riscv-virt.dtb: plic@c000000: compatible: 'oneOf' conditional failed, one must be fixed: > 'sifive,plic-1.0.0' is not one of ['sifive,fu540-c000-plic', 'starfive,jh7100-plic', 'canaan,k210-plic'] > 'sifive,plic-1.0.0' is not one of ['allwinner,sun20i-d1-plic'] > 'sifive,plic-1.0.0' was expected > 'thead,c900-plic' was expected > riscv-virt.dtb: plic@c000000: '#address-cells' is a required property > > Reported-by: Rob Herring > Link: https://lore.kernel.org/linux-riscv/20220803170552.GA2250266-robh@kernel.org/ > Reviewed-by: Rob Herring > Signed-off-by: Conor Dooley > --- > .../bindings/interrupt-controller/sifive,plic-1.0.0.yaml | 5 +++++ > 1 file changed, 5 insertions(+) > > diff --git a/Documentation/devicetree/bindings/interrupt-controller/sifive,plic-1.0.0.yaml b/Documentation/devicetree/bindings/interrupt-controller/sifive,plic-1.0.0.yaml > index 92e0f8c3eff2..99e01f4d0a69 100644 > --- a/Documentation/devicetree/bindings/interrupt-controller/sifive,plic-1.0.0.yaml > +++ b/Documentation/devicetree/bindings/interrupt-controller/sifive,plic-1.0.0.yaml > @@ -66,6 +66,11 @@ properties: > - enum: > - allwinner,sun20i-d1-plic > - const: thead,c900-plic > + - items: > + - const: sifive,plic-1.0.0 > + - const: riscv,plic0 > + deprecated: true hmm, when setting this to deprecated, does this mean qemu was changed to not use that compatible anymore? I.e. reading deprecated I'd assume that this is kept around for old qemu builds? Heiko > + description: For the QEMU virt machine only > > reg: > maxItems: 1 >