From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 29E4E3F12E1 for ; Fri, 9 Oct 2026 06:18:20 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1791526701; cv=none; b=fZB2+sxEr6rj+m/wXIoa6pfwb1CaQiL6dgLNUGPPyjc2v5w9uM0wvhGUPnOgpso+Uznz5Fk0OzWqGt/tf8/XqaWlCiUvZCSKKs5T5diUjp/enXOze/dtqa89CEhFdqxnB1+ax8OtrSftOkVkJOMIICzJ5ZpVj+4ny3qt/2GxktE= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1791526701; c=relaxed/simple; bh=rCY7+48PTkAn540OrQ61wjv1+BXj1jS0fk3ADRA/nqo=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=O9IOyVJeMQnet96eH9guo42+yB+uBVCtGtquKuyfr5DcpoQRFiW34v+OmqQLm+4BRmyn3riUsmuzgWP5y+95aPm6edyVYDW4EqQIN97/sf9oz/kREZLVq+6FXod7uFexoxA3Wqe8GwAtpYjlkf459ain6gtUFkNf5Izdty/qH3s= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=Nj4wJ++A; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=C4SaRm0H; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="Nj4wJ++A"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="C4SaRm0H" Received: from pps.filterd (m0279867.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 6993HCNl1712596 for ; Fri, 9 Oct 2026 06:18:19 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= C+cpcIHle0L9Ji+owdA1hX6Vn5Za9wzxxI+3oH/nAuU=; b=Nj4wJ++AJBKvafj7 36sQsQxQuxtaZbp8bb2yzXlY2MXYJanP8gNDkUYvsE6JGP+yHihygc7EvOdNV2Na qEU6Ov1gqEei1UIuYuo9fNTUp0fxHWVneHFhIZB7MDIpwb//rYXmKQWQUvRQCFsS vOPkWhunL1aChSmVhB8Qfk30t6CURg+GRip0mBUUpFG4mZUFVkXzRXTA4jlfy8p5 Ov1ikNuMTN/WaS09IaGuWR0Ij3YvA4LUqSaSp+yHbWdvCEp06GpbuBSDfKeWGpAF jPB7C7g4MbzyVimmRz+m4cQN74VfRf+4A9m3IACyT2uevUBM137hy5uCc2YgeFB/ lE3oXw== Received: from mail-dl1-f72.google.com (mail-dl1-f72.google.com [74.125.82.72]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4h6fxwa7fu-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Fri, 09 Oct 2026 06:18:19 +0000 (GMT) Received: by mail-dl1-f72.google.com with SMTP id a92af1059eb24-151ba226e1bso9047723c88.0 for ; Thu, 08 Oct 2026 23:18:18 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1791526698; x=1792131498; darn=vger.kernel.org; h=content-transfer-encoding:content-type:in-reply-to:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:from:to:cc:subject:date:message-id:reply-to :content-type; bh=C+cpcIHle0L9Ji+owdA1hX6Vn5Za9wzxxI+3oH/nAuU=; b=C4SaRm0Hoc09ZYcBUd14GJSTy+KyHJgJkZiAdLSXrz2h9xFq1qqVL5CnKSf8qzHcqg wgRMdH3P/lwQ9RUgo9tPfXf1Bkg7PCVNqABzRghcKXqWWnnD7+vmMllx3gPosQZDPN0G 1mWJTVH+yXFh0RcC3FRlRzCqR9zaDtYmVsi7mzuRnyFR012JYUz5NxgBXrPoMZGwwtNC oDgRvsFD865Y5ir+Z3HViXiD4H4CiEnEKoVC67+a8bbFVXImHTBUEQ+y1NhaBOcIqqa2 3H7fMQPdTSyZTPJsK+TOycUVoFKQhT+X/P0JC/PK9FbJpZA7BPA3wFHLd6AhBNij9x4a recw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20260707; t=1791526698; x=1792131498; h=content-transfer-encoding:content-type:in-reply-to:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=C+cpcIHle0L9Ji+owdA1hX6Vn5Za9wzxxI+3oH/nAuU=; b=IeygWk9sC6rkqPKEYDhWFYdNO9CgCm+dFIB29cnoPIUhrCQO+MoYrESkrFLvDJl90G gKCQONG93JjHo/yrC8nJuP/QKJmu1JFw90XxrPsGZDOC1taVnSS8fdV94wYeY0YCghG3 GQ/vGEmxP/RG9SoBCU6wTGVDZtc+/X1hDWaOIdfBt3mRuAUZaU7XH/phFelo7G/GA1VR 4lP6JxDv24rPcKhEBmJhXFf+LWgC5FlTKm+2x5BNND/aUmmdp37q1wha/dKazpi5tNgh wQA8IbU5cUEHeQDI6omqqkeclKQ3CHCVt6qoH2Rr3NhN3bV3a/Uk81LiCuvZJcXfcaHM 3vlg== X-Forwarded-Encrypted: i=1; AKwUvBzCguSKS0AdMyxc+XlWDnpMmmPt/fc4sjlzQhhxgzNoIqzWjAMukKFfJ1YlWv7Vt+0Yj2G2EoI5CZGT@vger.kernel.org X-Gm-Message-State: AFuF++nPNLuZjMfs0lG86/cAT8JJyqNWp98bPzWhO1gXanohinDvl5D1 zPQeQbFgfzVIJZh28fR5bNg8j8TxNTtBEFXGPe+JwJBv7AZJBOaRbALKZdAUbgEDWMAcsnU9hmg St5jWS47RRTejkGEOfrYP+nyQp/LMglVFTvq+CXScBvbqio0/8+9YloWlLJ8cAkfj X-Gm-Gg: AYBFou3p5VchPz4vJr82ztRRWQOy3voKQ+Epv43vrlOGzBfbTkQVdIFHmBrP6YeZbaF wKzdRNFRSCGUdkIBjg2Q4yWY5sDnh+A8YR4AtCVuBW2wMtWSNMc6udOyy8lKBoT37WtM+HEhITJ s4QHLBySWUMCFhp+xWQe8OFdMArsZdu/9qCXTTqnlabjllIcIyaZBy6tLNBP+y+9x9eNIjqMRcV hg/wnTq+GE0Vwtoa5vewpzP3tqfDl0bMP2x1elP3XA3fjwYCpdzeihQcOZo2Odp6uMv4rql/Ucj aADV/Yoi4m4qP0QriC/cPiWCfOJOCSqiro8xntv+erXp4Eqd0xGL1EP7qdFJF8fKlD3Cw4GynCf u87fXf2MEpRmR0hlDlIxxqboz3cExmP9aKygJSA== X-Received: by 2002:a05:701b:4349:b0:15c:20b8:796e with SMTP id a92af1059eb24-16a5f112b00mr1097310c88.22.1791526698100; Thu, 08 Oct 2026 23:18:18 -0700 (PDT) X-Received: by 2002:a05:701b:4349:b0:15c:20b8:796e with SMTP id a92af1059eb24-16a5f112b00mr1097280c88.22.1791526697566; Thu, 08 Oct 2026 23:18:17 -0700 (PDT) Received: from [10.218.21.154] ([202.46.22.19]) by smtp.gmail.com with ESMTPSA id a92af1059eb24-169a31f6be0sm7716862c88.13.2026.10.08.23.18.12 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 08 Oct 2026 23:18:17 -0700 (PDT) Message-ID: <394cbef8-e993-4741-819b-bb074d4c0d33@oss.qualcomm.com> Date: Fri, 9 Oct 2026 11:48:10 +0530 Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 0/5] ASoC: qcom: Add Nord audio support To: Shawn Guo Cc: Shenghao Ding , Kevin Lu , Baojun Xu , Sen Wang , Liam Girdwood , Mark Brown , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Jaroslav Kysela , Takashi Iwai , Srinivas Kandagatla , linux-sound@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org References: <20261008-nord-asoc-driver-support-v2-v2-0-0b6f7e94060d@oss.qualcomm.com> Content-Language: en-US From: Mohammad Rafi Shaik In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYxMDA5MDAyNCBTYWx0ZWRfX7+OdC3S9Vx1i pZUk6e/FjeDq99YQQlTaOjdxsRMyNg+gkakcWfLmDq6eurQh6JzdgFRONZzwhml7xdRHi4DfuAu 7k4u4idYKxTCuEYa5a1V+zMYmubP1JnD6dyDMt9eEvcrCvSvGl+sgTxs5JWacpkI8TDXi9EaW/M sXAQm0urRA2HZGe/zXylmiZ+9d2SHi0dBQkDqXDoaq9JRRU8QxlfI6ZRMWifwYWeZWUiMYp6KHq 5gEaJZKCjn+u1UXdVR9CDb88RFHGBQlDCreostNRBH12eyDqQSUof8oljkqcmu8dmq/8wJXOgvn Cp6v222R6IK1u85rzQtvnmsC6jvIDQaXfC8AzLipxsM05FO8tx1wWvb4xMe+t0C/GPUwdqDASou ZEcDlMi/186r5gbmzPaQgJY4Ti35EritSNE3WAveg3pwAOxTnAUMk0FZGMUpUj0OwZ9VCT6vJ3Z 1J9R56uNlPQ8ZVx0BAw== X-Proofpoint-GUID: SaDVqUM3PkjiMmPgQPYecYTHcukljz9Y X-Authority-Analysis: v=2.4 cv=cMB1IVeN c=1 sm=1 tr=0 ts=6ac8872b cx=c_pps a=bS7HVuBVfinNPG3f6cIo3Q==:117 a=fChuTYTh2wq5r3m49p7fHw==:17 a=IkcTkHD0fZMA:10 a=660iZSQnnn4A:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=eoimf2acIAo5FJnRuUoq:22 a=bC-a23v3AAAA:8 a=EUspDBNiAAAA:8 a=VwQbUJbxAAAA:8 a=5CsdgRGpw5DW-Y5J6h4A:9 a=QEXdDO2ut3YA:10 a=vBUdepa8ALXHeOFLBtFW:22 a=FO4_E8m0qiDe52t0p3_H:22 X-Proofpoint-Spam-Info: AW1haW4tMjYxMDA5MDAyNCBTYWx0ZWRfXwG20uB05YszE HZhnOwrN4QfKWF2kHUkPQ38AoWKhdTXhqx5eq5sThvq6LmBweoHQz/S744k4MQ6C36YDaT3vk/j EOMobZ6qCLnY/8jv7zjAJpOg5PdgHR4= X-Proofpoint-ORIG-GUID: SaDVqUM3PkjiMmPgQPYecYTHcukljz9Y X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1176,Hydra:6.1.134,FMLib:17.12.100.49 definitions=2026-10-09_02,2026-10-08_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 priorityscore=1501 suspectscore=0 spamscore=0 lowpriorityscore=0 malwarescore=0 adultscore=0 bulkscore=0 impostorscore=0 phishscore=0 clxscore=1015 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2610020000 definitions=main-2610090024 On 10/9/2026 7:20 AM, Shawn Guo wrote: > On Thu, Oct 08, 2026 at 04:36:40PM +0530, Mohammad Rafi Shaik wrote: >> This series adds audio support for the Qualcomm Nord Ride and >> RRD boards and includes the required machine driver, device tree >> binding updates, and codec improvements needed for the board's >> external audio codec configuration. >> >> Nord Ride uses a PCM1681 DAC for playback and an ADAU1979 ADC for capture. >> Compared to other SC8280XP based platforms, Nord Ride requires >> board-specific DAI format and codec clock configuration to support >> the external PCM1681 DAC and ADAU1979 ADC. >> >> Signed-off-by: Mohammad Rafi Shaik >> --- >> Changes in v2: >> - Dropped patch 1 from v1, as the ADAU1979 codec change has already been applied. >> - Moved the compatible string from the board-specific file to the SoC file, as suggested by Shawn. >> - Added runtime PM support to the PCM1681 codec to manage the SCK clock sequence. >> - Added TDM support to the PCM1681 codec. >> - Added the required POR delay to the PCM1681 codec, as suggested by Mark Brown. >> - Replaced LPASS DAI IDs with QAIF DAI IDs. >> - Link to v1: https://patch.msgid.link/20260907-nord-asoc-driver-support-v1-0-997d3b20cf43@oss.qualcomm.com > > I expect some PCM1681 driver changes in v2 to address Konrad's > comment [1]. Or do I miss something? > Thanks for pointing out. i missed this since comment in Device tree. Will fix in next revision. Best Regards, Rafi. > Shawn > > [1] https://lore.kernel.org/all/d2d2feff-4823-43dc-9014-099e69195280@oss.qualcomm.com/