From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id A755BEB64DB for ; Wed, 14 Jun 2023 12:53:05 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S238697AbjFNMxE (ORCPT ); Wed, 14 Jun 2023 08:53:04 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:50852 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S241026AbjFNMxD (ORCPT ); Wed, 14 Jun 2023 08:53:03 -0400 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id 69FB71BF0; Wed, 14 Jun 2023 05:53:01 -0700 (PDT) Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 3331F1FB; Wed, 14 Jun 2023 05:53:45 -0700 (PDT) Received: from [10.57.25.82] (unknown [10.57.25.82]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 405CE3F663; Wed, 14 Jun 2023 05:52:57 -0700 (PDT) Message-ID: <394d0129-e3a5-5b16-6e18-b4a3102aa50c@arm.com> Date: Wed, 14 Jun 2023 14:52:55 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0) Gecko/20100101 Thunderbird/102.11.1 Subject: Re: [PATCH V5 6/6] coresight: etm4x: Add ACPI support in platform driver From: Suzuki K Poulose To: "Rafael J. Wysocki" , Len Brown , rafael.j.wysocki@intel.com Cc: scclevenger@os.amperecomputing.com, Ganapatrao Kulkarni , Rob Herring , Frank Rowand , Russell King , Greg Kroah-Hartman , Sudeep Holla , Lorenzo Pieralisi , Mathieu Poirier , Mike Leach , Leo Yan , devicetree@vger.kernel.org, linux-acpi@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, "anshuman.khandual@arm.com" References: <20230529062511.52016-1-anshuman.khandual@arm.com> <20230529062511.52016-7-anshuman.khandual@arm.com> <4c3572f8-9710-0955-72c6-a9907ce6ce8b@arm.com> <49c9e20a-f020-0dc5-8601-06b5f0ab8c5c@arm.com> In-Reply-To: <49c9e20a-f020-0dc5-8601-06b5f0ab8c5c@arm.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On 06/06/2023 10:36, Suzuki K Poulose wrote: > Hi Rafael, > > Gentle ping. Gentle ping.. > > On 30/05/2023 10:57, Suzuki K Poulose wrote: >> Hi Rafael >> >> On 29/05/2023 07:25, Anshuman Khandual wrote: >>> From: Suzuki K Poulose >>> >>> Drop ETM4X ACPI ID from the AMBA ACPI device list, and instead just >>> move it >>> inside the new ACPI devices list detected and used via platform driver. >>> >>> Cc: "Rafael J. Wysocki" >>> Cc: Len Brown >>> Cc: Mathieu Poirier >>> Cc: Suzuki K Poulose >>> Cc: Mike Leach >>> Cc: Leo Yan >>> Cc: Sudeep Holla >>> Cc: Lorenzo Pieralisi >>> Cc: linux-acpi@vger.kernel.org >>> Cc: coresight@lists.linaro.org >>> Cc: linux-arm-kernel@lists.infradead.org >>> Cc: linux-kernel@vger.kernel.org >>> Reviewed-by: Sudeep Holla (for ACPI specific >>> changes) >>> Signed-off-by: Suzuki K Poulose >>> Signed-off-by: Anshuman Khandual >>> --- >>>   drivers/acpi/acpi_amba.c                           |  1 - >> >> We would like to push this via the coresight tree. Please could you >> Ack this change if you are happy with the proposal and the change ? >> > > > Suzuki > Suzuki > >> Suzuki >> >> >>>   drivers/hwtracing/coresight/coresight-etm4x-core.c | 10 ++++++++++ >>>   2 files changed, 10 insertions(+), 1 deletion(-) >>> >>> diff --git a/drivers/acpi/acpi_amba.c b/drivers/acpi/acpi_amba.c >>> index f5b443ab01c2..099966cbac5a 100644 >>> --- a/drivers/acpi/acpi_amba.c >>> +++ b/drivers/acpi/acpi_amba.c >>> @@ -22,7 +22,6 @@ >>>   static const struct acpi_device_id amba_id_list[] = { >>>       {"ARMH0061", 0}, /* PL061 GPIO Device */ >>>       {"ARMH0330", 0}, /* ARM DMA Controller DMA-330 */ >>> -    {"ARMHC500", 0}, /* ARM CoreSight ETM4x */ >>>       {"ARMHC501", 0}, /* ARM CoreSight ETR */ >>>       {"ARMHC502", 0}, /* ARM CoreSight STM */ >>>       {"ARMHC503", 0}, /* ARM CoreSight Debug */ >>> diff --git a/drivers/hwtracing/coresight/coresight-etm4x-core.c >>> b/drivers/hwtracing/coresight/coresight-etm4x-core.c >>> index e10f6676dd9b..fd6f9dff5881 100644 >>> --- a/drivers/hwtracing/coresight/coresight-etm4x-core.c >>> +++ b/drivers/hwtracing/coresight/coresight-etm4x-core.c >>> @@ -3,6 +3,7 @@ >>>    * Copyright (c) 2014, The Linux Foundation. All rights reserved. >>>    */ >>> +#include >>>   #include >>>   #include >>>   #include >>> @@ -2344,12 +2345,21 @@ static const struct of_device_id >>> etm4_sysreg_match[] = { >>>       {} >>>   }; >>> +#ifdef CONFIG_ACPI >>> +static const struct acpi_device_id etm4x_acpi_ids[] = { >>> +    {"ARMHC500", 0}, /* ARM CoreSight ETM4x */ >>> +    {} >>> +}; >>> +MODULE_DEVICE_TABLE(acpi, etm4x_acpi_ids); >>> +#endif >>> + >>>   static struct platform_driver etm4_platform_driver = { >>>       .probe        = etm4_probe_platform_dev, >>>       .remove        = etm4_remove_platform_dev, >>>       .driver            = { >>>           .name            = "coresight-etm4x", >>>           .of_match_table        = etm4_sysreg_match, >>> +        .acpi_match_table    = ACPI_PTR(etm4x_acpi_ids), >>>           .suppress_bind_attrs    = true, >>>           .pm            = &etm4_dev_pm_ops, >>>       }, >> >