Re: [PATCH v2 01/25] mtd: nand: qcom: fix config error for BCH

[Abhishek Sahu <absahu@codeaurora.org>]

On 2017-08-04 00:17, Boris Brezillon wrote:
> On Thu, 03 Aug 2017 23:22:37 +0530
> Abhishek Sahu <absahu@codeaurora.org> wrote:
> 
>> On 2017-08-03 21:26, Boris Brezillon wrote:
>> > On Wed, 19 Jul 2017 17:17:49 +0530
>> > Abhishek Sahu <absahu@codeaurora.org> wrote:
>> >
>> >> The configuration for BCH is not correct in the current driver.
>> >> The ECC_CFG_ECC_DISABLE bit defines whether to enable or disable the
>> >> BCH ECC in which
>> >>
>> >> 	0x1 : BCH_DISABLED
>> >> 	0x0 : BCH_ENABLED
>> >>
>> >> But currently host->bch_enabled is being assined to BCH_DISABLED.
>> >>
>> >> Fixes: c76b78d8ec05a ("mtd: nand: Qualcomm NAND controller driver")
>> >> Cc: stable@vger.kernel.org
>> >> Signed-off-by: Abhishek Sahu <absahu@codeaurora.org>
>> >> ---
>> >>  drivers/mtd/nand/qcom_nandc.c | 4 ++--
>> >>  1 file changed, 2 insertions(+), 2 deletions(-)
>> >>
>> >> diff --git a/drivers/mtd/nand/qcom_nandc.c
>> >> b/drivers/mtd/nand/qcom_nandc.c
>> >> index 57d483a..bc0408c 100644
>> >> --- a/drivers/mtd/nand/qcom_nandc.c
>> >> +++ b/drivers/mtd/nand/qcom_nandc.c
>> >> @@ -1,5 +1,5 @@
>> >>  /*
>> >> - * Copyright (c) 2016, The Linux Foundation. All rights reserved.
>> >> + * Copyright (c) 2016-2017, The Linux Foundation. All rights
>> >> reserved.
>> >
>> > Hm, this copyright update is not really related to the changes you're
>> > describing in the commit message. I'll drop this line from the commit
>> > (no need to resend it) and ask you to send a separate patch updating
>> > the
>> > copyright. Is that ok?
>> >
>> 
>>   The idea was to change the copyright year since we are making
>>   the changes in this file. If it requires separate patch, then I
>>   will do the same.
> 
> Yes, I'd prefer a separate patch.

  Sure. will raise a separate patch

> 
>> 
>>   Also I need to change 'assined' -> assigned in commit text.
> 
> Yep, already fixed that one.
> 
>> I can
>>   update the patch and fix this. I am planning to send the v3 patches
>>   tomorrow which incorporates all the review comments.
> 
> Can you wait a bit. I already applied some of your patches [1] and 
> would
> like to finish my review.

  Thanks Boris. I will wait for it and will update my patch series
  accordingly.

> 
> Thanks,
> 
> Boris
> 
> [1]https://github.com/bbrezillon/linux-0day/commits/nand/next