Re: [linux-next:master 9473/11093] arch/arm64/boot/dts/rockchip/rk3562.dtsi:624.26-675.5: Warning (simple_bus_reg): /soc/pcie@ff500000: simple-bus unit address format error, expected "fe000000"

Re: [linux-next:master 9473/11093] arch/arm64/boot/dts/rockchip/rk3562.dtsi:624.26-675.5: Warning (simple_bus_reg): /soc/pcie@ff500000: simple-bus unit address format error, expected "fe000000"

[Heiko Stübner]

Am Donnerstag, 15. Mai 2025, 16:04:20 Mitteleuropäische Sommerzeit schrieb kernel test robot:
> tree:   https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git master
> head:   bdd609656ff5573db9ba1d26496a528bdd297cf2
> commit: ceb6ef1ea9002669afc0e1ef258e530d3c05d91a [9473/11093] arm64: dts: rockchip: Add RK3562 evb2 devicetree
> config: arm64-randconfig-2052-20250513 (https://download.01.org/0day-ci/archive/20250515/202505150745.PQT9TLYX-lkp@intel.com/config)
> compiler: clang version 21.0.0git (https://github.com/llvm/llvm-project f819f46284f2a79790038e1f6649172789734ae8)
> dtschema version: 2025.3.dev27+g32749b3
> reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20250515/202505150745.PQT9TLYX-lkp@intel.com/reproduce)
> 
> If you fix the issue in a separate patch/commit (i.e. not just a new version of
> the same patch/commit), kindly add following tags
> | Reported-by: kernel test robot <lkp@intel.com>
> | Closes: https://lore.kernel.org/oe-kbuild-all/202505150745.PQT9TLYX-lkp@intel.com/
> 
> dtcheck warnings: (new ones prefixed by >>)
> >> arch/arm64/boot/dts/rockchip/rk3562.dtsi:624.26-675.5: Warning (simple_bus_reg): /soc/pcie@ff500000: simple-bus unit address format error, expected "fe000000"
> >> arch/arm64/boot/dts/rockchip/rk3562.dtsi:1115.20-1181.5: Warning (simple_bus_reg): /soc/pinctrl: missing or empty reg/ranges property

hmm, I don't really understand this error message.

From a practical point, the dtschema-version I have installed is
2025.3.dev27+g32749b3, which is the topmost commit from
may-13th.

Running the dtbscheck on the rk3562-evb-v10.dtb on the full
linux-next from today, yields no errors.

Checking out the specific commit ceb6ef1ea90026 brings up the
errors from below [1], because they come from different trees.


But in no cases does dtbscheck complain about the PCI memory regions.


The PCIe controller in question of course has 3 memory regions
	reg = <0x0 0xfe000000 0x0 0x400000>,
	      <0x0 0xff500000 0x0 0x10000>,
	      <0x0 0xfc000000 0x0 0x100000>;
	reg-names = "dbi", "apb", "config";

and currently the node-name mimics the "apb" memory region.
Should it always use the first one?


[1]
>    arch/arm64/boot/dts/rockchip/rk3562-evb2-v10.dtb: /soc/power-management@ff258000/power-controller: failed to match any schema with compatible: ['rockchip,rk3562-power-controller']
>    arch/arm64/boot/dts/rockchip/rk3562-evb2-v10.dtb: pcie@ff500000 (rockchip,rk3562-pcie): interrupt-names:5: 'dma0' was expected
>    	from schema $id: http://devicetree.org/schemas/pci/rockchip-dw-pcie.yaml#
>    arch/arm64/boot/dts/rockchip/rk3562-evb2-v10.dtb: pcie@ff500000 (rockchip,rk3562-pcie): compatible: 'oneOf' conditional failed, one must be fixed:
>    	['rockchip,rk3562-pcie', 'rockchip,rk3568-pcie'] is too long
>    	'rockchip,rk3568-pcie' was expected
> 

Re: [linux-next:master 9473/11093] arch/arm64/boot/dts/rockchip/rk3562.dtsi:624.26-675.5: Warning (simple_bus_reg): /soc/pcie@ff500000: simple-bus unit address format error, expected "fe000000"

[Krzysztof Kozlowski]

On 16/05/2025 22:10, Heiko Stübner wrote:
> Am Donnerstag, 15. Mai 2025, 16:04:20 Mitteleuropäische Sommerzeit schrieb kernel test robot:
>> tree:   https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git master
>> head:   bdd609656ff5573db9ba1d26496a528bdd297cf2
>> commit: ceb6ef1ea9002669afc0e1ef258e530d3c05d91a [9473/11093] arm64: dts: rockchip: Add RK3562 evb2 devicetree
>> config: arm64-randconfig-2052-20250513 (https://download.01.org/0day-ci/archive/20250515/202505150745.PQT9TLYX-lkp@intel.com/config)
>> compiler: clang version 21.0.0git (https://github.com/llvm/llvm-project f819f46284f2a79790038e1f6649172789734ae8)
>> dtschema version: 2025.3.dev27+g32749b3
>> reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20250515/202505150745.PQT9TLYX-lkp@intel.com/reproduce)
>>
>> If you fix the issue in a separate patch/commit (i.e. not just a new version of
>> the same patch/commit), kindly add following tags
>> | Reported-by: kernel test robot <lkp@intel.com>
>> | Closes: https://lore.kernel.org/oe-kbuild-all/202505150745.PQT9TLYX-lkp@intel.com/
>>
>> dtcheck warnings: (new ones prefixed by >>)
>>>> arch/arm64/boot/dts/rockchip/rk3562.dtsi:624.26-675.5: Warning (simple_bus_reg): /soc/pcie@ff500000: simple-bus unit address format error, expected "fe000000"
>>>> arch/arm64/boot/dts/rockchip/rk3562.dtsi:1115.20-1181.5: Warning (simple_bus_reg): /soc/pinctrl: missing or empty reg/ranges property
> 
> hmm, I don't really understand this error message.
> 
> From a practical point, the dtschema-version I have installed is
> 2025.3.dev27+g32749b3, which is the topmost commit from
> may-13th.
> 
> Running the dtbscheck on the rk3562-evb-v10.dtb on the full
> linux-next from today, yields no errors.

These are standard dtc warnings.

> 
> Checking out the specific commit ceb6ef1ea90026 brings up the
> errors from below [1], because they come from different trees.
> 
> 
> But in no cases does dtbscheck complain about the PCI memory regions.
> 
> 
> The PCIe controller in question of course has 3 memory regions
> 	reg = <0x0 0xfe000000 0x0 0x400000>,
> 	      <0x0 0xff500000 0x0 0x10000>,
> 	      <0x0 0xfc000000 0x0 0x100000>;
> 	reg-names = "dbi", "apb", "config";
> 
> and currently the node-name mimics the "apb" memory region.
> Should it always use the first one?

I don't understand where is the problem. The warning tells you: unit
address is not correct. Fix the unit address to match reg.


About second warning: that's also kind of already existing issue and
fixed in multiple places. Don't put non-MMIO nodes in simple-bus, like
soc, because it is not correct. simple-bus is for MMIO nodes.

Best regards,
Krzysztof

Re: [linux-next:master 9473/11093] arch/arm64/boot/dts/rockchip/rk3562.dtsi:624.26-675.5: Warning (simple_bus_reg): /soc/pcie@ff500000: simple-bus unit address format error, expected "fe000000"

[Heiko Stübner]

Am Sonntag, 18. Mai 2025, 12:36:50 Mitteleuropäische Sommerzeit schrieb Krzysztof Kozlowski:
> On 16/05/2025 22:10, Heiko Stübner wrote:
> > Am Donnerstag, 15. Mai 2025, 16:04:20 Mitteleuropäische Sommerzeit schrieb kernel test robot:
> >> tree:   https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git master
> >> head:   bdd609656ff5573db9ba1d26496a528bdd297cf2
> >> commit: ceb6ef1ea9002669afc0e1ef258e530d3c05d91a [9473/11093] arm64: dts: rockchip: Add RK3562 evb2 devicetree
> >> config: arm64-randconfig-2052-20250513 (https://download.01.org/0day-ci/archive/20250515/202505150745.PQT9TLYX-lkp@intel.com/config)
> >> compiler: clang version 21.0.0git (https://github.com/llvm/llvm-project f819f46284f2a79790038e1f6649172789734ae8)
> >> dtschema version: 2025.3.dev27+g32749b3
> >> reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20250515/202505150745.PQT9TLYX-lkp@intel.com/reproduce)
> >>
> >> If you fix the issue in a separate patch/commit (i.e. not just a new version of
> >> the same patch/commit), kindly add following tags
> >> | Reported-by: kernel test robot <lkp@intel.com>
> >> | Closes: https://lore.kernel.org/oe-kbuild-all/202505150745.PQT9TLYX-lkp@intel.com/
> >>
> >> dtcheck warnings: (new ones prefixed by >>)
> >>>> arch/arm64/boot/dts/rockchip/rk3562.dtsi:624.26-675.5: Warning (simple_bus_reg): /soc/pcie@ff500000: simple-bus unit address format error, expected "fe000000"
> >>>> arch/arm64/boot/dts/rockchip/rk3562.dtsi:1115.20-1181.5: Warning (simple_bus_reg): /soc/pinctrl: missing or empty reg/ranges property
> > 
> > hmm, I don't really understand this error message.
> > 
> > From a practical point, the dtschema-version I have installed is
> > 2025.3.dev27+g32749b3, which is the topmost commit from
> > may-13th.
> > 
> > Running the dtbscheck on the rk3562-evb-v10.dtb on the full
> > linux-next from today, yields no errors.
> 
> These are standard dtc warnings.
> 
> > 
> > Checking out the specific commit ceb6ef1ea90026 brings up the
> > errors from below [1], because they come from different trees.
> > 
> > 
> > But in no cases does dtbscheck complain about the PCI memory regions.
> > 
> > 
> > The PCIe controller in question of course has 3 memory regions
> > 	reg = <0x0 0xfe000000 0x0 0x400000>,
> > 	      <0x0 0xff500000 0x0 0x10000>,
> > 	      <0x0 0xfc000000 0x0 0x100000>;
> > 	reg-names = "dbi", "apb", "config";
> > 
> > and currently the node-name mimics the "apb" memory region.
> > Should it always use the first one?
> 
> I don't understand where is the problem. The warning tells you: unit
> address is not correct. Fix the unit address to match reg.

The problem was more on "is my toolchain outdated or why am I not seeing
these reports". Which I now managed to resolve, because I finally saw the
"(this is a W=1 build)" in the header of the reporting mail ;-)


So yes, with the dtschema warning about the power-controller I got my mind
stuck in the "is my dtschema" outdated, not realizing that the first one
comes from dtc itself and then also missing the "(this is a W=1 build)"
mention.


Heiko