devicetree.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
To: Marijn Suijten <marijn.suijten@somainline.org>
Cc: Andy Gross <agross@kernel.org>,
	Bjorn Andersson <bjorn.andersson@linaro.org>,
	Rob Herring <robh+dt@kernel.org>,
	Krzysztof Kozlowski <krzk@kernel.org>,
	Konrad Dybcio <konrad.dybcio@somainline.org>,
	linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org
Subject: Re: [PATCH v3 2/8] arm64: dts: qcom: sdm630: disable dsi1/dsi1_phy by default
Date: Sat, 14 May 2022 15:59:25 +0300	[thread overview]
Message-ID: <39864947-af5a-2a0c-79b0-ff504b319cd1@linaro.org> (raw)
In-Reply-To: <20220514093756.f7gqpo2ok2osbcm4@SoMainline.org>

On 14/05/2022 12:37, Marijn Suijten wrote:
> Title copy-paste error: it should read dsi0/dsi0_phy.  Can you also
> reorder this patch together with the dsi1/dsi1_phy one, and perhaps they
> should just be squashed?  Otherwise, does a Suggested-by: make sense
> here?

Yes, it does. Please excuse me.

> 
> - Marijn
> 
> On 2022-05-14 02:45:12, Dmitry Baryshkov wrote:
>> Follow the typical practice and keep DSI0/DSI0 PHY disabled by default.
>> They should be enabled in the board DT files. No existing boards use
>> them at this moment.
>>
>> Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
>> ---
>>   arch/arm64/boot/dts/qcom/sdm630.dtsi | 3 +++
>>   1 file changed, 3 insertions(+)
>>
>> diff --git a/arch/arm64/boot/dts/qcom/sdm630.dtsi b/arch/arm64/boot/dts/qcom/sdm630.dtsi
>> index 240293592ef9..8697d40e9b74 100644
>> --- a/arch/arm64/boot/dts/qcom/sdm630.dtsi
>> +++ b/arch/arm64/boot/dts/qcom/sdm630.dtsi
>> @@ -1559,6 +1559,8 @@ dsi0: dsi@c994000 {
>>   				phys = <&dsi0_phy>;
>>   				phy-names = "dsi";
>>   
>> +				status = "disabled";
>> +
>>   				ports {
>>   					#address-cells = <1>;
>>   					#size-cells = <0>;
>> @@ -1592,6 +1594,7 @@ dsi0_phy: dsi-phy@c994400 {
>>   
>>   				clocks = <&mmcc MDSS_AHB_CLK>, <&xo_board>;
>>   				clock-names = "iface", "ref";
>> +				status = "disabled";
>>   			};
>>   		};
>>   
>> -- 
>> 2.35.1
>>


-- 
With best wishes
Dmitry

  reply	other threads:[~2022-05-14 12:59 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-05-13 23:45 [PATCH v3 0/8] arm64: dts: qcom: initial Inforce IFC6560 board support Dmitry Baryshkov
2022-05-13 23:45 ` [PATCH v3 1/8] arm64: dts: qcom: sdm660: disable dsi1/dsi1_phy by default Dmitry Baryshkov
2022-05-13 23:45 ` [PATCH v3 2/8] arm64: dts: qcom: sdm630: " Dmitry Baryshkov
2022-05-14  9:37   ` Marijn Suijten
2022-05-14 12:59     ` Dmitry Baryshkov [this message]
2022-05-13 23:45 ` [PATCH v3 3/8] arm64: dts: qcom: sdm630: disable GPU " Dmitry Baryshkov
2022-05-14  9:54   ` Marijn Suijten
2022-05-13 23:45 ` [PATCH v3 4/8] arm64: dts: qcom: sdm630: fix the qusb2phy ref clock Dmitry Baryshkov
2022-05-14  9:56   ` Marijn Suijten
2022-05-14 13:00     ` Dmitry Baryshkov
2022-05-13 23:45 ` [PATCH v3 5/8] arm64: dts: qcom: sdm630: add second (HS) USB host support Dmitry Baryshkov
2022-05-14 10:11   ` Marijn Suijten
2022-05-13 23:45 ` [PATCH v3 6/8] arm64: dts: qcom: sdm630: use defined symbols for interconnects Dmitry Baryshkov
2022-05-14  9:45   ` Marijn Suijten
2022-05-14 12:51     ` Dmitry Baryshkov
2022-05-15 14:44       ` Marijn Suijten
2022-05-15 18:05         ` Dmitry Baryshkov
2022-05-13 23:45 ` [PATCH v3 7/8] arm64: dts: qcom: sdm660: Add initial Inforce IFC6560 board support Dmitry Baryshkov
2022-05-14 10:31   ` Marijn Suijten
2022-05-14 13:09     ` Dmitry Baryshkov
2022-05-13 23:45 ` [PATCH v3 8/8] dt-bindings: arm: qcom: document sda660 SoC and ifc6560 board Dmitry Baryshkov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=39864947-af5a-2a0c-79b0-ff504b319cd1@linaro.org \
    --to=dmitry.baryshkov@linaro.org \
    --cc=agross@kernel.org \
    --cc=bjorn.andersson@linaro.org \
    --cc=devicetree@vger.kernel.org \
    --cc=konrad.dybcio@somainline.org \
    --cc=krzk@kernel.org \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=marijn.suijten@somainline.org \
    --cc=robh+dt@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).