From: Krzysztof Kozlowski <krzk@kernel.org>
To: Kanak Shilledar <kanakshilledar@gmail.com>
Cc: "Philipp Zabel" <p.zabel@pengutronix.de>,
"Rob Herring" <robh@kernel.org>,
"Krzysztof Kozlowski" <krzk+dt@kernel.org>,
"Conor Dooley" <conor+dt@kernel.org>,
"William Zhang" <william.zhang@broadcom.com>,
"Anand Gore" <anand.gore@broadcom.com>,
"Kursad Oney" <kursad.oney@broadcom.com>,
"Florian Fainelli" <florian.fainelli@broadcom.com>,
"Rafał Miłecki" <rafal@milecki.pl>,
"Broadcom internal kernel review list"
<bcm-kernel-feedback-list@broadcom.com>,
"Kanak Shilledar" <kanakshilledar111@protonmail.com>,
devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] dt-bindings: reset: brcm,bcm63138-pmb: convert to yaml
Date: Tue, 11 Jun 2024 08:58:14 +0200 [thread overview]
Message-ID: <398ee3a7-513e-4dd6-8ff9-b7585f005d28@kernel.org> (raw)
In-Reply-To: <20240611035329.33648-2-kanakshilledar@gmail.com>
On 11/06/2024 05:53, Kanak Shilledar wrote:
> Convert the Broadcom BCM63138 Processor Monitor Bus to newer DT
> schema. Created DT schema based on the .txt file which had `compatible`,
> `reg` and `"#reset-cells" as required properties.
> Added one line description which was missing in the original .txt file.
> Added Philipp Zabel as the maintainer (took from MAINTAINERS file).
One of the necessary steps EVERYTIME you make conversion of some random
binding is to grep. git grep. You grep for stale paths and usage of
compatible in DTS. Sometimes you find nothing, sometimes you would find
something.
`git grep bcm63138-pmb` gives you:
1. stale path which you did not fix,
2. duplicated schema...
Best regards,
Krzysztof
next prev parent reply other threads:[~2024-06-11 6:58 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-06-11 3:53 [PATCH] dt-bindings: reset: brcm,bcm63138-pmb: convert to yaml Kanak Shilledar
2024-06-11 5:30 ` Rob Herring (Arm)
2024-06-11 6:58 ` Krzysztof Kozlowski [this message]
2024-06-11 7:23 ` Kanak Shilledar
2024-06-11 8:14 ` Krzysztof Kozlowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=398ee3a7-513e-4dd6-8ff9-b7585f005d28@kernel.org \
--to=krzk@kernel.org \
--cc=anand.gore@broadcom.com \
--cc=bcm-kernel-feedback-list@broadcom.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=florian.fainelli@broadcom.com \
--cc=kanakshilledar111@protonmail.com \
--cc=kanakshilledar@gmail.com \
--cc=krzk+dt@kernel.org \
--cc=kursad.oney@broadcom.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=p.zabel@pengutronix.de \
--cc=rafal@milecki.pl \
--cc=robh@kernel.org \
--cc=william.zhang@broadcom.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).