* [PATCH v4 0/3] SM6375 remoteprocs
@ 2023-07-25 9:00 Konrad Dybcio
2023-07-25 9:00 ` [PATCH v4 1/3] dt-bindings: remoteproc: qcom,sm6375-pas: Document remoteprocs Konrad Dybcio
` (2 more replies)
0 siblings, 3 replies; 6+ messages in thread
From: Konrad Dybcio @ 2023-07-25 9:00 UTC (permalink / raw)
To: Andy Gross, Bjorn Andersson, Konrad Dybcio, Mathieu Poirier,
Rob Herring, Krzysztof Kozlowski, Conor Dooley,
Manivannan Sadhasivam
Cc: Marijn Suijten, linux-arm-msm, linux-remoteproc, devicetree,
linux-kernel, Krzysztof Kozlowski
Resending as the previous revision was mostly ignored on the rproc side.
Changes since v3:
- Pick up krzk's rb on bindings
- Drop patch 4 (applied)
Link to v3: https://lore.kernel.org/linux-arm-msm/20230109135647.339224-1-konrad.dybcio@linaro.org/
This revision merges two [1] [2] previously separate series,
adding SM6375's ADSP, CDSP, MPSS and related bindings.
[1] https://lore.kernel.org/linux-arm-msm/20230107120623.1903056-1-konrad.dybcio@linaro.org/T/#m89d629bd788593dfd27e4dbf0cf0bf94ffd0a7ce
[2] https://lore.kernel.org/linux-arm-msm/622afd8b-a469-4c95-d2b8-030e47b0cac2@linaro.org/T/#m17aee8f3a51cfbd3f92fe2b4dd48b3722a6a0a7e
Konrad Dybcio (4):
dt-bindings: remoteproc: qcom,sm6375-pas: Document remoteprocs
remoteproc: qcom: pas: Add SM6375 ADSP & CDSP
remoteproc: qcom: pas: Add SM6375 MPSS
arm64: dts: qcom: sm6375: Add missing power-domain-named to CDSP
.../bindings/remoteproc/qcom,sm6375-pas.yaml | 137 ++++++++++++++++++
arch/arm64/boot/dts/qcom/sm6375.dtsi | 1 +
drivers/remoteproc/qcom_q6v5_pas.c | 18 +++
3 files changed, 156 insertions(+)
create mode 100644 Documentation/devicetree/bindings/remoteproc/qcom,sm6375-pas.yaml
--
2.39.0
---
Konrad Dybcio (3):
dt-bindings: remoteproc: qcom,sm6375-pas: Document remoteprocs
remoteproc: qcom: pas: Add SM6375 ADSP & CDSP
remoteproc: qcom: pas: Add SM6375 MPSS
.../bindings/remoteproc/qcom,sm6375-pas.yaml | 137 +++++++++++++++++++++
drivers/remoteproc/qcom_q6v5_pas.c | 18 +++
2 files changed, 155 insertions(+)
---
base-commit: 1e25dd7772483f477f79986d956028e9f47f990a
change-id: 20230725-topic-6375_rproc-4f074a92fa5f
Best regards,
--
Konrad Dybcio <konrad.dybcio@linaro.org>
^ permalink raw reply [flat|nested] 6+ messages in thread
* [PATCH v4 1/3] dt-bindings: remoteproc: qcom,sm6375-pas: Document remoteprocs
2023-07-25 9:00 [PATCH v4 0/3] SM6375 remoteprocs Konrad Dybcio
@ 2023-07-25 9:00 ` Konrad Dybcio
2023-07-25 9:27 ` Rob Herring
2023-07-25 9:00 ` [PATCH v4 2/3] remoteproc: qcom: pas: Add SM6375 ADSP & CDSP Konrad Dybcio
2023-07-25 9:00 ` [PATCH v4 3/3] remoteproc: qcom: pas: Add SM6375 MPSS Konrad Dybcio
2 siblings, 1 reply; 6+ messages in thread
From: Konrad Dybcio @ 2023-07-25 9:00 UTC (permalink / raw)
To: Andy Gross, Bjorn Andersson, Konrad Dybcio, Mathieu Poirier,
Rob Herring, Krzysztof Kozlowski, Conor Dooley,
Manivannan Sadhasivam
Cc: Marijn Suijten, linux-arm-msm, linux-remoteproc, devicetree,
linux-kernel, Krzysztof Kozlowski
SM6375 hosts an ADSP, CDSP and modem as remote processors. Create
related bindings.
Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Signed-off-by: Konrad Dybcio <konrad.dybcio@linaro.org>
---
.../bindings/remoteproc/qcom,sm6375-pas.yaml | 137 +++++++++++++++++++++
1 file changed, 137 insertions(+)
diff --git a/Documentation/devicetree/bindings/remoteproc/qcom,sm6375-pas.yaml b/Documentation/devicetree/bindings/remoteproc/qcom,sm6375-pas.yaml
new file mode 100644
index 000000000000..60ee3fc7ab5b
--- /dev/null
+++ b/Documentation/devicetree/bindings/remoteproc/qcom,sm6375-pas.yaml
@@ -0,0 +1,137 @@
+# SPDX-License-Identifier: GPL-2.0 OR BSD-2-Clause
+%YAML 1.2
+---
+$id: http://devicetree.org/schemas/remoteproc/qcom,sm6375-pas.yaml#
+$schema: http://devicetree.org/meta-schemas/core.yaml#
+
+title: Qualcomm SM6375 Peripheral Authentication Service
+
+maintainers:
+ - Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>
+
+description:
+ Qualcomm SM6375 SoC Peripheral Authentication Service loads and boots
+ firmware on the Qualcomm DSP Hexagon cores.
+
+properties:
+ compatible:
+ enum:
+ - qcom,sm6375-adsp-pas
+ - qcom,sm6375-cdsp-pas
+ - qcom,sm6375-mpss-pas
+
+ reg:
+ maxItems: 1
+
+ clocks:
+ items:
+ - description: XO clock
+
+ clock-names:
+ items:
+ - const: xo
+
+ smd-edge: false
+
+required:
+ - compatible
+ - reg
+
+allOf:
+ - $ref: /schemas/remoteproc/qcom,pas-common.yaml#
+ - if:
+ properties:
+ compatible:
+ enum:
+ - qcom,sm6375-adsp-pas
+ - qcom,sm6375-cdsp-pas
+ then:
+ properties:
+ interrupts:
+ maxItems: 5
+ interrupt-names:
+ maxItems: 5
+ else:
+ properties:
+ interrupts:
+ minItems: 6
+ interrupt-names:
+ minItems: 6
+
+ - if:
+ properties:
+ compatible:
+ enum:
+ - qcom,sm6375-adsp-pas
+ then:
+ properties:
+ power-domains:
+ items:
+ - description: LCX power domain
+ - description: LMX power domain
+ power-domain-names:
+ items:
+ - const: lcx
+ - const: lmx
+
+ - if:
+ properties:
+ compatible:
+ enum:
+ - qcom,sm6375-cdsp-pas
+ - qcom,sm6375-mpss-pas
+ then:
+ properties:
+ power-domains:
+ items:
+ - description: CX power domain
+ power-domain-names:
+ items:
+ - const: cx
+
+unevaluatedProperties: false
+
+examples:
+ - |
+ #include <dt-bindings/clock/qcom,rpmcc.h>
+ #include <dt-bindings/interrupt-controller/arm-gic.h>
+ #include <dt-bindings/mailbox/qcom-ipcc.h>
+ #include <dt-bindings/power/qcom-rpmpd.h>
+
+ remoteproc_adsp: remoteproc@a400000 {
+ compatible = "qcom,sm6375-adsp-pas";
+ reg = <0x0a400000 0x100>;
+
+ interrupts-extended = <&intc GIC_SPI 282 IRQ_TYPE_LEVEL_HIGH>,
+ <&smp2p_adsp_in 0 IRQ_TYPE_EDGE_RISING>,
+ <&smp2p_adsp_in 1 IRQ_TYPE_EDGE_RISING>,
+ <&smp2p_adsp_in 2 IRQ_TYPE_EDGE_RISING>,
+ <&smp2p_adsp_in 3 IRQ_TYPE_EDGE_RISING>;
+ interrupt-names = "wdog", "fatal", "ready",
+ "handover", "stop-ack";
+
+ clocks = <&rpmcc RPM_SMD_XO_CLK_SRC>;
+ clock-names = "xo";
+
+ power-domains = <&rpmpd SM6375_VDD_LPI_CX>,
+ <&rpmpd SM6375_VDD_LPI_MX>;
+ power-domain-names = "lcx", "lmx";
+
+ memory-region = <&pil_adsp_mem>;
+
+ qcom,smem-states = <&smp2p_adsp_out 0>;
+ qcom,smem-state-names = "stop";
+
+ glink-edge {
+ interrupts-extended = <&ipcc IPCC_CLIENT_LPASS
+ IPCC_MPROC_SIGNAL_GLINK_QMP
+ IRQ_TYPE_EDGE_RISING>;
+ mboxes = <&ipcc IPCC_CLIENT_LPASS
+ IPCC_MPROC_SIGNAL_GLINK_QMP>;
+
+ label = "lpass";
+ qcom,remote-pid = <2>;
+
+ /* ... */
+ };
+ };
--
2.41.0
^ permalink raw reply related [flat|nested] 6+ messages in thread
* [PATCH v4 2/3] remoteproc: qcom: pas: Add SM6375 ADSP & CDSP
2023-07-25 9:00 [PATCH v4 0/3] SM6375 remoteprocs Konrad Dybcio
2023-07-25 9:00 ` [PATCH v4 1/3] dt-bindings: remoteproc: qcom,sm6375-pas: Document remoteprocs Konrad Dybcio
@ 2023-07-25 9:00 ` Konrad Dybcio
2023-07-25 9:00 ` [PATCH v4 3/3] remoteproc: qcom: pas: Add SM6375 MPSS Konrad Dybcio
2 siblings, 0 replies; 6+ messages in thread
From: Konrad Dybcio @ 2023-07-25 9:00 UTC (permalink / raw)
To: Andy Gross, Bjorn Andersson, Konrad Dybcio, Mathieu Poirier,
Rob Herring, Krzysztof Kozlowski, Conor Dooley,
Manivannan Sadhasivam
Cc: Marijn Suijten, linux-arm-msm, linux-remoteproc, devicetree,
linux-kernel
Add a config for the ADSP&CDSP present on SM6375.
Signed-off-by: Konrad Dybcio <konrad.dybcio@linaro.org>
---
drivers/remoteproc/qcom_q6v5_pas.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/drivers/remoteproc/qcom_q6v5_pas.c b/drivers/remoteproc/qcom_q6v5_pas.c
index b5447dd2dd35..0d58b5be9a77 100644
--- a/drivers/remoteproc/qcom_q6v5_pas.c
+++ b/drivers/remoteproc/qcom_q6v5_pas.c
@@ -1180,6 +1180,8 @@ static const struct of_device_id adsp_of_match[] = {
{ .compatible = "qcom,sm6350-adsp-pas", .data = &sm6350_adsp_resource},
{ .compatible = "qcom,sm6350-cdsp-pas", .data = &sm6350_cdsp_resource},
{ .compatible = "qcom,sm6350-mpss-pas", .data = &mpss_resource_init},
+ { .compatible = "qcom,sm6375-adsp-pas", .data = &sm6350_adsp_resource},
+ { .compatible = "qcom,sm6375-cdsp-pas", .data = &sm8150_cdsp_resource},
{ .compatible = "qcom,sm8150-adsp-pas", .data = &sm8150_adsp_resource},
{ .compatible = "qcom,sm8150-cdsp-pas", .data = &sm8150_cdsp_resource},
{ .compatible = "qcom,sm8150-mpss-pas", .data = &mpss_resource_init},
--
2.41.0
^ permalink raw reply related [flat|nested] 6+ messages in thread
* [PATCH v4 3/3] remoteproc: qcom: pas: Add SM6375 MPSS
2023-07-25 9:00 [PATCH v4 0/3] SM6375 remoteprocs Konrad Dybcio
2023-07-25 9:00 ` [PATCH v4 1/3] dt-bindings: remoteproc: qcom,sm6375-pas: Document remoteprocs Konrad Dybcio
2023-07-25 9:00 ` [PATCH v4 2/3] remoteproc: qcom: pas: Add SM6375 ADSP & CDSP Konrad Dybcio
@ 2023-07-25 9:00 ` Konrad Dybcio
2 siblings, 0 replies; 6+ messages in thread
From: Konrad Dybcio @ 2023-07-25 9:00 UTC (permalink / raw)
To: Andy Gross, Bjorn Andersson, Konrad Dybcio, Mathieu Poirier,
Rob Herring, Krzysztof Kozlowski, Conor Dooley,
Manivannan Sadhasivam
Cc: Marijn Suijten, linux-arm-msm, linux-remoteproc, devicetree,
linux-kernel
Add a config for the MPSS present on SM6375.
Signed-off-by: Konrad Dybcio <konrad.dybcio@linaro.org>
---
drivers/remoteproc/qcom_q6v5_pas.c | 16 ++++++++++++++++
1 file changed, 16 insertions(+)
diff --git a/drivers/remoteproc/qcom_q6v5_pas.c b/drivers/remoteproc/qcom_q6v5_pas.c
index 0d58b5be9a77..1c87ae9cec9e 100644
--- a/drivers/remoteproc/qcom_q6v5_pas.c
+++ b/drivers/remoteproc/qcom_q6v5_pas.c
@@ -813,6 +813,21 @@ static const struct adsp_data sm6350_adsp_resource = {
.ssctl_id = 0x14,
};
+static const struct adsp_data sm6375_mpss_resource = {
+ .crash_reason_smem = 421,
+ .firmware_name = "modem.mdt",
+ .pas_id = 4,
+ .minidump_id = 3,
+ .auto_boot = false,
+ .proxy_pd_names = (char*[]){
+ "cx",
+ NULL
+ },
+ .ssr_name = "mpss",
+ .sysmon_name = "modem",
+ .ssctl_id = 0x12,
+};
+
static const struct adsp_data sm8150_adsp_resource = {
.crash_reason_smem = 423,
.firmware_name = "adsp.mdt",
@@ -1182,6 +1197,7 @@ static const struct of_device_id adsp_of_match[] = {
{ .compatible = "qcom,sm6350-mpss-pas", .data = &mpss_resource_init},
{ .compatible = "qcom,sm6375-adsp-pas", .data = &sm6350_adsp_resource},
{ .compatible = "qcom,sm6375-cdsp-pas", .data = &sm8150_cdsp_resource},
+ { .compatible = "qcom,sm6375-mpss-pas", .data = &sm6375_mpss_resource},
{ .compatible = "qcom,sm8150-adsp-pas", .data = &sm8150_adsp_resource},
{ .compatible = "qcom,sm8150-cdsp-pas", .data = &sm8150_cdsp_resource},
{ .compatible = "qcom,sm8150-mpss-pas", .data = &mpss_resource_init},
--
2.41.0
^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [PATCH v4 1/3] dt-bindings: remoteproc: qcom,sm6375-pas: Document remoteprocs
2023-07-25 9:00 ` [PATCH v4 1/3] dt-bindings: remoteproc: qcom,sm6375-pas: Document remoteprocs Konrad Dybcio
@ 2023-07-25 9:27 ` Rob Herring
2023-07-26 17:17 ` Krzysztof Kozlowski
0 siblings, 1 reply; 6+ messages in thread
From: Rob Herring @ 2023-07-25 9:27 UTC (permalink / raw)
To: Konrad Dybcio
Cc: Rob Herring, devicetree, linux-arm-msm, Marijn Suijten,
linux-kernel, Krzysztof Kozlowski, Krzysztof Kozlowski,
Andy Gross, Manivannan Sadhasivam, Mathieu Poirier,
linux-remoteproc, Conor Dooley, Bjorn Andersson
On Tue, 25 Jul 2023 11:00:28 +0200, Konrad Dybcio wrote:
> SM6375 hosts an ADSP, CDSP and modem as remote processors. Create
> related bindings.
>
> Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
> Signed-off-by: Konrad Dybcio <konrad.dybcio@linaro.org>
> ---
> .../bindings/remoteproc/qcom,sm6375-pas.yaml | 137 +++++++++++++++++++++
> 1 file changed, 137 insertions(+)
>
My bot found errors running 'make DT_CHECKER_FLAGS=-m dt_binding_check'
on your patch (DT_CHECKER_FLAGS is new in v5.13):
yamllint warnings/errors:
dtschema/dtc warnings/errors:
/builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/remoteproc/qcom,sm6375-pas.example.dtb: remoteproc@a400000: Unevaluated properties are not allowed ('memory-region' was unexpected)
from schema $id: http://devicetree.org/schemas/remoteproc/qcom,sm6375-pas.yaml#
doc reference errors (make refcheckdocs):
See https://patchwork.ozlabs.org/project/devicetree-bindings/patch/20230725-topic-6375_rproc-v4-1-d55e8a6d0f5f@linaro.org
The base for the series is generally the latest rc1. A different dependency
should be noted in *this* patch.
If you already ran 'make dt_binding_check' and didn't see the above
error(s), then make sure 'yamllint' is installed and dt-schema is up to
date:
pip3 install dtschema --upgrade
Please check and re-submit after running the above command yourself. Note
that DT_SCHEMA_FILES can be set to your schema file to speed up checking
your schema. However, it must be unset to test all examples with your schema.
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH v4 1/3] dt-bindings: remoteproc: qcom,sm6375-pas: Document remoteprocs
2023-07-25 9:27 ` Rob Herring
@ 2023-07-26 17:17 ` Krzysztof Kozlowski
0 siblings, 0 replies; 6+ messages in thread
From: Krzysztof Kozlowski @ 2023-07-26 17:17 UTC (permalink / raw)
To: Rob Herring, Konrad Dybcio
Cc: Rob Herring, devicetree, linux-arm-msm, Marijn Suijten,
linux-kernel, Krzysztof Kozlowski, Andy Gross,
Manivannan Sadhasivam, Mathieu Poirier, linux-remoteproc,
Conor Dooley, Bjorn Andersson
On 25/07/2023 11:27, Rob Herring wrote:
>
> On Tue, 25 Jul 2023 11:00:28 +0200, Konrad Dybcio wrote:
>> SM6375 hosts an ADSP, CDSP and modem as remote processors. Create
>> related bindings.
>>
>> Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
>> Signed-off-by: Konrad Dybcio <konrad.dybcio@linaro.org>
>> ---
>> .../bindings/remoteproc/qcom,sm6375-pas.yaml | 137 +++++++++++++++++++++
>> 1 file changed, 137 insertions(+)
>>
>
> My bot found errors running 'make DT_CHECKER_FLAGS=-m dt_binding_check'
> on your patch (DT_CHECKER_FLAGS is new in v5.13):
>
> yamllint warnings/errors:
>
> dtschema/dtc warnings/errors:
> /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/remoteproc/qcom,sm6375-pas.example.dtb: remoteproc@a400000: Unevaluated properties are not allowed ('memory-region' was unexpected)
> from schema $id: http://devicetree.org/schemas/remoteproc/qcom,sm6375-pas.yaml#
>
This needs fixing.
Best regards,
Krzysztof
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2023-07-26 17:18 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-07-25 9:00 [PATCH v4 0/3] SM6375 remoteprocs Konrad Dybcio
2023-07-25 9:00 ` [PATCH v4 1/3] dt-bindings: remoteproc: qcom,sm6375-pas: Document remoteprocs Konrad Dybcio
2023-07-25 9:27 ` Rob Herring
2023-07-26 17:17 ` Krzysztof Kozlowski
2023-07-25 9:00 ` [PATCH v4 2/3] remoteproc: qcom: pas: Add SM6375 ADSP & CDSP Konrad Dybcio
2023-07-25 9:00 ` [PATCH v4 3/3] remoteproc: qcom: pas: Add SM6375 MPSS Konrad Dybcio
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).