From: "Heiko Stübner" <heiko@sntech.de>
To: Peter Geis <pgwipeout@gmail.com>
Cc: linux-kernel@vger.kernel.org,
Javier Martinez Canillas <javierm@redhat.com>,
Peter Robinson <pbrobinson@gmail.com>,
Caleb Connolly <kc@postmarketos.org>,
Jarrah Gosbell <kernel@undef.tools>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Martijn Braam <martijn@brixit.nl>, Ondrej Jirman <megi@xff.cz>,
Rob Herring <robh+dt@kernel.org>,
Tom Fitzhenry <tom@tom-fitzhenry.me.uk>,
devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-rockchip@lists.infradead.org
Subject: Re: [PATCH] arm64: dts: rockchip: Change serial baud rate for Pinephone Pro to 1.5 MB
Date: Tue, 04 Apr 2023 18:55:17 +0200 [thread overview]
Message-ID: <3999080.iIbC2pHGDl@diego> (raw)
In-Reply-To: <CAMdYzYqT=vVZxFK=P6xYDAht_KWk3CTsTtruPAbGqx1K9EcJsQ@mail.gmail.com>
Hi Peter,
Am Dienstag, 4. April 2023, 14:52:02 CEST schrieb Peter Geis:
> On Tue, Apr 4, 2023 at 3:55 AM Heiko Stübner <heiko@sntech.de> wrote:
> >
> > Hi,
> >
> > Am Montag, 3. April 2023, 19:59:37 CEST schrieb Javier Martinez Canillas:
> > > This baud rate is set for the device by mainline u-boot and is also what
> > > is set in the Pinebook Pro Device Tree, which is a device similar to the
> > > PinePhone Pro but with a different form factor.
> > >
> > > Otherwise, the baud rate of the firmware and Linux don't match by default
> > > and a 'console=ttyS2,1500000n8' kernel command line parameter is required
> > > to have proper output for both.
> >
> > The interesting question is always if this will break someone else's setup.
> > I've never really understood the strange setting of 1.5MBps, but on the
> > other hand it _is_ a reality on most boards.
> The 1.5M baud is default because the clock structure on rockchip
> devices does not allow a clean 115200 baud. By attempting to force
> 115200, it will always be slightly off (either low or high depending
> on how the driver decided to round). If this actually causes any
> problems is the subject of much debate.
thanks so much for this piece of clock-detail. As I wrote, I never really
understood the why _before_ but also never cared that much to dive
into it and find out.
So your explanation closes one knowledge gap in my head.
Thanks a lot :-)
Heiko
next prev parent reply other threads:[~2023-04-04 16:55 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-04-03 17:59 [PATCH] arm64: dts: rockchip: Change serial baud rate for Pinephone Pro to 1.5 MB Javier Martinez Canillas
2023-04-04 7:51 ` Heiko Stübner
2023-04-04 8:08 ` Javier Martinez Canillas
2023-04-04 8:13 ` Jarrah
2023-04-04 8:18 ` Peter Robinson
2023-04-04 8:25 ` Javier Martinez Canillas
2023-04-04 8:24 ` Javier Martinez Canillas
2023-04-04 8:38 ` Peter Robinson
2023-04-04 8:46 ` Javier Martinez Canillas
2023-04-04 11:31 ` Martijn Braam
2023-04-04 11:42 ` Javier Martinez Canillas
2023-04-04 12:02 ` Ondřej Jirman
2023-04-04 12:36 ` Ondřej Jirman
2023-04-04 14:04 ` Javier Martinez Canillas
2023-04-04 15:40 ` Ondřej Jirman
2023-04-04 12:52 ` Peter Geis
2023-04-04 16:55 ` Heiko Stübner [this message]
2023-04-18 12:11 ` Javier Martinez Canillas
2023-04-18 14:26 ` Heiko Stübner
2023-07-21 23:06 ` Javier Martinez Canillas
2023-07-28 18:59 ` Heiko Stuebner
2023-07-28 19:55 ` Maya Matuszczyk
2023-07-28 23:05 ` Javier Martinez Canillas
2023-07-28 20:10 ` Ondřej Jirman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3999080.iIbC2pHGDl@diego \
--to=heiko@sntech.de \
--cc=devicetree@vger.kernel.org \
--cc=javierm@redhat.com \
--cc=kc@postmarketos.org \
--cc=kernel@undef.tools \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rockchip@lists.infradead.org \
--cc=martijn@brixit.nl \
--cc=megi@xff.cz \
--cc=pbrobinson@gmail.com \
--cc=pgwipeout@gmail.com \
--cc=robh+dt@kernel.org \
--cc=tom@tom-fitzhenry.me.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).