From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.3 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A3739C43460 for ; Mon, 26 Apr 2021 18:07:14 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 7886660725 for ; Mon, 26 Apr 2021 18:07:14 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234497AbhDZSHz (ORCPT ); Mon, 26 Apr 2021 14:07:55 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:39430 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234432AbhDZSHT (ORCPT ); Mon, 26 Apr 2021 14:07:19 -0400 Received: from mail-wr1-x430.google.com (mail-wr1-x430.google.com [IPv6:2a00:1450:4864:20::430]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 0340FC061574 for ; Mon, 26 Apr 2021 11:06:37 -0700 (PDT) Received: by mail-wr1-x430.google.com with SMTP id l2so4496083wrm.9 for ; Mon, 26 Apr 2021 11:06:36 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=baylibre-com.20150623.gappssmtp.com; s=20150623; h=subject:to:cc:references:from:organization:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=z/Kwipu1y6TOCAmGCH4eBv1sqy5s6UK9+gQOmGBdFDo=; b=tFAA8OM1OMnP4mVo1BUP3TdeKSXg/EB0WafYRtzUUiTKjsWUSQ3QroqS/dybgZJz5x 0uistVBTmvOSdV/sjTYDOP5Va1MmX7/WqO0JJj+tBOPk5GLQHczf9D8P5whtygJ67rTY Xn1LpQA4AeN6syvVSQIdFiCAapyOmzrQqelxryNExRsNAUxIlqXMJwYj+ns6o5CwHKK2 ylC+cLMlFFWQrWOfS5pjYnUnB/NhnEYOL62/OL4tMLc0yPxaXghMMP4NPRf4+0vQdGOq o/LMILSLqmJbvcyuMj+8GgtaWJZ/8VgNqAKdegca6JMGKy9kxT/rfUr+s3QipNmawIWl iCfQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:organization :message-id:date:user-agent:mime-version:in-reply-to :content-language:content-transfer-encoding; bh=z/Kwipu1y6TOCAmGCH4eBv1sqy5s6UK9+gQOmGBdFDo=; b=GwxjFEON6b53GLBs0kXYhQGKU6qVn13Z9gHkRaoJJSyH2i9RAo08ZLhEvXIrbfy9Ae u/Na/yt7th3aahDbULN69ZOGFnLyz9gvF9rNna0Pif1HtDokAk0rQKGufR6gTdnUzLKY eSVm+WzzvzzCWfk6rrNvsfxWHLg7v3Z/pZEuYdBHwTnI+7zbtH9P9dEUzqWdYuHQXO6X Ayb1PI9UkEhXGmNOvnehjVXnPBIWvfCA99D0Zm8SdyKA0+qzYxzHN0SwRw9SDdUT1w8l h69RKNNeD5pYnfIvr09E79ClMlPgKsB34LZx1v0bQGUgHGer1DB/QKp6tlumPkFCkfG9 kk3A== X-Gm-Message-State: AOAM533b2H1FlD/S9wiiRmQBpv9hbN1U4QZFSODIz1R16Vz1zCDvJ8Ut zn32TZchSF8BZBGT9FOYDZ5qOg== X-Google-Smtp-Source: ABdhPJzgk2IzpTkyCjHJ4GcBEEoXLGQijoX+9t+CrvlLufNwU/zLqVZ2i9U0e2ub5m3mdqW1C5Dt0g== X-Received: by 2002:a5d:590a:: with SMTP id v10mr24510931wrd.306.1619460395637; Mon, 26 Apr 2021 11:06:35 -0700 (PDT) Received: from ?IPv6:2a01:e0a:90c:e290:b76e:7362:77c0:ddc3? ([2a01:e0a:90c:e290:b76e:7362:77c0:ddc3]) by smtp.gmail.com with ESMTPSA id a9sm276663wmj.1.2021.04.26.11.06.32 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 26 Apr 2021 11:06:33 -0700 (PDT) Subject: Re: [PATCH v2 1/3] dt-bindings: serial: amlogic,meson-uart: add fifo-size property To: Rob Herring Cc: devicetree@vger.kernel.org, linux-serial@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-amlogic@lists.infradead.org, linux-kernel@vger.kernel.org, Martin Blumenstingl , gregkh@linuxfoundation.org References: <20210325152410.1795557-1-narmstrong@baylibre.com> <20210325152410.1795557-2-narmstrong@baylibre.com> From: Neil Armstrong Organization: Baylibre Message-ID: <39c92a23-e009-6bc2-a20b-9b0ab3e01c75@baylibre.com> Date: Mon, 26 Apr 2021 20:06:31 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.7.1 MIME-Version: 1.0 In-Reply-To: <20210325152410.1795557-2-narmstrong@baylibre.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org Hi Rob, On 25/03/2021 16:24, Neil Armstrong wrote: > On most of the Amlogic SoCs, the first UART controller in the "Everything-Else" > power domain has 128bytes of RX & TX FIFO, so add an optional property to describe > a different FIFO size from the other ports (64bytes). > > Signed-off-by: Neil Armstrong > Reviewed-by: Martin Blumenstingl > --- > .../devicetree/bindings/serial/amlogic,meson-uart.yaml | 6 ++++++ > 1 file changed, 6 insertions(+) > > diff --git a/Documentation/devicetree/bindings/serial/amlogic,meson-uart.yaml b/Documentation/devicetree/bindings/serial/amlogic,meson-uart.yaml > index 75ebc9952a99..8ece7f420c19 100644 > --- a/Documentation/devicetree/bindings/serial/amlogic,meson-uart.yaml > +++ b/Documentation/devicetree/bindings/serial/amlogic,meson-uart.yaml > @@ -55,6 +55,12 @@ properties: > - const: pclk > - const: baud > > + > + fifo-size: > + description: The fifo size supported by the UART channel. > + $ref: /schemas/types.yaml#/definitions/uint32 > + enum: [64, 128] > + > required: > - compatible > - reg > Is it ok with the generic fifo-size property ? Neil