From: Dan Murphy <dmurphy@ti.com>
To: Mark Brown <broonie@kernel.org>
Cc: <lgirdwood@gmail.com>, <tiwai@suse.com>, <robh+dt@kernel.org>,
<devicetree@vger.kernel.org>, <alsa-devel@alsa-project.org>,
<linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 4/6] dt-bindings: tas2770: Remove ti,asi-format property
Date: Wed, 23 Sep 2020 11:11:05 -0500 [thread overview]
Message-ID: <39d966c4-2f56-c004-4e7c-24a99b07cc72@ti.com> (raw)
In-Reply-To: <20200923155145.GD5707@sirena.org.uk>
Mark
On 9/23/20 10:51 AM, Mark Brown wrote:
> On Wed, Sep 23, 2020 at 08:25:58AM -0500, Dan Murphy wrote:
>> Remove the property ti,asi-format as the driver only reads this property
>> and performs no action against it.
> We should probably leave the property as documented and move it to
> deprecated rather than delete the documentation entirely.
I mulled this over to just deprecate the property and I know removing
these ABIs are not highly accepted.
But the support code for it was incomplete and if a user had it
populated in the DT and we removed the support then there will be no
functional change.
This property was supposed to set the RX edge SBCLK detection but this
is done based on the dai format.
So removing the property will have no affect on the users.
Dan
next prev parent reply other threads:[~2020-09-23 16:11 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-23 13:25 [PATCH 1/6] dt-bindings: tas2770: Add shutdown gpio property Dan Murphy
2020-09-23 13:25 ` [PATCH 2/6] ASoC: tas2770: Add shutdown capability via a GPIO Dan Murphy
2020-09-23 13:25 ` [PATCH 3/6] ASoC: tas2770: Set regcache when shutting down and waking device Dan Murphy
2020-09-23 13:25 ` [PATCH 4/6] dt-bindings: tas2770: Remove ti,asi-format property Dan Murphy
2020-09-23 15:51 ` Mark Brown
2020-09-23 16:11 ` Dan Murphy [this message]
2020-09-23 13:25 ` [PATCH 5/6] ASoC: tas2770: Remove ti,asi-format code Dan Murphy
2020-09-23 13:26 ` [PATCH 6/6] ASoC: tas2770: Remove unused variables Dan Murphy
2020-09-23 19:00 ` [PATCH 1/6] dt-bindings: tas2770: Add shutdown gpio property Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=39d966c4-2f56-c004-4e7c-24a99b07cc72@ti.com \
--to=dmurphy@ti.com \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=robh+dt@kernel.org \
--cc=tiwai@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).