From: Philippe CORNU <philippe.cornu@st.com>
To: Olivier MOYSAN <olivier.moysan@st.com>,
"a.hajda@samsung.com" <a.hajda@samsung.com>,
"narmstrong@baylibre.com" <narmstrong@baylibre.com>,
"Laurent.pinchart@ideasonboard.com"
<Laurent.pinchart@ideasonboard.com>,
"jonas@kwiboo.se" <jonas@kwiboo.se>,
"jernej.skrabec@siol.net" <jernej.skrabec@siol.net>,
"airlied@linux.ie" <airlied@linux.ie>,
"daniel@ffwll.ch" <daniel@ffwll.ch>,
"dri-devel@lists.freedesktop.org"
<dri-devel@lists.freedesktop.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
Benjamin GAIGNARD <benjamin.gaignard@st.com>,
Alexandre TORGUE <alexandre.torgue@st.com>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>,
"linux-stm32@st-md-mailman.stormreply.com"
<linux-stm32@st-md-mailman.stormreply.com>,
"jsarha@ti.com" <jsarha@ti.com>,
"robh+dt@kernel.org" <robh+dt@kernel.org>,
"mark.rutland@arm.com" <mark.rutland@arm>
Subject: Re: [PATCH 1/3] drm/bridge: sii902x: fix missing reference to mclk clock
Date: Fri, 5 Jul 2019 12:24:02 +0000 [thread overview]
Message-ID: <39d9bf8f-a906-7f69-582d-b2996e600c0f@st.com> (raw)
In-Reply-To: <1562082426-14876-2-git-send-email-olivier.moysan@st.com>
Hi Olivier,
and many thanks for your patch.
I do not see how audio could work without your patch, so:
Reviewed-by: Philippe Cornu <philippe.cornu@st.com>
Philippe :-)
On 7/2/19 5:47 PM, Olivier Moysan wrote:
> Add devm_clk_get call to retrieve reference to master clock.
>
> Fixes: ff5781634c41 ("drm/bridge: sii902x: Implement HDMI audio support")
>
> Signed-off-by: Olivier Moysan <olivier.moysan@st.com>
> ---
> drivers/gpu/drm/bridge/sii902x.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/gpu/drm/bridge/sii902x.c b/drivers/gpu/drm/bridge/sii902x.c
> index dd7aa466b280..36acc256e67e 100644
> --- a/drivers/gpu/drm/bridge/sii902x.c
> +++ b/drivers/gpu/drm/bridge/sii902x.c
> @@ -750,6 +750,7 @@ static int sii902x_audio_codec_init(struct sii902x *sii902x,
> sii902x->audio.i2s_fifo_sequence[i] |= audio_fifo_id[i] |
> i2s_lane_id[lanes[i]] | SII902X_TPI_I2S_FIFO_ENABLE;
>
> + sii902x->audio.mclk = devm_clk_get(dev, "mclk");
> if (IS_ERR(sii902x->audio.mclk)) {
> dev_err(dev, "%s: No clock (audio mclk) found: %ld\n",
> __func__, PTR_ERR(sii902x->audio.mclk));
>
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
next prev parent reply other threads:[~2019-07-05 12:24 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-02 15:47 [PATCH 0/3] drm/bridge: sii902x: fix audio mclk management Olivier Moysan
2019-07-02 15:47 ` [PATCH 1/3] drm/bridge: sii902x: fix missing reference to mclk clock Olivier Moysan
2019-07-04 8:03 ` Jyri Sarha
2019-07-05 12:24 ` Philippe CORNU [this message]
2019-07-12 10:31 ` Andrzej Hajda
2019-07-02 15:47 ` [PATCH 2/3] dt-bindings: display: sii902x: Change audio mclk binding Olivier Moysan
2019-07-04 8:25 ` Jyri Sarha
2019-07-05 12:35 ` Philippe CORNU
2019-07-12 10:31 ` Andrzej Hajda
2019-07-02 15:47 ` [PATCH 3/3] drm/bridge: sii902x: make audio mclk optional Olivier Moysan
2019-07-04 8:29 ` Jyri Sarha
2019-07-05 12:36 ` Philippe CORNU
2019-07-12 10:45 ` Andrzej Hajda
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=39d9bf8f-a906-7f69-582d-b2996e600c0f@st.com \
--to=philippe.cornu@st.com \
--cc=Laurent.pinchart@ideasonboard.com \
--cc=a.hajda@samsung.com \
--cc=airlied@linux.ie \
--cc=alexandre.torgue@st.com \
--cc=benjamin.gaignard@st.com \
--cc=daniel@ffwll.ch \
--cc=dri-devel@lists.freedesktop.org \
--cc=jernej.skrabec@siol.net \
--cc=jonas@kwiboo.se \
--cc=jsarha@ti.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-stm32@st-md-mailman.stormreply.com \
--cc=mark.rutland@arm \
--cc=narmstrong@baylibre.com \
--cc=olivier.moysan@st.com \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).