From: Krzysztof Kozlowski <krzk@kernel.org>
To: Biju Das <biju.das.jz@bp.renesas.com>,
Tommaso Merciai <tommaso.merciai.xr@bp.renesas.com>
Cc: Tommaso Merciai <tomm.merciai@gmail.com>,
"linux-renesas-soc@vger.kernel.org"
<linux-renesas-soc@vger.kernel.org>,
Fabrizio Castro <fabrizio.castro.jz@renesas.com>,
Mark Brown <broonie@kernel.org>, Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
Geert Uytterhoeven <geert+renesas@glider.be>,
"magnus.damm" <magnus.damm@gmail.com>,
Michael Turquette <mturquette@baylibre.com>,
Stephen Boyd <sboyd@kernel.org>,
"linux-spi@vger.kernel.org" <linux-spi@vger.kernel.org>,
"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"linux-clk@vger.kernel.org" <linux-clk@vger.kernel.org>
Subject: Re: [PATCH 3/5] spi: dt-bindings: renesas,rzv2h-rspi: Document RZ/G3E SoC support
Date: Wed, 4 Mar 2026 16:40:03 +0100 [thread overview]
Message-ID: <39db1990-5004-4bba-8e2b-3b5e066fccdb@kernel.org> (raw)
In-Reply-To: <TY3PR01MB113466BB56D07926CD00A8EC4867CA@TY3PR01MB11346.jpnprd01.prod.outlook.com>
On 04/03/2026 16:34, Biju Das wrote:
> Hi Krzysztof Kozlowski,
>
>> -----Original Message-----
>> From: Krzysztof Kozlowski <krzk@kernel.org>
>> Sent: 04 March 2026 15:06
>> Subject: Re: [PATCH 3/5] spi: dt-bindings: renesas,rzv2h-rspi: Document RZ/G3E SoC support
>>
>> On 18/02/2026 08:50, Krzysztof Kozlowski wrote:
>>> On Tue, Feb 17, 2026 at 05:23:47PM +0100, Tommaso Merciai wrote:
>>>> Document the RSPI controller on the Renesas RZ/G3E SoC. The block is
>>>> compatible with the RSPI implementation found on the RZ/V2H(P) family.
>>>>
>>>> Signed-off-by: Tommaso Merciai <tommaso.merciai.xr@bp.renesas.com>
>>>> ---
>>>> - This patch depend up on [0]
>>>> - [0]
>>>> https://lore.kernel.org/all/20260128215132.1353381-2-cosmin-gabriel.t
>>>> anislav.xa@renesas.com/
>>>
>>> I am not even looking there, start reviewing each other patches, so
>>> you won't be sending FIXES instead of reviews.
>>
>> You kind of ignored the problem and the other patch got merged.
>
> We prepared a patch updating the description and it is under internal review:
That's not the point. The point was that you give PUBLIC review that
mentioned patch is incomplete and must be changed.
Not prepare a follow-up patch. That's exactly my complain I raised, so
you solved nothing.
>
> This will cover any combinations.
>
> description:
> Must contain unique references to DMA specifiers, with at least one
> for transmission and one for reception. Each category may include
> multiple entries, constrained only by the total number of DMACs
> available on the SoC.
No. Solves nothing. Renesas folks were supposed to review patches
instead of letting poor code be merged to THEN develop fixes.
Best regards,
Krzysztof
next prev parent reply other threads:[~2026-03-04 15:40 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-02-17 16:23 [PATCH 0/5] Add RSPIs support for RZ/G3E SoC Tommaso Merciai
2026-02-17 16:23 ` [PATCH 1/5] clk: renesas: r9a09g047: Add entries for the RSPIs Tommaso Merciai
2026-03-18 16:03 ` Geert Uytterhoeven
2026-02-17 16:23 ` [PATCH 2/5] spi: dt-bindings: renesas,rzv2h-rspi: Document dmas property Tommaso Merciai
2026-02-17 19:13 ` Mark Brown
2026-02-18 7:47 ` Krzysztof Kozlowski
2026-03-18 16:06 ` Geert Uytterhoeven
2026-02-17 16:23 ` [PATCH 3/5] spi: dt-bindings: renesas,rzv2h-rspi: Document RZ/G3E SoC support Tommaso Merciai
2026-02-18 7:50 ` Krzysztof Kozlowski
2026-03-04 15:05 ` Krzysztof Kozlowski
2026-03-04 15:34 ` Biju Das
2026-03-04 15:40 ` Krzysztof Kozlowski [this message]
2026-03-04 15:52 ` Biju Das
2026-03-04 15:53 ` Krzysztof Kozlowski
2026-03-18 16:24 ` Geert Uytterhoeven
2026-02-17 16:23 ` [PATCH 4/5] arm64: dts: renesas: r9a09g047: Add RSPI nodes Tommaso Merciai
2026-03-20 11:14 ` Geert Uytterhoeven
2026-02-17 16:23 ` [PATCH 5/5] arm64: dts: renesas: r9a09g047e57-smarc: Enable RSPI0 Tommaso Merciai
2026-03-20 11:16 ` Geert Uytterhoeven
2026-03-18 17:39 ` (subset) [PATCH 0/5] Add RSPIs support for RZ/G3E SoC Mark Brown
2026-03-19 11:39 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=39db1990-5004-4bba-8e2b-3b5e066fccdb@kernel.org \
--to=krzk@kernel.org \
--cc=biju.das.jz@bp.renesas.com \
--cc=broonie@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=fabrizio.castro.jz@renesas.com \
--cc=geert+renesas@glider.be \
--cc=krzk+dt@kernel.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-renesas-soc@vger.kernel.org \
--cc=linux-spi@vger.kernel.org \
--cc=magnus.damm@gmail.com \
--cc=mturquette@baylibre.com \
--cc=robh@kernel.org \
--cc=sboyd@kernel.org \
--cc=tomm.merciai@gmail.com \
--cc=tommaso.merciai.xr@bp.renesas.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox