From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id CEDA511C80 for ; Wed, 18 Oct 2023 14:51:32 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="S878NAwu" Received: by smtp.kernel.org (Postfix) with ESMTPSA id E825AC433C8; Wed, 18 Oct 2023 14:51:27 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1697640692; bh=BbvjjIBqrx4LLuoNVbrW9S9bLaMwRPFS7lIkl7RjLWU=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=S878NAwuhe2zWCeS5/FbNtl7dgxsCsVjrg5yCoP67+b2sQKUEsx7TASUDFsIy7jnc NTba6lHdDtNv/X70utYTiM4x7Gp4do6IB8UZLeR0DH9Do7Eqvvt6ZnICWTosJ83zZL WQehJ1HCylF2JMYylUqxv5BnFXcGcCRH7kOAtqVcQOd6224wkOKxp6iqHEkGd3cnAM McITwjuuNDBognSWXeNRwBqN4B5WFfKMAILEAwK7RHMjb171/Hv10pUr3m1Vrf626V htgH5+bmJEF5cAo2TuXM93k/MVH7ZUAR0HH9FXDlxbgfna2E9YfvQDoOOCLE8NV05X x2r8+Vp4D5BOw== Message-ID: <39e1f40f-647a-4c3a-b070-0e504d7d3389@kernel.org> Date: Wed, 18 Oct 2023 23:51:27 +0900 Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v8 02/26] PM / devfreq: rockchip-dfi: Embed desc into private data struct Content-Language: en-US To: Sascha Hauer , linux-rockchip@lists.infradead.org Cc: linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-pm@vger.kernel.org, Heiko Stuebner , Kyungmin Park , MyungJoo Ham , Will Deacon , Mark Rutland , kernel@pengutronix.de, Michael Riesch , Robin Murphy , Vincent Legoll , Rob Herring , Krzysztof Kozlowski , Conor Dooley , devicetree@vger.kernel.org, Sebastian Reichel , Jonathan Cameron References: <20231018061714.3553817-1-s.hauer@pengutronix.de> <20231018061714.3553817-3-s.hauer@pengutronix.de> From: Chanwoo Choi In-Reply-To: <20231018061714.3553817-3-s.hauer@pengutronix.de> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 23. 10. 18. 15:16, Sascha Hauer wrote: > No need for an extra allocation, just embed the struct > devfreq_event_desc into the private data struct. > > Reviewed-by: Heiko Stuebner > Reviewed-by: Jonathan Cameron > Reviewed-by: Sebastian Reichel > Signed-off-by: Sascha Hauer > --- > drivers/devfreq/event/rockchip-dfi.c | 8 ++------ > 1 file changed, 2 insertions(+), 6 deletions(-) > > diff --git a/drivers/devfreq/event/rockchip-dfi.c b/drivers/devfreq/event/rockchip-dfi.c > index 74893c06aa087..467f9f42d38f7 100644 > --- a/drivers/devfreq/event/rockchip-dfi.c > +++ b/drivers/devfreq/event/rockchip-dfi.c > @@ -49,7 +49,7 @@ struct dmc_usage { > */ > struct rockchip_dfi { > struct devfreq_event_dev *edev; > - struct devfreq_event_desc *desc; > + struct devfreq_event_desc desc; > struct dmc_usage ch_usage[RK3399_DMC_NUM_CH]; > struct device *dev; > void __iomem *regs; > @@ -204,14 +204,10 @@ static int rockchip_dfi_probe(struct platform_device *pdev) > > data->dev = dev; > > - desc = devm_kzalloc(dev, sizeof(*desc), GFP_KERNEL); > - if (!desc) > - return -ENOMEM; > - > + desc = &data->desc; > desc->ops = &rockchip_dfi_ops; > desc->driver_data = data; > desc->name = np->name; > - data->desc = desc; > > data->edev = devm_devfreq_event_add_edev(&pdev->dev, desc); > if (IS_ERR(data->edev)) { Already applied it on v7. -- Best Regards, Samsung Electronics Chanwoo Choi