Devicetree
 help / color / mirror / Atom feed
From: Krzysztof Kozlowski <krzk@kernel.org>
To: Baihui Liang <liangbaihui@linux.spacemit.com>
Cc: "frank.binns" <frank.binns@imgtec.com>, robh <robh@kernel.org>,
	krzk+dt <krzk+dt@kernel.org>, conor+dt <conor+dt@kernel.org>,
	dlan <dlan@kernel.org>,
	dri-devel <dri-devel@lists.freedesktop.org>,
	devicetree <devicetree@vger.kernel.org>,
	linux-kernel <linux-kernel@vger.kernel.org>,
	linux-riscv <linux-riscv@lists.infradead.org>,
	spacemit <spacemit@lists.linux.dev>
Subject: Re: [PATCH v3 1/2] dt-bindings: gpu: img,powervr-rogue: add spacemit,k3-gpu
Date: Wed, 29 Jul 2026 11:16:58 +0200	[thread overview]
Message-ID: <39f12852-a0d4-4d90-8ea3-dbfa7e1c2059@kernel.org> (raw)
In-Reply-To: <DKAXV3CTQ6B1.36715CJUMEB9A@linux.spacemit.com>

On 29/07/2026 11:14, Baihui Liang wrote:
> On Wed Jul 29, 2026 at 3:57 PM CST, Krzysztof Kozlowski wrote:
>> On 29/07/2026 09:46, Baihui Liang wrote:
>>> On Tue, Jul 28, 2026, Krzysztof Kozlowski wrote:
>>> &gt; &gt; [...]
>>> &gt; &gt; spacemit,k3-gpu is added to the existing ti,am62-gpu/ti,am62p-gpu/
>>> &gt; &gt; ti,j721s2-gpu "if" block that restricts clocks to a single entry,
>>> &gt; &gt; since K3 has the same single-clock requirement. It does not match any
>>> &gt; &gt; "if" block that constrains power-domains, so that property falls back
>>> &gt;
>>> &gt; I don't get this explanation. Are you explaining what the patch is doing
>>> &gt; or explaining WHY you did this that way?
>>>
>>>
>>> That paragraph was describing schema mechanics, which does not belong in
>>> a commit message. v4 will drop it and state only the hardware facts: the
>>> K3 integration of the BXM-4-64 has a single "core" clock, and it has no
>>> software-controllable GPU power domain.
>>>
>>>
>>> &gt; &gt; to this schema's general constraints, where it is optional. This
>>> &gt; &gt; leaves room for a power-domains provider to be added later without a
>>> &gt; &gt; further binding change, should one ever be modelled in Linux for this
>>> &gt; &gt; SoC.
>>> &gt;
>>> &gt; No, you need to provide constraints now. Please read carefully
>>> &gt; writing-bindings.
>>>
>>>
>>> Understood. spacemit,k3-gpu currently matches no power-domains "if"
>>> block, so it falls back to the top-level 1-2 domains with
>>> power-domain-names "a"/"b". That would let a K3 DT with two power
>>> domains pass validation, which does not describe this hardware. v4 will
>>> add an explicit "if" block:
>>>
>>>
>>> &nbsp; &nbsp; - if:
>>> &nbsp; &nbsp; &nbsp; &nbsp; properties:
>>> &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; compatible:
>>> &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; contains:
>>> &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; const: spacemit,k3-gpu
>>> &nbsp; &nbsp; &nbsp; then:
>>> &nbsp; &nbsp; &nbsp; &nbsp; properties:
>>> &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; power-domains: false
>>> &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; power-domain-names: false
>>
>> I understand only half of this. Please fix your email client.
>>
>> And why this reply misses reply-to header which connects it to proper
>> thread? How am I supposed to find the thread now, among 200 I received
>> yesterday?
> 
> Sorry -- that went out through a webmail client which sent HTML, so the
> quoting and the YAML indentation were destroyed, and it composed a new
> message instead of replying in place, which is why it lost the thread.
> I have switched to git send-email over our own SMTP; this reply should
> be plain text and properly threaded.
> 
>> So your name is presented here as "Baihui Liang" then why do you use
>> some fake company name?
> 
> liangbaihui@linux.spacemit.com is my real work address at SpacemiT. It is
> now sent through the company's own mail server.

Again: then why do you use fake company name as name? Actually not a
company name, but laminated product of some company?

What is Sterling-Ash?

Best regards,
Krzysztof

  reply	other threads:[~2026-07-29  9:17 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <tencent_79CE08BE248E9ACA2E62BF64@qq.com>
2026-07-29  7:57 ` [PATCH v3 1/2] dt-bindings: gpu: img,powervr-rogue: add spacemit,k3-gpu Krzysztof Kozlowski
2026-07-29  9:14   ` Baihui Liang
2026-07-29  9:16     ` Krzysztof Kozlowski [this message]
2026-07-29 10:04       ` Baihui Liang
     [not found] <75c9382d2bda766aa459b00321153d715254d1a4.camel@imgtec.com>
2026-07-28  1:05 ` [PATCH v3 0/2] drm/imagination: support GPU probe without power-domains Sterling-Ash
2026-07-28  1:05   ` [PATCH v3 1/2] dt-bindings: gpu: img,powervr-rogue: add spacemit,k3-gpu Sterling-Ash
2026-07-28  8:07     ` Krzysztof Kozlowski
2026-07-29  9:22       ` Baihui Liang
2026-07-28  8:09     ` Krzysztof Kozlowski

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=39f12852-a0d4-4d90-8ea3-dbfa7e1c2059@kernel.org \
    --to=krzk@kernel.org \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=dlan@kernel.org \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=frank.binns@imgtec.com \
    --cc=krzk+dt@kernel.org \
    --cc=liangbaihui@linux.spacemit.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-riscv@lists.infradead.org \
    --cc=robh@kernel.org \
    --cc=spacemit@lists.linux.dev \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox