From mboxrd@z Thu Jan 1 00:00:00 1970 From: Thor Thayer Subject: Re: [PATCHv2 3/4] mfd: altr-a10sr: Add Arria10 SR Monitor Date: Mon, 31 Oct 2016 17:31:48 -0500 Message-ID: <39faa26d-ca05-d68d-a50a-03d09d445b77@opensource.altera.com> References: <1477598426-28125-1-git-send-email-tthayer@opensource.altera.com> <1477598426-28125-4-git-send-email-tthayer@opensource.altera.com> <20161031080222.GM13127@dell> Reply-To: Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8"; format=flowed Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <20161031080222.GM13127@dell> Sender: linux-kernel-owner@vger.kernel.org To: Lee Jones Cc: robh+dt@kernel.org, mark.rutland@arm.com, dinguyen@opensource.altera.com, linux@armlinux.org.uk, arnd@arndb.de, gregkh@linuxfoundation.org, davem@davemloft.net, geert@linux-m68k.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org List-Id: devicetree@vger.kernel.org Hi Lee, On 10/31/2016 03:02 AM, Lee Jones wrote: > On Thu, 27 Oct 2016, tthayer@opensource.altera.com wrote: > >> From: Thor Thayer >> >> Add the Altera Arria10 DevKit System Resource Monitor functionality >> to the MFD device. >> >> Signed-off-by: Thor Thayer >> --- >> v2 Change from -mon to -monitor for clarity >> --- >> drivers/mfd/altera-a10sr.c | 4 ++++ >> 1 file changed, 4 insertions(+) >> >> diff --git a/drivers/mfd/altera-a10sr.c b/drivers/mfd/altera-a10sr.c >> index 06e1f7f..30de652 100644 >> --- a/drivers/mfd/altera-a10sr.c >> +++ b/drivers/mfd/altera-a10sr.c >> @@ -33,6 +33,10 @@ >> .name = "altr_a10sr_gpio", >> .of_compatible = "altr,a10sr-gpio", >> }, >> + { >> + .name = "altr_a10sr_monitor", >> + .of_compatible = "altr,a10sr-monitor", > > So long as you use whichever compatible you agree on with Rob: > > For my own reference: > Acked-for-MFD-by: Lee Jones > I'm getting a "Non-standard signature" warning for this (even if I make everything lower-case). Would you prefer I submit it with the warning or should I change it to "Acked-by"? Thanks for reviewing! Thor >> + }, >> }; >> >> static bool altr_a10sr_reg_readable(struct device *dev, unsigned int reg) >