From: Krzysztof Kozlowski <k.kozlowski@samsung.com>
To: Linus Walleij <linus.walleij@linaro.org>
Cc: Tomasz Figa <tomasz.figa@gmail.com>,
Krzysztof Kozlowski <krzk@kernel.org>,
Sylwester Nawrocki <s.nawrocki@samsung.com>,
Rob Herring <robh+dt@kernel.org>,
Mark Rutland <mark.rutland@arm.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>,
linux-samsung-soc <linux-samsung-soc@vger.kernel.org>,
"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
Kukjin Kim <kgene@kernel.org>, Arnd Bergmann <arnd@arndb.de>,
Javier Martinez Canillas <javier@osg.samsung.com>,
Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>
Subject: Re: [PATCH v2 00/10] pinctrl: exynos/samsung: Add header with values used for configuration
Date: Fri, 16 Sep 2016 13:42:41 +0200 [thread overview]
Message-ID: <3a004c08-26b3-d5cd-dbc3-bc0f47814570@samsung.com> (raw)
In-Reply-To: <CACRpkdZuRym=SuAiBA_UsNmKd7N5n9g=z=ZxwcEk7J0BcXDsFw@mail.gmail.com>
On 09/07/2016 10:20 PM, Linus Walleij wrote:
> I have one comment though, if you're anyway making changes to all
> the DTS files:
>
> On Thu, Sep 1, 2016 at 9:23 AM, Krzysztof Kozlowski
> <k.kozlowski@samsung.com> wrote:
>
>> - samsung,pin-function = <2>;
>> - samsung,pin-pud = <0>;
>> - samsung,pin-drv = <0>;
>> + samsung,pin-function = <EXYNOS_PIN_FUNC_2>;
>> + samsung,pin-pud = <EXYNOS_PIN_PULL_NONE>;
>> + samsung,pin-drv = <EXYNOS4_PIN_DRV_LV1>;
>
> Nowadays we have standard bindings for this, see
> Documentation/devicetree/bindings/pinctrl/pinctrl-bindings.txt
>
> Section "Generic pin multiplexing node content".
>
> By patching the driver and bindings to accept also the standard
> bindings with just function and pins and also adding support
> for standard pin configurations like bias-disable
> bias-pull-up with the old samsung,* bindings as a fallback
> etc you can actually modernize the whole binding and
> DTS looks to something simpler.
>
> You will find that this is how newer platforms do it.
>
> But it is admittedly a bigger project.
Indeed it would be nice to support generic bindings. Almost certainly I
won't have time for implementing this but it looks like a good task for
newcomers.
Best regards,
Krzysztof
prev parent reply other threads:[~2016-09-16 11:42 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-09-01 7:23 [PATCH v2 00/10] pinctrl: exynos/samsung: Add header with values used for configuration Krzysztof Kozlowski
2016-09-01 7:23 ` [PATCH v2 01/10] pinctrl: dt-bindings: samsung: " Krzysztof Kozlowski
[not found] ` <1472714638-15676-2-git-send-email-k.kozlowski-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org>
2016-09-01 9:00 ` [PATCH v2.1] " Krzysztof Kozlowski
2016-09-01 11:02 ` [PATCH v2 01/10] " Bartlomiej Zolnierkiewicz
2016-09-01 11:13 ` Krzysztof Kozlowski
2016-09-01 7:23 ` [PATCH v2 02/10] ARM: dts: exynos: Use common macros for pinctrl configuration Krzysztof Kozlowski
2016-09-01 7:23 ` [PATCH v2 03/10] ARM: dts: exynos: Use macros for pinctrl configuration on exynos3250 Krzysztof Kozlowski
2016-09-01 7:23 ` [PATCH v2 04/10] ARM: dts: exynos: Use macros for pinctrl configuration on exynos4210 Krzysztof Kozlowski
2016-09-01 7:23 ` [PATCH v2 05/10] ARM: dts: exynos: Use macros for pinctrl configuration on exynos4x12 Krzysztof Kozlowski
[not found] ` <1472714638-15676-1-git-send-email-k.kozlowski-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org>
2016-09-01 7:23 ` [PATCH v2 06/10] ARM: dts: exynos: Use macros for pinctrl configuration on exynos4415 Krzysztof Kozlowski
2016-09-01 7:23 ` [PATCH v2 07/10] ARM: dts: exynos: Use macros for pinctrl configuration on exynos5250 Krzysztof Kozlowski
2016-09-01 7:23 ` [PATCH v2 08/10] ARM: dts: exynos: Use macros for pinctrl configuration on exynos5260 Krzysztof Kozlowski
2016-09-01 7:23 ` [PATCH v2 09/10] ARM: dts: exynos: Use macros for pinctrl configuration on exynos5410 Krzysztof Kozlowski
2016-09-01 7:23 ` [PATCH v2 10/10] ARM: dts: exynos: Use macros for pinctrl configuration on exynos542x/exynos5800 Krzysztof Kozlowski
2016-09-01 10:14 ` [PATCH v2 00/10] pinctrl: exynos/samsung: Add header with values used for configuration Javier Martinez Canillas
2016-09-07 20:07 ` Linus Walleij
2016-09-07 20:20 ` Linus Walleij
[not found] ` <CGME20160916114244eucas1p2f585ef754b0523022a04a5646a06da36@eucas1p2.samsung.com>
2016-09-16 11:42 ` Krzysztof Kozlowski [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3a004c08-26b3-d5cd-dbc3-bc0f47814570@samsung.com \
--to=k.kozlowski@samsung.com \
--cc=arnd@arndb.de \
--cc=b.zolnierkie@samsung.com \
--cc=devicetree@vger.kernel.org \
--cc=javier@osg.samsung.com \
--cc=kgene@kernel.org \
--cc=krzk@kernel.org \
--cc=linus.walleij@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=robh+dt@kernel.org \
--cc=s.nawrocki@samsung.com \
--cc=tomasz.figa@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).