From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4FE01C433EF for ; Wed, 3 Nov 2021 11:22:25 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 34DF861151 for ; Wed, 3 Nov 2021 11:22:25 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231912AbhKCLZA (ORCPT ); Wed, 3 Nov 2021 07:25:00 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:43394 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230304AbhKCLY7 (ORCPT ); Wed, 3 Nov 2021 07:24:59 -0400 Received: from mail-wr1-x42c.google.com (mail-wr1-x42c.google.com [IPv6:2a00:1450:4864:20::42c]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 5E945C061714 for ; Wed, 3 Nov 2021 04:22:23 -0700 (PDT) Received: by mail-wr1-x42c.google.com with SMTP id b12so3030753wrh.4 for ; Wed, 03 Nov 2021 04:22:23 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=xvRy8189/PatcFWb8Yj/D891VzazaAXtP9HMgX8A0nQ=; b=naqXJPRvnK8bF3PMFmomTuXyKAPAzSb0z3wTSm+JnP3wBYNZrAlLSTN/xBFG4dVRuR d7lc74EFavOnu/pS3MZAqMprJuKoBK6907WaCb196MBtGV/zBxbGBdR37FjzSR9Eu27W uyX5G/70gmxypyQgWaRa74qQu1GhZoRlDFll64L09HyC9uXZyNk0c1cAnCtfhymU0WKC kh5qOWQMUZ4T6/3T6Et09TlXSFTulSIS6WtbYWGQa2w87XRqEaL+5nd9VQdD4YTL/zyv 79joWDIbfMq0BmW4W/KLIrNC9moK2QfEYa3s+6Oi2AYExnDU+eiwatJQvbd4nEWsim2R lm9w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=xvRy8189/PatcFWb8Yj/D891VzazaAXtP9HMgX8A0nQ=; b=6kKpKGrdUcKNS300gmVFEQB3CHeh/+CY/zQaJDWpeW54y2Hym5i/BvbqCq/fCBUcgH eC8YDRs0gSOKvyqKkuNmnP8atoH3p0TBz3ATJHjGQgjk2x2gno2MXJZmdJwW6Otet00M 03ctI2On9oLzlqJaQLM6P8WX7wfyl5kNCu1rmOEQxovd6yCWYc9oyGzphWxtf9ZKA1zQ kjRm7HCuBFUTt0srDjyqmOaoM/iGutAiK9vGGIHtZYfpb6ak4qiBAblpB+77byZ1b1PE LIgsqYszYY8XE8ln4U7ZGUsCNaVVh4AvIiLlNuHymMW3mWeCRzgz1GvLF0bB4G6v2thV bIfw== X-Gm-Message-State: AOAM533oUdOJjvAvpPU3k9CG4NEcfh9hsVPYrjxQZ7EIobJARe9LC/aM 6qHeA3gkYGEmDP2aTP64LGP0DA== X-Google-Smtp-Source: ABdhPJyXWkbG6Ra2Pj7zQiEQ3L/R/kN0TUGvlv9OSMWlLRmWllNCm16kbG0h+J29Us/K5UXaXMuEjg== X-Received: by 2002:adf:df0b:: with SMTP id y11mr30942648wrl.181.1635938542002; Wed, 03 Nov 2021 04:22:22 -0700 (PDT) Received: from [192.168.86.34] (cpc86377-aztw32-2-0-cust226.18-1.cable.virginm.net. [92.233.226.227]) by smtp.googlemail.com with ESMTPSA id k37sm1591933wms.21.2021.11.03.04.22.20 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 03 Nov 2021 04:22:21 -0700 (PDT) Subject: Re: [PATCH v2 3/3] pinctrl: qcom: Add SC7280 lpass pin configuration To: Srinivasa Rao Mandadapu , agross@kernel.org, bjorn.andersson@linaro.org, lgirdwood@gmail.com, broonie@kernel.org, robh+dt@kernel.org, plai@codeaurora.org, bgoswami@codeaurora.org, perex@perex.cz, tiwai@suse.com, rohitkr@codeaurora.org, linux-arm-msm@vger.kernel.org, alsa-devel@alsa-project.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, swboyd@chromium.org, judyhsiao@chromium.org Cc: Venkata Prasad Potturu References: <1635342097-2726-1-git-send-email-srivasam@codeaurora.org> <1635342097-2726-4-git-send-email-srivasam@codeaurora.org> From: Srinivas Kandagatla Message-ID: <3a05fc62-a060-3257-ad54-53e376763fe3@linaro.org> Date: Wed, 3 Nov 2021 11:22:20 +0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.13.0 MIME-Version: 1.0 In-Reply-To: <1635342097-2726-4-git-send-email-srivasam@codeaurora.org> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org Thanks Srinivasa for the patches. On 27/10/2021 14:41, Srinivasa Rao Mandadapu wrote: > Update pin control support for SC7280 LPASS LPI. > > Signed-off-by: Srinivasa Rao Mandadapu > Co-developed-by: Venkata Prasad Potturu > Signed-off-by: Venkata Prasad Potturu > --- > drivers/pinctrl/qcom/pinctrl-lpass-lpi.c | 40 ++++++++++++++++++++++++++++++++ > 1 file changed, 40 insertions(+) > > diff --git a/drivers/pinctrl/qcom/pinctrl-lpass-lpi.c b/drivers/pinctrl/qcom/pinctrl-lpass-lpi.c > index 0bd0c16..17a05a6 100644 > --- a/drivers/pinctrl/qcom/pinctrl-lpass-lpi.c > +++ b/drivers/pinctrl/qcom/pinctrl-lpass-lpi.c > @@ -122,6 +122,7 @@ static const struct pinctrl_pin_desc lpass_lpi_pins[] = { > PINCTRL_PIN(11, "gpio11"), > PINCTRL_PIN(12, "gpio12"), > PINCTRL_PIN(13, "gpio13"), > + PINCTRL_PIN(14, "gpio14"), I see your point in first patch making these names more generic, but this is not really going to work, as the above line just added new pin for sm8250 even though it really only has 0-13 pins. I think it would be more clear if you could just make a dedicated structures for sc7280. Simillar comments apply for other changes too. Other than that the patch looks good to me. --srini > }; > > enum lpass_lpi_functions { > @@ -136,6 +137,7 @@ enum lpass_lpi_functions { > LPI_MUX_i2s1_ws, > LPI_MUX_i2s2_clk, > LPI_MUX_i2s2_data, > + LPI_MUX_sc7280_i2s2_data, > LPI_MUX_i2s2_ws, > LPI_MUX_qua_mi2s_data, > LPI_MUX_qua_mi2s_sclk, > @@ -144,6 +146,7 @@ enum lpass_lpi_functions { > LPI_MUX_swr_rx_data, > LPI_MUX_swr_tx_clk, > LPI_MUX_swr_tx_data, > + LPI_MUX_sc7280_swr_tx_data, > LPI_MUX_wsa_swr_clk, > LPI_MUX_wsa_swr_data, > LPI_MUX_gpio, > @@ -164,8 +167,11 @@ static const unsigned int gpio10_pins[] = { 10 }; > static const unsigned int gpio11_pins[] = { 11 }; > static const unsigned int gpio12_pins[] = { 12 }; > static const unsigned int gpio13_pins[] = { 13 }; > +static const unsigned int gpio14_pins[] = { 14 }; > + > static const char * const swr_tx_clk_groups[] = { "gpio0" }; > static const char * const swr_tx_data_groups[] = { "gpio1", "gpio2", "gpio5" }; > +static const char * const sc7280_swr_tx_data_groups[] = { "gpio1", "gpio2", "gpio14" }; > static const char * const swr_rx_clk_groups[] = { "gpio3" }; > static const char * const swr_rx_data_groups[] = { "gpio4", "gpio5" }; > static const char * const dmic1_clk_groups[] = { "gpio6" }; > @@ -185,6 +191,7 @@ static const char * const i2s1_data_groups[] = { "gpio8", "gpio9" }; > static const char * const wsa_swr_clk_groups[] = { "gpio10" }; > static const char * const wsa_swr_data_groups[] = { "gpio11" }; > static const char * const i2s2_data_groups[] = { "gpio12", "gpio12" }; > +static const char * const sc7280_i2s2_data_groups[] = { "gpio12", "gpio13" }; > > static const struct lpi_pingroup sm8250_groups[] = { > LPI_PINGROUP(0, 0, swr_tx_clk, qua_mi2s_sclk, _, _), > @@ -203,6 +210,24 @@ static const struct lpi_pingroup sm8250_groups[] = { > LPI_PINGROUP(13, NO_SLEW, dmic3_data, i2s2_data, _, _), > }; > > +static const struct lpi_pingroup sc7280_groups[] = { > + LPI_PINGROUP(0, 0, swr_tx_clk, qua_mi2s_sclk, _, _), > + LPI_PINGROUP(1, 2, swr_tx_data, qua_mi2s_ws, _, _), > + LPI_PINGROUP(2, 4, swr_tx_data, qua_mi2s_data, _, _), > + LPI_PINGROUP(3, 8, swr_rx_clk, qua_mi2s_data, _, _), > + LPI_PINGROUP(4, 10, swr_rx_data, qua_mi2s_data, _, _), > + LPI_PINGROUP(5, 12, swr_rx_data, _, _, _), > + LPI_PINGROUP(6, NO_SLEW, dmic1_clk, i2s1_clk, _, _), > + LPI_PINGROUP(7, NO_SLEW, dmic1_data, i2s1_ws, _, _), > + LPI_PINGROUP(8, NO_SLEW, dmic2_clk, i2s1_data, _, _), > + LPI_PINGROUP(9, NO_SLEW, dmic2_data, i2s1_data, _, _), > + LPI_PINGROUP(10, 16, i2s2_clk, wsa_swr_clk, _, _), > + LPI_PINGROUP(11, 18, i2s2_ws, wsa_swr_data, _, _), > + LPI_PINGROUP(12, NO_SLEW, dmic3_clk, sc7280_i2s2_data, _, _), > + LPI_PINGROUP(13, NO_SLEW, dmic3_data, sc7280_i2s2_data, _, _), > + LPI_PINGROUP(14, 6, sc7280_swr_tx_data, _, _, _), > +}; > + > static const struct lpi_function lpass_functions[] = { > LPI_FUNCTION(dmic1_clk), > LPI_FUNCTION(dmic1_data), > @@ -215,6 +240,7 @@ static const struct lpi_function lpass_functions[] = { > LPI_FUNCTION(i2s1_ws), > LPI_FUNCTION(i2s2_clk), > LPI_FUNCTION(i2s2_data), > + LPI_FUNCTION(sc7280_i2s2_data), > LPI_FUNCTION(i2s2_ws), > LPI_FUNCTION(qua_mi2s_data), > LPI_FUNCTION(qua_mi2s_sclk), > @@ -223,6 +249,7 @@ static const struct lpi_function lpass_functions[] = { > LPI_FUNCTION(swr_rx_data), > LPI_FUNCTION(swr_tx_clk), > LPI_FUNCTION(swr_tx_data), > + LPI_FUNCTION(sc7280_swr_tx_data), > LPI_FUNCTION(wsa_swr_clk), > LPI_FUNCTION(wsa_swr_data), > }; > @@ -236,6 +263,15 @@ static struct lpi_pinctrl_variant_data sm8250_lpi_data = { > .nfunctions = ARRAY_SIZE(lpass_functions), > }; > > +static const struct lpi_pinctrl_variant_data sc7280_lpi_data = { > + .pins = lpass_lpi_pins, > + .npins = ARRAY_SIZE(lpass_lpi_pins), > + .groups = sc7280_groups, > + .ngroups = ARRAY_SIZE(sc7280_groups), > + .functions = lpass_functions, > + .nfunctions = ARRAY_SIZE(lpass_functions), > +}; > + > static int lpi_gpio_read(struct lpi_pinctrl *state, unsigned int pin, > unsigned int addr) > { > @@ -677,6 +713,10 @@ static const struct of_device_id lpi_pinctrl_of_match[] = { > .compatible = "qcom,sm8250-lpass-lpi-pinctrl", > .data = &sm8250_lpi_data, > }, > + { > + .compatible = "qcom,sc7280-lpass-lpi-pinctrl", > + .data = &sc7280_lpi_data, > + }, > { } > }; > MODULE_DEVICE_TABLE(of, lpi_pinctrl_of_match); >