From mboxrd@z Thu Jan 1 00:00:00 1970 From: Corey Minyard Subject: Re: [PATCH 3/3] ipmi/bt-bmc: add a sysfs file to configure a maximum response time Date: Mon, 7 Nov 2016 12:37:41 -0600 Message-ID: <3a1f8e6d-c935-3404-ffa0-81b19d170731@acm.org> References: <1478073426-3714-1-git-send-email-clg@kaod.org> <1478073426-3714-4-git-send-email-clg@kaod.org> Reply-To: minyard-HInyCGIudOg@public.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit Return-path: In-Reply-To: <1478073426-3714-4-git-send-email-clg-Bxea+6Xhats@public.gmane.org> Sender: devicetree-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: =?UTF-8?Q?C=c3=a9dric_Le_Goater?= , openipmi-developer-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org, Joel Stanley Cc: Rob Herring , Arnd Bergmann , devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org List-Id: devicetree@vger.kernel.org Sorry, I was at Plumbers and extra busy with other stuff. Just getting around to reviewing this. On 11/02/2016 02:57 AM, Cédric Le Goater wrote: > We could also use an ioctl for that purpose. sysfs seems a better > approach. > > Signed-off-by: Cédric Le Goater > --- > drivers/char/ipmi/bt-bmc.c | 31 +++++++++++++++++++++++++++++++ > 1 file changed, 31 insertions(+) > > diff --git a/drivers/char/ipmi/bt-bmc.c b/drivers/char/ipmi/bt-bmc.c > index e751e4a754b7..d7146f0e900e 100644 > --- a/drivers/char/ipmi/bt-bmc.c > +++ b/drivers/char/ipmi/bt-bmc.c > @@ -84,6 +84,33 @@ struct bt_bmc { > > static atomic_t open_count = ATOMIC_INIT(0); > > +static ssize_t bt_bmc_show_response_time(struct device *dev, > + struct device_attribute *attr, > + char *buf) > +{ > + struct bt_bmc *bt_bmc = dev_get_drvdata(dev); > + > + return snprintf(buf, PAGE_SIZE - 1, "%d\n", bt_bmc->response_time); > +} > + > +static ssize_t bt_bmc_set_response_time(struct device *dev, > + struct device_attribute *attr, > + const char *buf, size_t count) > +{ > + struct bt_bmc *bt_bmc = dev_get_drvdata(dev); > + unsigned long val; > + int err; > + > + err = kstrtoul(buf, 0, &val); > + if (err) > + return err; > + bt_bmc->response_time = val; > + return count; > +} > + > +static DEVICE_ATTR(response_time, 0644, > + bt_bmc_show_response_time, bt_bmc_set_response_time); > + > static u8 bt_inb(struct bt_bmc *bt_bmc, int reg) > { > return ioread8(bt_bmc->base + reg); > @@ -572,6 +599,10 @@ static int bt_bmc_probe(struct platform_device *pdev) > bt_bmc_config_irq(bt_bmc, pdev); > > bt_bmc->response_time = BT_BMC_RESPONSE_TIME; > + rc = device_create_file(&pdev->dev, &dev_attr_response_time); > + if (rc) > + dev_warn(&pdev->dev, "can't create response_time file\n"); > + You added an extra space here. > > if (bt_bmc->irq) { > dev_info(dev, "Using IRQ %d\n", bt_bmc->irq); -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html