From: Krzysztof Kozlowski <krzk@kernel.org>
To: Manikandan.M@microchip.com
Cc: neil.armstrong@linaro.org, quic_jesszhan@quicinc.com,
maarten.lankhorst@linux.intel.com, mripard@kernel.org,
tzimmermann@suse.de, airlied@gmail.com, simona@ffwll.ch,
robh@kernel.org, krzk+dt@kernel.org, conor+dt@kernel.org,
thierry.reding@gmail.com, sam@ravnborg.org,
dri-devel@lists.freedesktop.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/2] dt-bindings: display: panel-simple: Document support for Microchip AC69T88A
Date: Wed, 18 Sep 2024 10:17:07 +0200 [thread overview]
Message-ID: <3a33370a-4f11-4f19-96e8-95bd1a8a48cb@kernel.org> (raw)
In-Reply-To: <46cb2204-ee5a-4999-b229-ee1282f96a69@microchip.com>
On 18/09/2024 05:08, Manikandan.M@microchip.com wrote:
> Hi Krzysztof,
>
> On 17/09/24 4:07 pm, Krzysztof Kozlowski wrote:
>> EXTERNAL EMAIL: Do not click links or open attachments unless you know the content is safe
>>
>> On 17/09/2024 11:53, Manikandan Muralidharan wrote:
>>> Add Microchip AC69T88A 5" LVDS interface (800x480) TFT LCD panel
>>> compatible string
>>>
>>> Signed-off-by: Manikandan Muralidharan <manikandan.m@microchip.com>
>>> ---
>>> .../devicetree/bindings/display/panel/panel-simple.yaml | 2 ++
>>> 1 file changed, 2 insertions(+)
>>>
>>> diff --git a/Documentation/devicetree/bindings/display/panel/panel-simple.yaml b/Documentation/devicetree/bindings/display/panel/panel-simple.yaml
>>> index b89e39790579..09911b89d140 100644
>>> --- a/Documentation/devicetree/bindings/display/panel/panel-simple.yaml
>>> +++ b/Documentation/devicetree/bindings/display/panel/panel-simple.yaml
>>> @@ -200,6 +200,8 @@ properties:
>>> - logictechno,lttd800480070-l2rt
>>> # Logic Technologies LTTD800480070-L6WH-RT 7” 800x480 TFT Resistive Touch Module
>>> - logictechno,lttd800480070-l6wh-rt
>>> + # Microchip AC69T88A 5" 800X480 LVDS interface TFT LCD Panel
>>> + - microchip,ac69t88a-lvds-panel
>>
>> Is this device some sort of multi-function? Why "lvds-panel"? What else
>> could it be?
> This device does not multi-function, I will rephrase and share a v2
Then drop lvds-panel, please.
Best regards,
Krzysztof
prev parent reply other threads:[~2024-09-18 8:17 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-09-17 9:53 [PATCH 1/2] dt-bindings: display: panel-simple: Document support for Microchip AC69T88A Manikandan Muralidharan
2024-09-17 9:53 ` [PATCH 2/2] drm/panel: simple: Add Microchip AC69T88A LVDS Display panel Manikandan Muralidharan
2024-09-17 10:37 ` [PATCH 1/2] dt-bindings: display: panel-simple: Document support for Microchip AC69T88A Krzysztof Kozlowski
2024-09-18 3:08 ` Manikandan.M
2024-09-18 8:17 ` Krzysztof Kozlowski [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3a33370a-4f11-4f19-96e8-95bd1a8a48cb@kernel.org \
--to=krzk@kernel.org \
--cc=Manikandan.M@microchip.com \
--cc=airlied@gmail.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=krzk+dt@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=maarten.lankhorst@linux.intel.com \
--cc=mripard@kernel.org \
--cc=neil.armstrong@linaro.org \
--cc=quic_jesszhan@quicinc.com \
--cc=robh@kernel.org \
--cc=sam@ravnborg.org \
--cc=simona@ffwll.ch \
--cc=thierry.reding@gmail.com \
--cc=tzimmermann@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).