[PATCH 1/2] dt-bindings: display: panel-simple: Document support for Microchip AC69T88A

[PATCH 1/2] dt-bindings: display: panel-simple: Document support for Microchip AC69T88A

[Manikandan Muralidharan]

Add Microchip AC69T88A 5" LVDS interface (800x480) TFT LCD panel
compatible string

Signed-off-by: Manikandan Muralidharan <manikandan.m@microchip.com>
---
 .../devicetree/bindings/display/panel/panel-simple.yaml         | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/Documentation/devicetree/bindings/display/panel/panel-simple.yaml b/Documentation/devicetree/bindings/display/panel/panel-simple.yaml
index b89e39790579..09911b89d140 100644
--- a/Documentation/devicetree/bindings/display/panel/panel-simple.yaml
+++ b/Documentation/devicetree/bindings/display/panel/panel-simple.yaml
@@ -200,6 +200,8 @@ properties:
       - logictechno,lttd800480070-l2rt
         # Logic Technologies LTTD800480070-L6WH-RT 7” 800x480 TFT Resistive Touch Module
       - logictechno,lttd800480070-l6wh-rt
+        # Microchip AC69T88A 5" 800X480 LVDS interface TFT LCD Panel
+      - microchip,ac69t88a-lvds-panel
         # Mitsubishi "AA070MC01 7.0" WVGA TFT LCD panel
       - mitsubishi,aa070mc01-ca1
         # Mitsubishi AA084XE01 8.4" XGA TFT LCD panel
-- 
2.25.1

[PATCH 2/2] drm/panel: simple: Add Microchip AC69T88A LVDS Display panel

[Manikandan Muralidharan]

Add support for Microchip AC69T88A 5 inch TFT LCD 800x480
Display module with LVDS interface.The panel uses the Sitronix
ST7262 800x480 Display driver

Signed-off-by: Manikandan Muralidharan <manikandan.m@microchip.com>
Signed-off-by: Dharma Balasubiramani <dharma.b@microchip.com>
---
 drivers/gpu/drm/panel/panel-simple.c | 28 ++++++++++++++++++++++++++++
 1 file changed, 28 insertions(+)

diff --git a/drivers/gpu/drm/panel/panel-simple.c b/drivers/gpu/drm/panel/panel-simple.c
index 86735430462f..6c2322ec218a 100644
--- a/drivers/gpu/drm/panel/panel-simple.c
+++ b/drivers/gpu/drm/panel/panel-simple.c
@@ -4565,6 +4565,31 @@ static const struct panel_desc yes_optoelectronics_ytc700tlag_05_201c = {
 	.connector_type = DRM_MODE_CONNECTOR_LVDS,
 };
 
+static const struct drm_display_mode mchp_ac69t88a_mode = {
+	.clock = 25000,
+	.hdisplay = 800,
+	.hsync_start = 800 + 88,
+	.hsync_end = 800 + 88 + 5,
+	.htotal = 800 + 88 + 5 + 40,
+	.vdisplay = 480,
+	.vsync_start = 480 + 23,
+	.vsync_end = 480 + 23 + 5,
+	.vtotal = 480 + 23 + 5 + 1,
+};
+
+static const struct panel_desc mchp_ac69t88a = {
+	.modes = &mchp_ac69t88a_mode,
+	.num_modes = 1,
+	.bpc = 8,
+	.size = {
+		.width = 108,
+		.height = 65,
+	},
+	.bus_flags = DRM_BUS_FLAG_DE_HIGH,
+	.bus_format = MEDIA_BUS_FMT_RGB888_1X7X4_JEIDA,
+	.connector_type = DRM_MODE_CONNECTOR_LVDS,
+};
+
 static const struct drm_display_mode arm_rtsm_mode[] = {
 	{
 		.clock = 65000,
@@ -5048,6 +5073,9 @@ static const struct of_device_id platform_of_match[] = {
 	}, {
 		.compatible = "yes-optoelectronics,ytc700tlag-05-201c",
 		.data = &yes_optoelectronics_ytc700tlag_05_201c,
+	}, {
+		.compatible = "microchip,ac69t88a-lvds-panel",
+		.data = &mchp_ac69t88a,
 	}, {
 		/* Must be the last entry */
 		.compatible = "panel-dpi",
-- 
2.25.1

Re: [PATCH 1/2] dt-bindings: display: panel-simple: Document support for Microchip AC69T88A

[Krzysztof Kozlowski]

On 17/09/2024 11:53, Manikandan Muralidharan wrote:
> Add Microchip AC69T88A 5" LVDS interface (800x480) TFT LCD panel
> compatible string
> 
> Signed-off-by: Manikandan Muralidharan <manikandan.m@microchip.com>
> ---
>  .../devicetree/bindings/display/panel/panel-simple.yaml         | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/Documentation/devicetree/bindings/display/panel/panel-simple.yaml b/Documentation/devicetree/bindings/display/panel/panel-simple.yaml
> index b89e39790579..09911b89d140 100644
> --- a/Documentation/devicetree/bindings/display/panel/panel-simple.yaml
> +++ b/Documentation/devicetree/bindings/display/panel/panel-simple.yaml
> @@ -200,6 +200,8 @@ properties:
>        - logictechno,lttd800480070-l2rt
>          # Logic Technologies LTTD800480070-L6WH-RT 7” 800x480 TFT Resistive Touch Module
>        - logictechno,lttd800480070-l6wh-rt
> +        # Microchip AC69T88A 5" 800X480 LVDS interface TFT LCD Panel
> +      - microchip,ac69t88a-lvds-panel

Is this device some sort of multi-function? Why "lvds-panel"? What else
could it be?

Best regards,
Krzysztof

Re: [PATCH 1/2] dt-bindings: display: panel-simple: Document support for Microchip AC69T88A

[Manikandan.M]

Hi Krzysztof,

On 17/09/24 4:07 pm, Krzysztof Kozlowski wrote:
> EXTERNAL EMAIL: Do not click links or open attachments unless you know the content is safe
> 
> On 17/09/2024 11:53, Manikandan Muralidharan wrote:
>> Add Microchip AC69T88A 5" LVDS interface (800x480) TFT LCD panel
>> compatible string
>>
>> Signed-off-by: Manikandan Muralidharan <manikandan.m@microchip.com>
>> ---
>>   .../devicetree/bindings/display/panel/panel-simple.yaml         | 2 ++
>>   1 file changed, 2 insertions(+)
>>
>> diff --git a/Documentation/devicetree/bindings/display/panel/panel-simple.yaml b/Documentation/devicetree/bindings/display/panel/panel-simple.yaml
>> index b89e39790579..09911b89d140 100644
>> --- a/Documentation/devicetree/bindings/display/panel/panel-simple.yaml
>> +++ b/Documentation/devicetree/bindings/display/panel/panel-simple.yaml
>> @@ -200,6 +200,8 @@ properties:
>>         - logictechno,lttd800480070-l2rt
>>           # Logic Technologies LTTD800480070-L6WH-RT 7” 800x480 TFT Resistive Touch Module
>>         - logictechno,lttd800480070-l6wh-rt
>> +        # Microchip AC69T88A 5" 800X480 LVDS interface TFT LCD Panel
>> +      - microchip,ac69t88a-lvds-panel
> 
> Is this device some sort of multi-function? Why "lvds-panel"? What else
> could it be?
This device does not multi-function, I will rephrase and share a v2
> 
> Best regards,
> Krzysztof
> 

-- 
Thanks and Regards,
Manikandan M.

Re: [PATCH 1/2] dt-bindings: display: panel-simple: Document support for Microchip AC69T88A

[Krzysztof Kozlowski]

On 18/09/2024 05:08, Manikandan.M@microchip.com wrote:
> Hi Krzysztof,
> 
> On 17/09/24 4:07 pm, Krzysztof Kozlowski wrote:
>> EXTERNAL EMAIL: Do not click links or open attachments unless you know the content is safe
>>
>> On 17/09/2024 11:53, Manikandan Muralidharan wrote:
>>> Add Microchip AC69T88A 5" LVDS interface (800x480) TFT LCD panel
>>> compatible string
>>>
>>> Signed-off-by: Manikandan Muralidharan <manikandan.m@microchip.com>
>>> ---
>>>   .../devicetree/bindings/display/panel/panel-simple.yaml         | 2 ++
>>>   1 file changed, 2 insertions(+)
>>>
>>> diff --git a/Documentation/devicetree/bindings/display/panel/panel-simple.yaml b/Documentation/devicetree/bindings/display/panel/panel-simple.yaml
>>> index b89e39790579..09911b89d140 100644
>>> --- a/Documentation/devicetree/bindings/display/panel/panel-simple.yaml
>>> +++ b/Documentation/devicetree/bindings/display/panel/panel-simple.yaml
>>> @@ -200,6 +200,8 @@ properties:
>>>         - logictechno,lttd800480070-l2rt
>>>           # Logic Technologies LTTD800480070-L6WH-RT 7” 800x480 TFT Resistive Touch Module
>>>         - logictechno,lttd800480070-l6wh-rt
>>> +        # Microchip AC69T88A 5" 800X480 LVDS interface TFT LCD Panel
>>> +      - microchip,ac69t88a-lvds-panel
>>
>> Is this device some sort of multi-function? Why "lvds-panel"? What else
>> could it be?
> This device does not multi-function, I will rephrase and share a v2

Then drop lvds-panel, please.

Best regards,
Krzysztof