From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: Tali Perry <tali.perry1@gmail.com>,
avifishman70@gmail.com, tmaimon77@gmail.com, venture@google.com,
yuenn@google.com, brendanhiggins@google.com, robh+dt@kernel.org,
mark.rutland@arm.com, davem@davemloft.net,
mchehab+samsung@kernel.org, gregkh@linuxfoundation.org,
akpm@linux-foundation.org, arnd@arndb.de, wsa@the-dreams.de,
pierre-yves.mordret@st.com, cedric.madianga@gmail.com,
baolin.wang@spreadtrum.com, jarkko.nikula@linux.intel.com,
hdegoede@redhat.com, rmk+kernel@armlinux.org.uk,
ard.biesheuvel@linaro.org, thor.thayer@linux.intel.com,
geert@linux-m68k.org, heikki.krogerus@linux.intel.com,
tglx@linutronix.de
Cc: linux-i2c@vger.kernel.org, openbmc@lists.ozlabs.org,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 2/2] i2c: npcm7xx: add i2c controller master mode only
Date: Tue, 07 Aug 2018 14:26:25 +0300 [thread overview]
Message-ID: <3a50932025929d1b318cb42c05a727892603d31d.camel@linux.intel.com> (raw)
In-Reply-To: <20180807110709.31847-3-tali.perry1@gmail.com>
On Tue, 2018-08-07 at 14:07 +0300, Tali Perry wrote:
> Nuvoton NPCM7XX I2C Controller
> NPCM7xx includes 16 I2C contollers. THis driver operates the
> controller.
> This module also includes a slave mode, which will be submitted later
> on.
>
> Any feedback would be appreciated.
>
> v2 -> v1:
> - run check patch in strict mode.
> - use linux crc.
> - define regs in constant offset without base.
> - remove debug prints.
> - no declerations for local functions.
>
> v1: initial version
I don't know / remember why I'm in Cc list here, but you can go through
my other reviews and find style recommendations for your code as well.
--
Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Intel Finland Oy
next prev parent reply other threads:[~2018-08-07 11:26 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-08-07 11:07 [PATCH v2 0/2] i2c: npcm7xx: new driver for I2C controller Tali Perry
2018-08-07 11:07 ` [PATCH v2 1/2] dt-binding: i2c: npcm7xx: add binding for i2c controller Tali Perry
2018-08-13 18:58 ` Rob Herring
2018-08-07 11:07 ` [PATCH v2 2/2] i2c: npcm7xx: add i2c controller master mode only Tali Perry
2018-08-07 11:26 ` Andy Shevchenko [this message]
-- strict thread matches above, loose matches on Subject: below --
2018-08-07 10:38 [PATCH v2 0/2] i2c: npcm7xx: new driver for I2C controller Tali Perry
2018-08-07 10:38 ` [PATCH v2 2/2] i2c: npcm7xx: add i2c controller master mode only Tali Perry
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3a50932025929d1b318cb42c05a727892603d31d.camel@linux.intel.com \
--to=andriy.shevchenko@linux.intel.com \
--cc=akpm@linux-foundation.org \
--cc=ard.biesheuvel@linaro.org \
--cc=arnd@arndb.de \
--cc=avifishman70@gmail.com \
--cc=baolin.wang@spreadtrum.com \
--cc=brendanhiggins@google.com \
--cc=cedric.madianga@gmail.com \
--cc=davem@davemloft.net \
--cc=devicetree@vger.kernel.org \
--cc=geert@linux-m68k.org \
--cc=gregkh@linuxfoundation.org \
--cc=hdegoede@redhat.com \
--cc=heikki.krogerus@linux.intel.com \
--cc=jarkko.nikula@linux.intel.com \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=mchehab+samsung@kernel.org \
--cc=openbmc@lists.ozlabs.org \
--cc=pierre-yves.mordret@st.com \
--cc=rmk+kernel@armlinux.org.uk \
--cc=robh+dt@kernel.org \
--cc=tali.perry1@gmail.com \
--cc=tglx@linutronix.de \
--cc=thor.thayer@linux.intel.com \
--cc=tmaimon77@gmail.com \
--cc=venture@google.com \
--cc=wsa@the-dreams.de \
--cc=yuenn@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).