devicetree.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Matthias Brugger <matthias.bgg@gmail.com>
To: Rex-BC Chen <rex-bc.chen@mediatek.com>,
	mturquette@baylibre.com, sboyd@kernel.org, robh+dt@kernel.org,
	krzysztof.kozlowski+dt@linaro.org
Cc: p.zabel@pengutronix.de, angelogioacchino.delregno@collabora.com,
	chun-jie.chen@mediatek.com, wenst@chromium.org,
	runyang.chen@mediatek.com, linux-kernel@vger.kernel.org,
	devicetree@vger.kernel.org, linux-clk@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org,
	linux-mediatek@lists.infradead.org,
	Project_Global_Chrome_Upstream_Group@mediatek.com
Subject: Re: [PATCH v6 16/16] arm64: dts: mediatek: Add infra #reset-cells property for MT8195
Date: Wed, 22 Jun 2022 13:08:05 +0200	[thread overview]
Message-ID: <3a587e20-f991-adf8-fe4e-a09caa1e14c7@gmail.com> (raw)
In-Reply-To: <20220503093856.22250-17-rex-bc.chen@mediatek.com>



On 03/05/2022 11:38, Rex-BC Chen wrote:
> We will use mediatek clock reset as infracfg_ao reset instead of
> ti-syscon. To support this, remove property of ti reset and add
> property of #reset-cells for mediatek clock reset.
> 
> Signed-off-by: Rex-BC Chen <rex-bc.chen@mediatek.com>
> Reviewed-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>

My understanding is that using the old DTS with a newer kernel wouldn't 
introduce a regression, correct?

Applied, thanks!

> ---
>   arch/arm64/boot/dts/mediatek/mt8195.dtsi | 13 +------------
>   1 file changed, 1 insertion(+), 12 deletions(-)
> 
> diff --git a/arch/arm64/boot/dts/mediatek/mt8195.dtsi b/arch/arm64/boot/dts/mediatek/mt8195.dtsi
> index b57e620c2c72..8e5ac11b19f1 100644
> --- a/arch/arm64/boot/dts/mediatek/mt8195.dtsi
> +++ b/arch/arm64/boot/dts/mediatek/mt8195.dtsi
> @@ -10,7 +10,6 @@
>   #include <dt-bindings/interrupt-controller/irq.h>
>   #include <dt-bindings/phy/phy.h>
>   #include <dt-bindings/pinctrl/mt8195-pinfunc.h>
> -#include <dt-bindings/reset/ti-syscon.h>
>   
>   / {
>   	compatible = "mediatek,mt8195";
> @@ -295,17 +294,7 @@
>   			compatible = "mediatek,mt8195-infracfg_ao", "syscon", "simple-mfd";
>   			reg = <0 0x10001000 0 0x1000>;
>   			#clock-cells = <1>;
> -
> -			infracfg_rst: reset-controller {
> -				compatible = "ti,syscon-reset";
> -				#reset-cells = <1>;
> -				ti,reset-bits = <
> -					0x140 18 0x144 18 0 0 (ASSERT_SET | DEASSERT_SET | STATUS_NONE) /* pcie */
> -					0x120 0  0x124 0  0 0 (ASSERT_SET | DEASSERT_SET | STATUS_NONE) /* thermal */
> -					0x730 10 0x734 10 0 0 (ASSERT_SET | DEASSERT_SET | STATUS_NONE) /* thermal */
> -					0x150 5  0x154 5  0 0 (ASSERT_SET | DEASSERT_SET | STATUS_NONE) /* svs gpu */
> -				>;
> -			};
> +			#reset-cells = <1>;
>   		};
>   
>   		pericfg: syscon@10003000 {

  reply	other threads:[~2022-06-22 11:08 UTC|newest]

Thread overview: 26+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-05-03  9:38 [PATCH v6 00/16] Cleanup MediaTek clk reset drivers and support MT8192/MT8195 Rex-BC Chen
2022-05-03  9:38 ` [PATCH v6 01/16] clk: mediatek: reset: Add reset.h Rex-BC Chen
2022-05-03  9:38 ` [PATCH v6 02/16] clk: mediatek: reset: Fix written reset bit offset Rex-BC Chen
2022-05-03  9:38 ` [PATCH v6 03/16] clk: mediatek: reset: Refine and reorder functions in reset.c Rex-BC Chen
2022-05-03  9:38 ` [PATCH v6 04/16] clk: mediatek: reset: Extract common drivers to update function Rex-BC Chen
2022-05-03  9:38 ` [PATCH v6 05/16] clk: mediatek: reset: Merge and revise reset register function Rex-BC Chen
2022-05-03  9:38 ` [PATCH v6 06/16] clk: mediatek: reset: Revise structure to control reset register Rex-BC Chen
2022-05-03  9:38 ` [PATCH v6 07/16] clk: mediatek: reset: Support nonsequence base offsets of reset registers Rex-BC Chen
2022-05-03  9:38 ` [PATCH v6 08/16] clk: mediatek: reset: Support inuput argument index mode Rex-BC Chen
2022-05-03 12:37   ` AngeloGioacchino Del Regno
2022-05-03  9:38 ` [PATCH v6 09/16] clk: mediatek: reset: Change return type for clock reset register function Rex-BC Chen
2022-05-03  9:38 ` [PATCH v6 10/16] clk: mediatek: reset: Add new register reset function with device Rex-BC Chen
2022-05-03  9:38 ` [PATCH v6 11/16] clk: mediatek: reset: Add reset support for simple probe Rex-BC Chen
2022-05-03  9:38 ` [PATCH v6 12/16] dt-bindings: arm: mediatek: Add #reset-cells property for MT8192/MT8195 Rex-BC Chen
2022-05-03 12:37   ` AngeloGioacchino Del Regno
2022-05-03  9:38 ` [PATCH v6 13/16] dt-bindings: reset: mediatek: Add infra_ao reset index " Rex-BC Chen
2022-05-03 12:27   ` Krzysztof Kozlowski
2022-05-03 12:37   ` AngeloGioacchino Del Regno
2022-05-03  9:38 ` [PATCH v6 14/16] clk: mediatek: reset: Add infra_ao reset support " Rex-BC Chen
2022-05-03  9:38 ` [PATCH v6 15/16] arm64: dts: mediatek: Add infra #reset-cells property for MT8192 Rex-BC Chen
2022-06-22 11:05   ` Matthias Brugger
2022-05-03  9:38 ` [PATCH v6 16/16] arm64: dts: mediatek: Add infra #reset-cells property for MT8195 Rex-BC Chen
2022-06-22 11:08   ` Matthias Brugger [this message]
2022-06-22 12:06     ` Rex-BC Chen
2022-05-09  5:35 ` [PATCH v6 00/16] Cleanup MediaTek clk reset drivers and support MT8192/MT8195 Rex-BC Chen
     [not found]   ` <20220517072329.D367AC385B8@smtp.kernel.org>
2022-05-17 10:30     ` Rex-BC Chen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=3a587e20-f991-adf8-fe4e-a09caa1e14c7@gmail.com \
    --to=matthias.bgg@gmail.com \
    --cc=Project_Global_Chrome_Upstream_Group@mediatek.com \
    --cc=angelogioacchino.delregno@collabora.com \
    --cc=chun-jie.chen@mediatek.com \
    --cc=devicetree@vger.kernel.org \
    --cc=krzysztof.kozlowski+dt@linaro.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-clk@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mediatek@lists.infradead.org \
    --cc=mturquette@baylibre.com \
    --cc=p.zabel@pengutronix.de \
    --cc=rex-bc.chen@mediatek.com \
    --cc=robh+dt@kernel.org \
    --cc=runyang.chen@mediatek.com \
    --cc=sboyd@kernel.org \
    --cc=wenst@chromium.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).