From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ray Jui Subject: Re: [PATCH 4/4] pinctrl: iproc: Allow PINCONF to be disabled completely Date: Mon, 18 Apr 2016 12:30:26 -0700 Message-ID: <3a66ff72-dac1-eaa9-2567-a20f24bba1cf@broadcom.com> References: <1460506523-6249-1-git-send-email-ray.jui@broadcom.com> <1460506523-6249-5-git-send-email-ray.jui@broadcom.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: Sender: linux-gpio-owner@vger.kernel.org To: Linus Walleij Cc: Alexandre Courbot , Rob Herring , "linux-kernel@vger.kernel.org" , "linux-gpio@vger.kernel.org" , bcm-kernel-feedback-list , "devicetree@vger.kernel.org" List-Id: devicetree@vger.kernel.org Hi Linus, On 4/15/2016 1:24 AM, Linus Walleij wrote: > On Wed, Apr 13, 2016 at 2:15 AM, Ray Jui wrote: > >> In some of the future iProc based SoCs, pinconf is handled by another >> block and the iProc GPIO controller is solely used as a GPIO controller. >> This patch adds support of a new compatible string "brcm,iproc-gpio-only", >> that is introduced to handle this case, where pinconf functions in this >> driver are completely disabled >> >> Signed-off-by: Ray Jui >> Reviewed-by: Yendapally Reddy Dhananjaya Reddy >> Reviewed-by: Jon Mason >> Reviewed-by: Scott Branden > > If this was entirely true, then the driver should end up only executing > [devm_]gpiochip_add_data() but that does not seem to be the case. Yes, in the case of compatible string "brcm,iproc-gpio-only" is detected, the driver only registers 'gpiochip_add_data'. Please check patch 2/4 of this series, which takes care of it. > > You are still registering a pin controller, right? Just disabling some of > the pin config options. The pin multiplexing is still there, right? > Then it is not "solely a GPIO controller". Not at all. This driver does not register itself as a PINCONF driver if "brcm,iproc-gpio-only" compatible string is detected. This is addressed in patch 2/4 of this series. Pin based IOMUX GPIO override is only activated when 'chip->pinmux_is_supported' is true, and it is only true if the optional DT property "gpio-ranges" is defined. > > This patch set needs some elaboration I think. > > Yours, > Linus Walleij > I believe the current issue with this patch series is now only on the naming of the new compatible string "brcm,iproc-gpio-only". Please correct me if I'm wrong. Thanks, Ray