* [PATCH] dt-bindings: phy: qcom,usb-hs-phy: Add compatible [not found] <^[> @ 2024-04-15 11:56 ` Herman van Hazendonk 2024-04-17 4:52 ` [PATCH v2] " Herman van Hazendonk 0 siblings, 1 reply; 10+ messages in thread From: Herman van Hazendonk @ 2024-04-15 11:56 UTC (permalink / raw) To: Bjorn Andersson ^[ Cc: benwolsieffer, chris.chapuis, Herman van Hazendonk, Herman van Hazendonk, Konrad Dybcio, Vinod Koul, Kishon Vijay Abraham I, Rob Herring, Krzysztof Kozlowski, Conor Dooley, linux-arm-msm, linux-phy, devicetree, linux-kernel From: Herman van Hazendonk <me@herrie.org> Adds qcom,usb-hs-phy-msm8660 compatible Used by HP Touchpad (tenderloin) for example. Signed-off-by: Herman van Hazendonk <github.com@herrie.org> --- Documentation/devicetree/bindings/phy/qcom,usb-hs-phy.yaml | 2 ++ 1 file changed, 2 insertions(+) diff --git a/Documentation/devicetree/bindings/phy/qcom,usb-hs-phy.yaml b/Documentation/devicetree/bindings/phy/qcom,usb-hs-phy.yaml index f042d6af1594..1faf1da9f583 100644 --- a/Documentation/devicetree/bindings/phy/qcom,usb-hs-phy.yaml +++ b/Documentation/devicetree/bindings/phy/qcom,usb-hs-phy.yaml @@ -15,6 +15,7 @@ if: contains: enum: - qcom,usb-hs-phy-apq8064 + - qcom,usb-hs-phy-msm8660 - qcom,usb-hs-phy-msm8960 then: properties: @@ -42,6 +43,7 @@ properties: - qcom,usb-hs-phy-apq8064 - qcom,usb-hs-phy-msm8226 - qcom,usb-hs-phy-msm8916 + - qcom,usb-hs-phy-msm8660 - qcom,usb-hs-phy-msm8960 - qcom,usb-hs-phy-msm8974 - const: qcom,usb-hs-phy -- 2.40.1 ^ permalink raw reply related [flat|nested] 10+ messages in thread
* [PATCH v2] dt-bindings: phy: qcom,usb-hs-phy: Add compatible 2024-04-15 11:56 ` [PATCH] dt-bindings: phy: qcom,usb-hs-phy: Add compatible Herman van Hazendonk @ 2024-04-17 4:52 ` Herman van Hazendonk 2024-04-17 5:57 ` Dmitry Baryshkov 2024-04-17 19:03 ` Krzysztof Kozlowski 0 siblings, 2 replies; 10+ messages in thread From: Herman van Hazendonk @ 2024-04-17 4:52 UTC (permalink / raw) To: github.com Cc: andersson, benwolsieffer, chris.chapuis, conor+dt, devicetree, kishon, konrad.dybcio, krzk+dt, linux-arm-msm, linux-kernel, linux-phy, me, robh, vkoul Adds qcom,usb-hs-phy-msm8660 compatible Used by HP Touchpad (tenderloin) for example. Signed-off-by: Herman van Hazendonk <github.com@herrie.org> --- Documentation/devicetree/bindings/phy/qcom,usb-hs-phy.yaml | 2 ++ 1 file changed, 2 insertions(+) diff --git a/Documentation/devicetree/bindings/phy/qcom,usb-hs-phy.yaml b/Documentation/devicetree/bindings/phy/qcom,usb-hs-phy.yaml index f042d6af1594..ccf23170cd17 100644 --- a/Documentation/devicetree/bindings/phy/qcom,usb-hs-phy.yaml +++ b/Documentation/devicetree/bindings/phy/qcom,usb-hs-phy.yaml @@ -15,6 +15,7 @@ if: contains: enum: - qcom,usb-hs-phy-apq8064 + - qcom,usb-hs-phy-msm8660 - qcom,usb-hs-phy-msm8960 then: properties: @@ -41,6 +42,7 @@ properties: - enum: - qcom,usb-hs-phy-apq8064 - qcom,usb-hs-phy-msm8226 + - qcom,usb-hs-phy-msm8960 - qcom,usb-hs-phy-msm8916 - qcom,usb-hs-phy-msm8960 - qcom,usb-hs-phy-msm8974 ^ permalink raw reply related [flat|nested] 10+ messages in thread
* Re: [PATCH v2] dt-bindings: phy: qcom,usb-hs-phy: Add compatible 2024-04-17 4:52 ` [PATCH v2] " Herman van Hazendonk @ 2024-04-17 5:57 ` Dmitry Baryshkov 2024-04-17 6:50 ` Herman van Hazendonk 2024-04-17 19:03 ` Krzysztof Kozlowski 1 sibling, 1 reply; 10+ messages in thread From: Dmitry Baryshkov @ 2024-04-17 5:57 UTC (permalink / raw) To: Herman van Hazendonk Cc: andersson, benwolsieffer, chris.chapuis, conor+dt, devicetree, kishon, konrad.dybcio, krzk+dt, linux-arm-msm, linux-kernel, linux-phy, me, robh, vkoul On Wed, 17 Apr 2024 at 07:52, Herman van Hazendonk <github.com@herrie.org> wrote: > > Adds qcom,usb-hs-phy-msm8660 compatible > > Used by HP Touchpad (tenderloin) for example. > > Signed-off-by: Herman van Hazendonk <github.com@herrie.org> > --- > Documentation/devicetree/bindings/phy/qcom,usb-hs-phy.yaml | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/Documentation/devicetree/bindings/phy/qcom,usb-hs-phy.yaml b/Documentation/devicetree/bindings/phy/qcom,usb-hs-phy.yaml > index f042d6af1594..ccf23170cd17 100644 > --- a/Documentation/devicetree/bindings/phy/qcom,usb-hs-phy.yaml > +++ b/Documentation/devicetree/bindings/phy/qcom,usb-hs-phy.yaml > @@ -15,6 +15,7 @@ if: > contains: > enum: > - qcom,usb-hs-phy-apq8064 > + - qcom,usb-hs-phy-msm8660 > - qcom,usb-hs-phy-msm8960 > then: > properties: > @@ -41,6 +42,7 @@ properties: > - enum: > - qcom,usb-hs-phy-apq8064 > - qcom,usb-hs-phy-msm8226 > + - qcom,usb-hs-phy-msm8960 This should probably be msm8660 rather than 8960 Note, nowadays the rule would be to use qcom,msm8660-usb-hs-phy compatible, but I wonder if we should enforce this for such an old platform or whether similarity wins. > - qcom,usb-hs-phy-msm8916 > - qcom,usb-hs-phy-msm8960 > - qcom,usb-hs-phy-msm8974 > -- With best wishes Dmitry ^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH v2] dt-bindings: phy: qcom,usb-hs-phy: Add compatible 2024-04-17 5:57 ` Dmitry Baryshkov @ 2024-04-17 6:50 ` Herman van Hazendonk 2024-04-17 6:54 ` [PATCH v3] " Herman van Hazendonk 2024-04-17 7:02 ` [PATCH v2] " Dmitry Baryshkov 0 siblings, 2 replies; 10+ messages in thread From: Herman van Hazendonk @ 2024-04-17 6:50 UTC (permalink / raw) To: dmitry.baryshkov Cc: andersson, benwolsieffer, chris.chapuis, conor+dt, devicetree, github.com, kishon, konrad.dybcio, krzk+dt, linux-arm-msm, linux-kernel, linux-phy, me, robh, vkoul On Wed, 17 Apr 2024 at 07:52, Herman van Hazendonk <github.com@herrie.org> wrote: >> >> Adds qcom,usb-hs-phy-msm8660 compatible >> >> Used by HP Touchpad (tenderloin) for example. >> >> Signed-off-by: Herman van Hazendonk <github.com@herrie.org> >> --- >> Documentation/devicetree/bindings/phy/qcom,usb-hs-phy.yaml | 2 ++ >> 1 file changed, 2 insertions(+) >> >> diff --git a/Documentation/devicetree/bindings/phy/qcom,usb-hs-phy.yaml b/Documentation/devicetree/bindings/phy/qcom,usb-hs-phy.yaml >> index f042d6af1594..ccf23170cd17 100644 >> --- a/Documentation/devicetree/bindings/phy/qcom,usb-hs-phy.yaml >> +++ b/Documentation/devicetree/bindings/phy/qcom,usb-hs-phy.yaml >> @@ -15,6 +15,7 @@ if: >> contains: >> enum: >> - qcom,usb-hs-phy-apq8064 >> + - qcom,usb-hs-phy-msm8660 >> - qcom,usb-hs-phy-msm8960 >> then: >> properties: >> @@ -41,6 +42,7 @@ properties: >> - enum: >> - qcom,usb-hs-phy-apq8064 >> - qcom,usb-hs-phy-msm8226 >> + - qcom,usb-hs-phy-msm8960 > This should probably be msm8660 rather than 8960 Hi Dmitry, Thanks for the swift feedback. I'll send a v3. I need more coffee before doing this in the morning > Note, nowadays the rule would be to use qcom,msm8660-usb-hs-phy > compatible, but I wonder if we should enforce this for such an old > platform or whether similarity wins. >> - qcom,usb-hs-phy-msm8916 >> - qcom,usb-hs-phy-msm8960 >> - qcom,usb-hs-phy-msm8974 >> I plan to send more patches for the msm8660, so happy to understand what is the preferred approach, because it doesn't seem consistent. These are my first patches, so learning mainly from what I see in commit history (which might be outdated) It's indeed ancient platform, we just would like to get HP TouchPad (tenderloin) running with a mainline kernel, hence these patches. Best regards, Herman > -- > With best wishes > Dmitry ^ permalink raw reply [flat|nested] 10+ messages in thread
* [PATCH v3] dt-bindings: phy: qcom,usb-hs-phy: Add compatible 2024-04-17 6:50 ` Herman van Hazendonk @ 2024-04-17 6:54 ` Herman van Hazendonk 2024-04-17 14:27 ` Vinod Koul ` (2 more replies) 2024-04-17 7:02 ` [PATCH v2] " Dmitry Baryshkov 1 sibling, 3 replies; 10+ messages in thread From: Herman van Hazendonk @ 2024-04-17 6:54 UTC (permalink / raw) To: github.com Cc: benwolsieffer, chris.chapuis, Bjorn Andersson, Konrad Dybcio, Vinod Koul, Kishon Vijay Abraham I, Rob Herring, Krzysztof Kozlowski, Conor Dooley, linux-arm-msm, linux-phy, devicetree, linux-kernel Adds qcom,usb-hs-phy-msm8660 compatible Used by HP Touchpad (tenderloin) for example. Signed-off-by: Herman van Hazendonk <github.com@herrie.org> --- Documentation/devicetree/bindings/phy/qcom,usb-hs-phy.yaml | 2 ++ 1 file changed, 2 insertions(+) diff --git a/Documentation/devicetree/bindings/phy/qcom,usb-hs-phy.yaml b/Documentation/devicetree/bindings/phy/qcom,usb-hs-phy.yaml index f042d6af1594..e03b516c698c 100644 --- a/Documentation/devicetree/bindings/phy/qcom,usb-hs-phy.yaml +++ b/Documentation/devicetree/bindings/phy/qcom,usb-hs-phy.yaml @@ -15,6 +15,7 @@ if: contains: enum: - qcom,usb-hs-phy-apq8064 + - qcom,usb-hs-phy-msm8660 - qcom,usb-hs-phy-msm8960 then: properties: @@ -41,6 +42,7 @@ properties: - enum: - qcom,usb-hs-phy-apq8064 - qcom,usb-hs-phy-msm8226 + - qcom,usb-hs-phy-msm8660 - qcom,usb-hs-phy-msm8916 - qcom,usb-hs-phy-msm8960 - qcom,usb-hs-phy-msm8974 ^ permalink raw reply related [flat|nested] 10+ messages in thread
* Re: [PATCH v3] dt-bindings: phy: qcom,usb-hs-phy: Add compatible 2024-04-17 6:54 ` [PATCH v3] " Herman van Hazendonk @ 2024-04-17 14:27 ` Vinod Koul 2024-04-17 18:59 ` Rob Herring 2024-06-15 18:52 ` Vinod Koul 2 siblings, 0 replies; 10+ messages in thread From: Vinod Koul @ 2024-04-17 14:27 UTC (permalink / raw) To: Herman van Hazendonk Cc: benwolsieffer, chris.chapuis, Bjorn Andersson, Konrad Dybcio, Kishon Vijay Abraham I, Rob Herring, Krzysztof Kozlowski, Conor Dooley, linux-arm-msm, linux-phy, devicetree, linux-kernel On 17-04-24, 08:54, Herman van Hazendonk wrote: > Adds qcom,usb-hs-phy-msm8660 compatible > > Used by HP Touchpad (tenderloin) for example. This lgtm, where is the dts for this, would like to check that before I pick this > > Signed-off-by: Herman van Hazendonk <github.com@herrie.org> > --- > Documentation/devicetree/bindings/phy/qcom,usb-hs-phy.yaml | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/Documentation/devicetree/bindings/phy/qcom,usb-hs-phy.yaml b/Documentation/devicetree/bindings/phy/qcom,usb-hs-phy.yaml > index f042d6af1594..e03b516c698c 100644 > --- a/Documentation/devicetree/bindings/phy/qcom,usb-hs-phy.yaml > +++ b/Documentation/devicetree/bindings/phy/qcom,usb-hs-phy.yaml > @@ -15,6 +15,7 @@ if: > contains: > enum: > - qcom,usb-hs-phy-apq8064 > + - qcom,usb-hs-phy-msm8660 > - qcom,usb-hs-phy-msm8960 > then: > properties: > @@ -41,6 +42,7 @@ properties: > - enum: > - qcom,usb-hs-phy-apq8064 > - qcom,usb-hs-phy-msm8226 > + - qcom,usb-hs-phy-msm8660 > - qcom,usb-hs-phy-msm8916 > - qcom,usb-hs-phy-msm8960 > - qcom,usb-hs-phy-msm8974 > > -- > linux-phy mailing list > linux-phy@lists.infradead.org > https://lists.infradead.org/mailman/listinfo/linux-phy -- ~Vinod ^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH v3] dt-bindings: phy: qcom,usb-hs-phy: Add compatible 2024-04-17 6:54 ` [PATCH v3] " Herman van Hazendonk 2024-04-17 14:27 ` Vinod Koul @ 2024-04-17 18:59 ` Rob Herring 2024-06-15 18:52 ` Vinod Koul 2 siblings, 0 replies; 10+ messages in thread From: Rob Herring @ 2024-04-17 18:59 UTC (permalink / raw) To: Herman van Hazendonk Cc: benwolsieffer, Conor Dooley, Vinod Koul, Krzysztof Kozlowski, devicetree, linux-arm-msm, Bjorn Andersson, chris.chapuis, Kishon Vijay Abraham I, Konrad Dybcio, linux-phy, linux-kernel On Wed, 17 Apr 2024 08:54:54 +0200, Herman van Hazendonk wrote: > Adds qcom,usb-hs-phy-msm8660 compatible > > Used by HP Touchpad (tenderloin) for example. > > Signed-off-by: Herman van Hazendonk <github.com@herrie.org> > --- > Documentation/devicetree/bindings/phy/qcom,usb-hs-phy.yaml | 2 ++ > 1 file changed, 2 insertions(+) > Reviewed-by: Rob Herring (Arm) <robh@kernel.org> ^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH v3] dt-bindings: phy: qcom,usb-hs-phy: Add compatible 2024-04-17 6:54 ` [PATCH v3] " Herman van Hazendonk 2024-04-17 14:27 ` Vinod Koul 2024-04-17 18:59 ` Rob Herring @ 2024-06-15 18:52 ` Vinod Koul 2 siblings, 0 replies; 10+ messages in thread From: Vinod Koul @ 2024-06-15 18:52 UTC (permalink / raw) To: Herman van Hazendonk Cc: benwolsieffer, chris.chapuis, Bjorn Andersson, Konrad Dybcio, Kishon Vijay Abraham I, Rob Herring, Krzysztof Kozlowski, Conor Dooley, linux-arm-msm, linux-phy, devicetree, linux-kernel On Wed, 17 Apr 2024 08:54:54 +0200, Herman van Hazendonk wrote: > Adds qcom,usb-hs-phy-msm8660 compatible > > Used by HP Touchpad (tenderloin) for example. > > Applied, thanks! [1/1] dt-bindings: phy: qcom,usb-hs-phy: Add compatible commit: cd13368db059de22d27e86665a378aa2a388db85 Best regards, -- Vinod Koul <vkoul@kernel.org> ^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH v2] dt-bindings: phy: qcom,usb-hs-phy: Add compatible 2024-04-17 6:50 ` Herman van Hazendonk 2024-04-17 6:54 ` [PATCH v3] " Herman van Hazendonk @ 2024-04-17 7:02 ` Dmitry Baryshkov 1 sibling, 0 replies; 10+ messages in thread From: Dmitry Baryshkov @ 2024-04-17 7:02 UTC (permalink / raw) To: Herman van Hazendonk Cc: andersson, benwolsieffer, chris.chapuis, conor+dt, devicetree, kishon, konrad.dybcio, krzk+dt, linux-arm-msm, linux-kernel, linux-phy, me, robh, vkoul On Wed, 17 Apr 2024 at 09:50, Herman van Hazendonk <github.com@herrie.org> wrote: > > On Wed, 17 Apr 2024 at 07:52, Herman van Hazendonk > <github.com@herrie.org> wrote: > >> > >> Adds qcom,usb-hs-phy-msm8660 compatible > >> > >> Used by HP Touchpad (tenderloin) for example. > >> > >> Signed-off-by: Herman van Hazendonk <github.com@herrie.org> > >> --- > >> Documentation/devicetree/bindings/phy/qcom,usb-hs-phy.yaml | 2 ++ > >> 1 file changed, 2 insertions(+) > >> > >> diff --git a/Documentation/devicetree/bindings/phy/qcom,usb-hs-phy.yaml b/Documentation/devicetree/bindings/phy/qcom,usb-hs-phy.yaml > >> index f042d6af1594..ccf23170cd17 100644 > >> --- a/Documentation/devicetree/bindings/phy/qcom,usb-hs-phy.yaml > >> +++ b/Documentation/devicetree/bindings/phy/qcom,usb-hs-phy.yaml > >> @@ -15,6 +15,7 @@ if: > >> contains: > >> enum: > >> - qcom,usb-hs-phy-apq8064 > >> + - qcom,usb-hs-phy-msm8660 > >> - qcom,usb-hs-phy-msm8960 > >> then: > >> properties: > >> @@ -41,6 +42,7 @@ properties: > >> - enum: > >> - qcom,usb-hs-phy-apq8064 > >> - qcom,usb-hs-phy-msm8226 > >> + - qcom,usb-hs-phy-msm8960 > > > This should probably be msm8660 rather than 8960 > Hi Dmitry, > > Thanks for the swift feedback. I'll send a v3. > I need more coffee before doing this in the morning Please wait for the feedback from bindings maintainers (this might take a couple of days). > > Note, nowadays the rule would be to use qcom,msm8660-usb-hs-phy > > compatible, but I wonder if we should enforce this for such an old > > platform or whether similarity wins. > > >> - qcom,usb-hs-phy-msm8916 > >> - qcom,usb-hs-phy-msm8960 > >> - qcom,usb-hs-phy-msm8974 > >> > > I plan to send more patches for the msm8660, so happy to understand what > is the preferred approach, because it doesn't seem consistent. > > These are my first patches, so learning mainly from what I see in commit > history (which might be outdated) > It's indeed ancient platform, we just would like to get HP TouchPad > (tenderloin) running with a mainline kernel, hence these patches. This sounds really interesting. I recently got apq8060 so I should be able to test your patches if the time permits. -- With best wishes Dmitry ^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH v2] dt-bindings: phy: qcom,usb-hs-phy: Add compatible 2024-04-17 4:52 ` [PATCH v2] " Herman van Hazendonk 2024-04-17 5:57 ` Dmitry Baryshkov @ 2024-04-17 19:03 ` Krzysztof Kozlowski 1 sibling, 0 replies; 10+ messages in thread From: Krzysztof Kozlowski @ 2024-04-17 19:03 UTC (permalink / raw) To: Herman van Hazendonk Cc: andersson, benwolsieffer, chris.chapuis, conor+dt, devicetree, kishon, konrad.dybcio, krzk+dt, linux-arm-msm, linux-kernel, linux-phy, me, robh, vkoul On 17/04/2024 06:52, Herman van Hazendonk wrote: > Adds qcom,usb-hs-phy-msm8660 compatible > > Used by HP Touchpad (tenderloin) for example. > > Signed-off-by: Herman van Hazendonk <github.com@herrie.org> > --- Do not attach (thread) your patchsets to some other threads (unrelated or older versions). This buries them deep in the mailbox and might interfere with applying entire sets. Best regards, Krzysztof ^ permalink raw reply [flat|nested] 10+ messages in thread
end of thread, other threads:[~2024-06-15 18:52 UTC | newest]
Thread overview: 10+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <^[>
2024-04-15 11:56 ` [PATCH] dt-bindings: phy: qcom,usb-hs-phy: Add compatible Herman van Hazendonk
2024-04-17 4:52 ` [PATCH v2] " Herman van Hazendonk
2024-04-17 5:57 ` Dmitry Baryshkov
2024-04-17 6:50 ` Herman van Hazendonk
2024-04-17 6:54 ` [PATCH v3] " Herman van Hazendonk
2024-04-17 14:27 ` Vinod Koul
2024-04-17 18:59 ` Rob Herring
2024-06-15 18:52 ` Vinod Koul
2024-04-17 7:02 ` [PATCH v2] " Dmitry Baryshkov
2024-04-17 19:03 ` Krzysztof Kozlowski
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).