From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from codeconstruct.com.au (pi.codeconstruct.com.au [203.29.241.158]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A69B3134CCF; Mon, 27 Jul 2026 00:59:43 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=203.29.241.158 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1785113986; cv=none; b=Co0dKz+hQ+eI1Q0FTafl1j/AmhMprLpQvFX89phjkhja5+7rIbzurpgLZheDXLx5AIy1rLELqc5TlBmVykTRSeRPGsBf92cO3/BSs61CSvDOQ8mjWziTf34iqyZuL1CmcDWe9Px53p2LQKxztSqhDX4CiGFcw6+3MAmCevQ3oYQ= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1785113986; c=relaxed/simple; bh=Wem6sNRnY30doJw+U7poipVgShNMLZwf2O/edq87Z4c=; h=Message-ID:Subject:From:To:Cc:Date:In-Reply-To:References: Content-Type:MIME-Version; b=N1s8aI/yMqPy3C7ZfbJILd5QufQ0VhHUtCOPgRO90Lh0/Qy1iuugauqmtfQjMs9YS3evFXm3NkuD+FIkcORwPNld5+Iytx0HetFK9oPBGgtFg4oSS4r0MecYU2GiVt+gL4qJi7LKSheexaJ98D02r2Albyh5BNYyjthOdtGvRWU= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=codeconstruct.com.au; spf=pass smtp.mailfrom=codeconstruct.com.au; dkim=pass (2048-bit key) header.d=codeconstruct.com.au header.i=@codeconstruct.com.au header.b=YAF55WGK; arc=none smtp.client-ip=203.29.241.158 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=codeconstruct.com.au Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=codeconstruct.com.au Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=codeconstruct.com.au header.i=@codeconstruct.com.au header.b="YAF55WGK" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=codeconstruct.com.au; s=2022a; t=1785113974; bh=Wem6sNRnY30doJw+U7poipVgShNMLZwf2O/edq87Z4c=; h=Subject:From:To:Cc:Date:In-Reply-To:References; b=YAF55WGKe7CUjz1wzdmUr4eKEYEB/bTanhieEjBYhte6/JxqrMNyHj4DHHrQJO6Mb uhRXTx0SRTtXm2QRG7uNzmWwz8rs6J/6icb7XJ13zvNDka+DxeBb6XNAmb5C0pHkkw 1OEx9jTmZY+Z2x4pOyEqUDW/v+y7aDH+Lytxj9bVqjyVKhU4aLMVy9vBsgYZYIa+jV lQOTiXwT3JYda5B9Gpflk6ncUO3n3votu1DGyCJeDVPATB31ahaZPNB13BXldO1ZqJ HHgL+A3/f3gZBMebZgTwtIK9Wz74lPrvo13awshfc6LuP1owwpVdqyeO7eNlLO3lTk ldqBNxkAOD+Xw== Received: from [192.168.68.117] (unknown [180.150.113.112]) by mail.codeconstruct.com.au (Postfix) with ESMTPSA id 2D322608E3; Mon, 27 Jul 2026 08:59:32 +0800 (AWST) Message-ID: <3a997fc11b172a5b93cb04307a6ad2bdfd5845cf.camel@codeconstruct.com.au> Subject: Re: [PATCH v8 2/2] ARM: dts: aspeed: ventura2: Add Meta ventura2 BMC From: Andrew Jeffery To: Kyle Hsieh Cc: Rob Herring , Krzysztof Kozlowski , Conor Dooley , Joel Stanley , devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-aspeed@lists.ozlabs.org, linux-kernel@vger.kernel.org Date: Mon, 27 Jul 2026 10:29:31 +0930 In-Reply-To: References: <20260615-ventura2_initial_dts-v8-0-c89f92c80447@gmail.com> <20260615-ventura2_initial_dts-v8-2-c89f92c80447@gmail.com> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable User-Agent: Evolution 3.56.2-0+deb13u1 Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 On Thu, 2026-07-23 at 16:40 +0800, Kyle Hsieh wrote: > Hi Andrew, >=20 > Thanks for taking the time to review this. > On Wed, Jul 22, 2026 at 7:46=E2=80=AFPM Andrew Jeffery > wrote: > >=20 > > On Mon, 2026-06-15 at 10:46 +0800, Kyle Hsieh wrote: > > > Ventura2 is a Rack Management Controller. It is a modular > > > device designed to manage liquid cooling systems and monitor hardware > > > states within an IT rack. The system uses an AST2600 BMC for manageme= nt. > > >=20 > > > RMCv2 serves several critical roles: > > > - Detects liquid leakage at both tray and rack levels. > > > - Communicates with and controls liquid cooling equipment. > > > - Manages leakage events and executes system recovery protocols. > > >=20 > > > Key hardware features include: > > > - An extensive I2C and IO expander topology to support comprehensive > > > =C2=A0 sensor monitoring and backward compatibility with legacy trays= . > > > - MCTP over I2C support for asynchronous device communications. > > > - A dual-flash design for BMC firmware redundancy. > > >=20 > > > Signed-off-by: Kyle Hsieh > > > --- > > > =C2=A0arch/arm/boot/dts/aspeed/Makefile=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0= =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 |= =C2=A0=C2=A0=C2=A0 1 + > > > =C2=A0.../dts/aspeed/aspeed-bmc-facebook-ventura2.dts=C2=A0=C2=A0=C2= =A0 | 2903 ++++++++++++++++++++ > > > =C2=A02 files changed, 2904 insertions(+) > >=20 > > We now have scripts/dtc/dt-check-style. Running it over the dts with '- > > -mode relaxed' yields 49 instances of 'mixed-indent-chars' - these must > > be fixed. Further, can you please look at the output with '--mode > > strict', address all the warnings that are reasonable, and then discuss > > what's left? > I have fixed all 49 instances of the 'mixed-indent-chars' formatting issu= es. > I also ran it with '--mode strict' and addressed the formatting > warnings accordingly. Thanks. > >=20 > > Otherwise, there are still some concerns reported against the bindings: > >=20 > > =C2=A0=C2=A0 $ make CHECK_DTBS=3Dy aspeed/aspeed-bmc-facebook-ventura2.= dtb W=3D1 > > =C2=A0=C2=A0 ... > > =C2=A0=C2=A0=C2=A0=C2=A0 DTC [C] arch/arm/boot/dts/aspeed/aspeed-bmc-fa= cebook-ventura2.dtb > > =C2=A0=C2=A0 arch/arm/boot/dts/aspeed/aspeed-bmc-facebook-ventura2.dtb:= /ahb/apb/lpc@1e789000/lhc@a0: failed to match any schema with compatible: = ['aspeed,ast2600-lhc'] > > =C2=A0=C2=A0 /home/andrew/src/kernel.org/linux/origin/build.arm.aspeed_= g5/arch/arm/boot/dts/aspeed/aspeed-bmc-facebook-ventura2.dtb: fan-controlle= r@20 (maxim,max31790): 'channel@2', 'channel@5' do not match any of the reg= exes: '^fan@[0-9]+$', '^pinctrl-[0-9]+$' > > =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 from schem= a $id: http://devicetree.org/schemas/hwmon/maxim,max31790.yaml > > =C2=A0=C2=A0 /home/andrew/src/kernel.org/linux/origin/build.arm.aspeed_= g5/arch/arm/boot/dts/aspeed/aspeed-bmc-facebook-ventura2.dtb: i2c@400 (aspe= ed,ast2600-i2c-bus): Unevaluated properties are not allowed ('aspeed,hw-tim= eout-ms' was unexpected) > > =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 from schem= a $id: http://devicetree.org/schemas/i2c/aspeed,i2c.yaml > > =C2=A0=C2=A0 /home/andrew/src/kernel.org/linux/origin/build.arm.aspeed_= g5/arch/arm/boot/dts/aspeed/aspeed-bmc-facebook-ventura2.dtb: adc@48 (ti,ad= s1015): '#address-cells' is a required property > > =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 from schem= a $id: http://devicetree.org/schemas/iio/adc/ti,ads1015.yaml > > =C2=A0=C2=A0 /home/andrew/src/kernel.org/linux/origin/build.arm.aspeed_= g5/arch/arm/boot/dts/aspeed/aspeed-bmc-facebook-ventura2.dtb: adc@48 (ti,ad= s1015): '#size-cells' is a required property > > =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 from schem= a $id: http://devicetree.org/schemas/iio/adc/ti,ads1015.yaml > > =C2=A0=C2=A0 arch/arm/boot/dts/aspeed/aspeed-bmc-facebook-ventura2.dtb:= /ahb/apb/bus@1e78a000/i2c@580/power-monitor@69: failed to match any schema= with compatible: ['pmbus'] > > =C2=A0=C2=A0 arch/arm/boot/dts/aspeed/aspeed-bmc-facebook-ventura2.dtb:= /ahb/apb/bus@1e7a0000/syscon@0: failed to match any schema with compatible= : ['aspeed,ast2600-i3c-global', 'syscon'] > >=20 > > Can you please tidy these up? > The board-specific bindings have been fixed: > - Removed the invalid `channel@X` subnodes from the `maxim,max31790` > fan controller. > - Dropped the deprecated `aspeed,hw-timeout-ms` property from the I2C bus= . > - Removed the incomplete `ti,ads1015` ADC and generic `pmbus` power > monitor nodes to fully comply with upstream schemas. Thanks. >=20 > However, the warnings for `aspeed,ast2600-lhc` and > `aspeed,ast2600-i3c-global` still remain. > Since these nodes are inherited directly from the SoC level > (`aspeed-g6.dtsi`), it seems their YAML bindings are not yet merged > upstream. Yes, it is fine to disregard these for now. Andrew