From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.remote-ip=100.103.45.18 ARC-Seal: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; cv=none; t=1794989812; b=PDU9ptGpkGLIczVnwDU3duk7KvYluRhmqXAhQ7DllmE/54qwZ2OiNb3fRvzASTPTNq+U BFQoo/7H/a/nDJvt7rCsKHhImhjM7ZQZKXx9E1hWtWnjvRMw96P/JJXNHKHYQ5l5UPTwx XdyB1s2mBSa4DbQ/yj59nJgOrOqcLKHT1rOX6l1kkU3yEeZSsmBK5FmL0qrGUXiYwy/Do pH9p+U7qybRDQYyZ+ywDM3ps905vTMcmxZNcnFQgyV0cb0RRKhe31fw8U7Yo/bfHWrx96 nkKYWnPcCKOb/1PqgQLmwzzIGhPnLQC2bBq+4D8cDYKtb4/j8kKe0dOg1+Ij+kAkHOg== ARC-Message-Signature: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; c=relaxed/relaxed; t=1794989812; h=Received:DKIM-Signature:Message-ID:Date:MIME-Version:User-Agent: Subject:To:Cc:References:From:Content-Language:Autocrypt:In-Reply-To: Content-Type:Content-Transfer-Encoding; bh=RgUy9ilEvlBEFEAO7I4cAOPp0gwuSrRk3EbpdwQzjWw=; b=me/350nqaSvzoiV+rrOBpT01LLRbod32aMxTPiIhy+QhO3RbR1cLn8pyaAsr3m2ivGKT yR4K9icOYfwzhxyH1JeXD0WSrdUw73UM9dfYIi+vHkoSRssn9f9FTWIblAwXOsX0HQlcl tOssiNiqNEoy3F8m3gEH3ZNUq+gO3ofmtOPFJ2wrZxJYT9Un71SJoYkIKZXJPrQrWlJa+ pm1zfmNluTc9+QEd+A7bZK5AdgPLRdAwIWaXr55f8DcEbSnClOe2APOg4pg82l1an8ZMx 2dhNpTH2TuK9L3IOXmSaq9gsC/gs0gmWdryq9xmw/QJO1pxm20xmuirbtdtiezSvSXw== ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dkim=pass header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256 header.s=k20260515 header.b=eyZgpKqi; arc=none smtp.remote-ip=100.103.45.18 Received: from smtp.kernel.org (quasi.space.kernel.org [100.103.45.18]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id DB6A6606A881; Wed, 18 Nov 2026 08:16:52 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256 header.s=k20260515 header.b=eyZgpKqi Received: by smtp.kernel.org (Postfix) with ESMTPSA id 1C6151F000C7; Wed, 18 Nov 2026 08:16:47 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1794989812; bh=RgUy9ilEvlBEFEAO7I4cAOPp0gwuSrRk3EbpdwQzjWw=; h=Date:Subject:To:Cc:References:From:In-Reply-To; b=eyZgpKqi1/eEwQCPJrV3JHvcJ7BJGBNdzKNHXVr3jKwh4sH1XYEDz2ntepME7DESg RynbIxG67nQEjpWK8wULhrtDLIgfzLw02BoIEZemabyGctWPxDh2ED0VNIWZ7Nn/ii oQEMNKOi8vzgwiCjW+VzZrLrH/7Lszdd8R9FBpF6hLobiDEl9x5afuwm6I6NTLQ7XX W9Xo3n4885KmOX0PxkdYbqvJFTTV6b/fkalC3u5gEJXdvnsmvWR32N2eFpqGHpg2a2 hyGKW4gdmpSFb5UQH/+v4aMbk0k9fpXxTssQD0m1F7/Ed1YmmfsiR9haZJMrES+4Zh GEib5Gvt6vpSA== Message-ID: <3a9e999f-5ff5-422c-aa65-b8560dca84bc@kernel.org> Date: Wed, 18 Nov 2026 09:16:46 +0100 X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v7 2/9] dt-bindings: phy: rockchip,rk3588-mipi-dcphy: Select TX or RX, add phy-type To: Jason Yang , Vinod Koul , Neil Armstrong , Manivannan Sadhasivam , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Heiko Stuebner , Guochun Huang , Philipp Zabel Cc: Michael Riesch , Sebastian Reichel , Bryan O'Donoghue , linux-phy@lists.infradead.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-rockchip@lists.infradead.org, linux-kernel@vger.kernel.org, Quentin Schulz References: <20261118-dcphy-rx-v1-v7-0-8de1adac3a74@gmail.com> <20261118-dcphy-rx-v1-v7-2-8de1adac3a74@gmail.com> From: Krzysztof Kozlowski Content-Language: en-US Autocrypt: addr=krzk@kernel.org; keydata= xsFNBFVDQq4BEAC6KeLOfFsAvFMBsrCrJ2bCalhPv5+KQF2PS2+iwZI8BpRZoV+Bd5kWvN79 cFgcqTTuNHjAvxtUG8pQgGTHAObYs6xeYJtjUH0ZX6ndJ33FJYf5V3yXqqjcZ30FgHzJCFUu JMp7PSyMPzpUXfU12yfcRYVEMQrmplNZssmYhiTeVicuOOypWugZKVLGNm0IweVCaZ/DJDIH gNbpvVwjcKYrx85m9cBVEBUGaQP6AT7qlVCkrf50v8bofSIyVa2xmubbAwwFA1oxoOusjPIE J3iadrwpFvsZjF5uHAKS+7wHLoW9hVzOnLbX6ajk5Hf8Pb1m+VH/E8bPBNNYKkfTtypTDUCj NYcd27tjnXfG+SDs/EXNUAIRefCyvaRG7oRYF3Ec+2RgQDRnmmjCjoQNbFrJvJkFHlPeHaeS BosGY+XWKydnmsfY7SSnjAzLUGAFhLd/XDVpb1Een2XucPpKvt9ORF+48gy12FA5GduRLhQU vK4tU7ojoem/G23PcowM1CwPurC8sAVsQb9KmwTGh7rVz3ks3w/zfGBy3+WmLg++C2Wct6nM Pd8/6CBVjEWqD06/RjI2AnjIq5fSEH/BIfXXfC68nMp9BZoy3So4ZsbOlBmtAPvMYX6U8VwD TNeBxJu5Ex0Izf1NV9CzC3nNaFUYOY8KfN01X5SExAoVTr09ewARAQABzSVLcnp5c3p0b2Yg S296bG93c2tpIDxrcnprQGtlcm5lbC5vcmc+wsGPBBMBCgA5AhsDBgsJCAcDAgYVCAIJCgsE FgIDAQIeAQIXgBYhBJvQfg4MUfjVlne3VBuTQ307QWKbBQJp2mE8AAoJEBuTQ307QWKbeaIP /ihHTkTW4KsN/DQ945JJbyu5tI0J80Wue7QyyLPglyKfhgb5cLLNPpOC8cCIJsc7+W3i2P38 s2c1cOH6CYGE7E9ur3Vfme8NW2S2I/Z8VC7bZnzyS23wT17LrsdS/qCpx4o8U+pt/xdXDKph EGRYrIEmMpUWvyYzyYKGIe25FtaayIIKpq8eZYyFcp2f/sG5IkOW5uZzHPMPdcm87jU7fyuQ rAU2vx9r+ulUfQ/q9Z2roC/ode3l7t2pN7BCBCsUDp6JCrUyZrtT1e7EbA0ZRP3aOBNk2P2E DQOgJGjGdO5Yx2Y9LFtltu6JbsBJHi1syGRX3AtQYOMc4Y1WGoeZJmMlvKj2ZqqXNkcWi2DS IQEWB0uW6CqFsBBIMGDa+6OzdaVO/uAVXWDWml02Men3CILdI1MbVjoh8ECqYUY7OQ+JJvNN vnliuq5WM3Ghd3jg/LZZrxXjdIginRHFQCjIJYLKpLZWm1/iDFedcfzqRNYmTtqscdCNHW41 oT3Z7BmO9xwdjuwBS6nmS6JJwkbf5Ot2QR4pB/DRU7ZwjT1qHe+9r9gF32wXVQatHNGK/VVu sfwOnkdxCWkp/qb2gdQRmZh+SedStWshigH6sNfuHBloF/q+hjMRc8b2m326OZdrbSHwY1Sz vti8Hn7n8NjdHO9LKB7BIdjkA9DA5WsqOuVCzsFNBFVDXDQBEADNkrQYSREUL4D3Gws46JEo Z9HEQOKtkrwjrzlw/tCmqVzERRPvz2Xg8n7+HRCrgqnodIYoUh5WsU84N03KlLueMNsWLJBv BaubYN4JuJIdRr4dS4oyF1/fQAQPHh8Thpiz0SAZFx6iWKB7Qrz3OrGCjTPcW6eiOMheesVS 5hxietSmlin+SilmIAPZHx7n242u6kdHOh+/SyLImKn/dh9RzatVpUKbv34eP1wAGldWsRxb f3WP9pFNObSzI/Bo3kA89Xx2rO2roC+Gq4LeHvo7ptzcLcrqaHUAcZ3CgFG88CnA6z6lBZn0 WyewEcPOPdcUB2Q7D/NiUY+HDiV99rAYPJztjeTrBSTnHeSBPb+qn5ZZGQwIdUW9YegxWKvX XHTwB5eMzo/RB6vffwqcnHDoe0q7VgzRRZJwpi6aMIXLfeWZ5Wrwaw2zldFuO4Dt91pFzBSO IpeMtfgb/Pfe/a1WJ/GgaIRIBE+NUqckM+3zJHGmVPqJP/h2Iwv6nw8U+7Yyl6gUBLHFTg2h YnLFJI4Xjg+AX1hHFVKmvl3VBHIsBv0oDcsQWXqY+NaFahT0lRPjYtrTa1v3tem/JoFzZ4B0 p27K+qQCF2R96hVvuEyjzBmdq2esyE6zIqftdo4MOJho8uctOiWbwNNq2U9pPWmu4vXVFBYI GmpyNPYzRm0QPwARAQABwsF2BBgBCgAgAhsMFiEEm9B+DgxR+NWWd7dUG5NDfTtBYpsFAmna YUkACgkQG5NDfTtBYptX+BAApg32CkxwNucNEi8WfWA8oKkW0y8YDuY6ORMo9FWNGiT/OTy0 vyJrLocrpn86zwfjVp+eCrssPYh8eqJfnWqmYv6ACQtHPYzPZQ3mSo8H97Z01oUxITzCxpXm ZkLgPIqtDPcC2E3dPM/fVxcyowM8XsaMA9wcsaUYrta8toOq2b9tKcjleKMfMrm0gQ9u7wUc QbLkwj6TCLOwucb07GXzLTNF9PZmaDUpKAZjMjmrW+le+SFvQbhamx0rxLWPR0NWntXpbCn+ +ACch03p/JyTBVktxFsFyCt7pTPE1kEaeuXBTe/a2D9iQvRxRW19LvuO2e59/u1wYUiH/orz wbIC2S4dBsPAPihL3ztOU1yE86GPyQtSE0kU+/7snnLt4QGi6PChf3t5gnNjAzjUUovO8rgI c+5yN5heq5loYHgK6OQ9OlHzsPHO9e9MOQcKlFycs1pyijFGzDwdNUm/SchK8iWT2QApTx4A K9bCVaboTA2T77QYkRcRJYSsO1alGX0ome/hMLD1daXlkrNUp1HWa3K4iytLRXjCSIorWiGs n+q3krnpXu3TFkA8qtOFZMdnIiFuiq1yLT8hptsV5xh1TA2nsVvSYiaCr3q4s4BKjS/KrLDb qoxzw8ISjdUp4pA85vb6YLCmb39NgidD+7PmAr65lBNveIFynTgsja1rRQ4= In-Reply-To: <20261118-dcphy-rx-v1-v7-2-8de1adac3a74@gmail.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 18/11/2026 06:55, Jason Yang wrote: > The Samsung MIPI D-/C-PHY block on RK3588 and RK3576 has a transmitter > for DSI and a receiver for CSI-2, and the DSI host and the CSI-2 host > can use the transmitter and the receiver at the same time. The single > cell of this binding selects the mode and refers to the transmitter, so > the receiver cannot be described. > > Change the cell to select the transmitter or the receiver. The > transmitter and the receiver cannot operate in different modes [1], so > the optional phy-type property of the PHY node sets the mode for the > whole block, D-PHY by default: > > /* the MIPI DSI host, driving the transmitter */ > phys = <&mipidcphy0 PHY_DIRECTION_TX>; > > /* the MIPI CSI-2 host, driving the receiver */ > phys = <&mipidcphy0 PHY_DIRECTION_RX>; > > For C-PHY the consumers stay the same and the PHY node gets: > > phy-type = ; > > Existing DTs on a newer kernel: PHY_TYPE_DPHY and PHY_TYPE_CPHY remain > valid as deprecated values. They select the transmitter and imply > phy-type = or respectively, so nothing > changes for them. > > New DTs on an older kernel: an ABI break. The older kernel ignores > phy-type and takes any cell value as the mode of the block. A DSI node > with PHY_DIRECTION_TX therefore gets no display, and a CSI-2 node with > PHY_DIRECTION_RX gets no camera. > > [1] RK3588 TRM: section 22.1 (overview): "The TX and RX only support > operate in the same PHY mode." > > Suggested-by: Michael Riesch > Link: https://lore.kernel.org/r/94d47cab-10c6-4ec3-84a0-3bddc9d67f5f@collabora.com > Signed-off-by: Jason Yang > Reviewed-by: Rob Herring (Arm) > Reviewed-by: Michael Riesch > Tested-by: Quentin Schulz # RK3588 Tiger CSI1 2-lane IMX219, CSI0 2-lane OV5675+DSI Please drop the tag, this did not happen. In the future, please add only applicable tags. Otherwise share how this code was executed and tested on the actual hardware (make process, like building code, is obviously not testing). Best regards, Krzysztof