From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 69CD4C5479D for ; Mon, 9 Jan 2023 10:15:31 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S236406AbjAIKP2 (ORCPT ); Mon, 9 Jan 2023 05:15:28 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:32984 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S237043AbjAIKO6 (ORCPT ); Mon, 9 Jan 2023 05:14:58 -0500 Received: from mail-wr1-x42e.google.com (mail-wr1-x42e.google.com [IPv6:2a00:1450:4864:20::42e]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id AB53919293 for ; Mon, 9 Jan 2023 02:14:06 -0800 (PST) Received: by mail-wr1-x42e.google.com with SMTP id d17so7619794wrs.2 for ; Mon, 09 Jan 2023 02:14:06 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=tKCQUhm58zZMU1+N1NXsPah3RLRpFdffVr/EsdddpFY=; b=ckhYgBdaOObPp08TPqTFL7LDtCo3mvVO9nMROdG6iaHdh7Vmnz+KDmLvzMC3j+kXqr bGl+hEV9Vx4GS9/U9JSTG38wjjZS3JttcgkWmogv3YYYCCKi3whX1IYfr7TPfQ3i9z4U spe6stZTjC0IBRevcS/vLdR7NaZieS06dmJGsGI5YkG6Y+c84xvSw+T4dGP4pPavoLsx vGRs7/m3UY8IhY/GTbaxsj2wDAPgGwFYxQrniEZsOZfksv0JiPdgBBOJYGI82gm8E+lb HrQYOGsO7jVo9Oo9WMIT1YWSzGaQ7tSBLuEPOSLtk6jA6oS1LRDQ9jW3wxsSSouptbLx 4j2A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=tKCQUhm58zZMU1+N1NXsPah3RLRpFdffVr/EsdddpFY=; b=hB4qx82jOe8vbG/0TQ2c3QmSSRN02xKV2o1CIdLBcpX3UywE/6svZg7ddAKdgzYMYH FV1koM2cxUTpWXa3fjH8owa6VcOTwOeS0QDhvZ6qbU7S2vjKfatzH7eVwXV1YUt3FmQd JE9N/AEVqSap6K/G9nOpSN9Lli0Q4eytRciIx/vZLLEB50+zQ63luwt40Qtgp+HEdsdr lIW7SjdRnB5+idN03cLyh4YiN4kyNNyqHX19zbBWP2h6ty9E/0Bc74PL2n/xHlc2xoHk oaMTADK1lIAid3R0HzjRj4kRPuE1YE2sLV4Jxa/XnI/veeSlyRiuLY9OLKLXwjdqvaIb iypw== X-Gm-Message-State: AFqh2kr8DbBiHIqPOeyKYJ8RDU1kE21r7h56ju+mQzZDLc4Ae0A7jXDc 5YMckZ8wcLFsZOCz1mcMyOS+iQ== X-Google-Smtp-Source: AMrXdXuppLG6yXIDwCzTHlmZxEUSt0/iBt0iREIXO/zIq2DPIPPsNImJeAsr6RgHanJAh5qw2Be6nA== X-Received: by 2002:a5d:6b4e:0:b0:2ba:e1d9:37e7 with SMTP id x14-20020a5d6b4e000000b002bae1d937e7mr6995164wrw.18.1673259245274; Mon, 09 Jan 2023 02:14:05 -0800 (PST) Received: from [192.168.1.109] ([178.197.216.144]) by smtp.gmail.com with ESMTPSA id i5-20020a5d55c5000000b002a6f329203esm8232130wrw.61.2023.01.09.02.14.03 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 09 Jan 2023 02:14:04 -0800 (PST) Message-ID: <3aa83ec3-228d-1add-5e4b-c100340b127e@linaro.org> Date: Mon, 9 Jan 2023 11:14:03 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.6.1 Subject: Re: [PATCH 1/2] dt-bindings usb: typec: rt1718s: Add binding for Richtek RT1718S Content-Language: en-US To: gene_chen@richtek.com, robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org, linux@roeck-us.net, heikki.krogerus@linux.intel.com Cc: gregkh@linuxfoundation.org, linux-usb@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org References: <1673256674-25165-1-git-send-email-gene_chen@richtek.com> From: Krzysztof Kozlowski In-Reply-To: <1673256674-25165-1-git-send-email-gene_chen@richtek.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On 09/01/2023 10:31, gene_chen@richtek.com wrote: > From: Gene Chen > Subject: drop second, redundant "binding for". > Add binding for Richtek RT1718s > > Signed-off-by: Gene Chen > --- > .../devicetree/bindings/usb/richtek,rt1718s.yaml | 98 ++++++++++++++++++++++ > 1 file changed, 98 insertions(+) > create mode 100644 Documentation/devicetree/bindings/usb/richtek,rt1718s.yaml > > diff --git a/Documentation/devicetree/bindings/usb/richtek,rt1718s.yaml b/Documentation/devicetree/bindings/usb/richtek,rt1718s.yaml > new file mode 100644 > index 00000000..7797fc6 > --- /dev/null > +++ b/Documentation/devicetree/bindings/usb/richtek,rt1718s.yaml > @@ -0,0 +1,98 @@ > +# SPDX-License-Identifier: GPL-2.0-only OR BSD-2-Clause > +%YAML 1.2 > +--- > +$id: "http://devicetree.org/schemas/usb/richtek,rt1718s.yaml#" > +$schema: "http://devicetree.org/meta-schemas/core.yaml#" Drop quotes from both. > + > +title: Richtek RT1718S Type-C Port Switch and Power Delivery controller > + > +maintainers: > + - Gene Chen > + > +description: | > + The RT1718S is a USB Type-C controller that complies with the latest > + USB Type-C and PD standards. It does the USB Type-C detection including attach > + and orientation. It integrates the physical layer of the USB BMC power > + delivery protocol to allow up to 100W of power. The BMC PD block enables full > + support for alternative interfaces of the Type-C specification. > + > +properties: > + compatible: > + enum: > + - richtek,rt1718s > + > + reg: > + maxItems: 1 > + > + interrupts: > + maxItems: 1 > + > + wakeup-source: > + description: enable IRQ remote wakeup, see power/wakeup-source.txt Drop description, you are copying generic description. > + type: boolean Drop. Just wakeup-soource: true > + > + connector: > + type: object > + $ref: ../connector/usb-connector.yaml# Full path, so /schemas/usb/connector .... > + description: > + Properties for usb c connector. That's not accurate description. Everything in properties is a property, so no need to say that properties are properties. Actually this looks the same as existing rt1711, so please do not duplicate stuff. Especially, do not duplicate mistakes... > + > +additionalProperties: false > + > +required: > + - compatible > + - reg > + - connector > + - interrupts > + > +examples: > + - | > + #include > + #include > + i2c0 { i2c > + #address-cells = <1>; > + #size-cells = <0>; > + > + rt1718s@43 { Node names should be generic. https://devicetree-specification.readthedocs.io/en/latest/chapter2-devicetree-basics.html#generic-names-recommendation Best regards, Krzysztof