From: Heiner Kallweit <hkallweit1@gmail.com>
To: neil.armstrong@linaro.org, Rob Herring <robh+dt@kernel.org>,
Ulf Hansson <ulf.hansson@linaro.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Kevin Hilman <khilman@baylibre.com>,
Jerome Brunet <jbrunet@baylibre.com>,
Martin Blumenstingl <martin.blumenstingl@googlemail.com>
Cc: "linux-mmc@vger.kernel.org" <linux-mmc@vger.kernel.org>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>,
"open list:ARM/Amlogic Meson..."
<linux-amlogic@lists.infradead.org>,
"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>
Subject: Re: [PATCH] dt-bindings: mmc: meson-gx: fix interrupt binding
Date: Thu, 16 Feb 2023 20:44:50 +0100 [thread overview]
Message-ID: <3ac1eb14-e39e-066a-8066-a92572d0ba45@gmail.com> (raw)
In-Reply-To: <21ae5f5f-2336-db5b-f98a-f83391e1becd@linaro.org>
On 16.02.2023 13:52, Neil Armstrong wrote:
> On 16/02/2023 12:49, Heiner Kallweit wrote:
>> Reflect in the binding that the cd interrupt is optional,
>> and add a description of the interrupts.
>>
>> Fixes: 09b31a610328 ("dt-bindings: mmc: meson-gx: support specifying cd interrupt")
>> Signed-off-by: Heiner Kallweit <hkallweit1@gmail.com>
>> ---
>> .../devicetree/bindings/mmc/amlogic,meson-gx-mmc.yaml | 4 ++++
>> 1 file changed, 4 insertions(+)
>>
>> diff --git a/Documentation/devicetree/bindings/mmc/amlogic,meson-gx-mmc.yaml b/Documentation/devicetree/bindings/mmc/amlogic,meson-gx-mmc.yaml
>> index c8c30300d..cd3f75821 100644
>> --- a/Documentation/devicetree/bindings/mmc/amlogic,meson-gx-mmc.yaml
>> +++ b/Documentation/devicetree/bindings/mmc/amlogic,meson-gx-mmc.yaml
>> @@ -28,7 +28,11 @@ properties:
>> maxItems: 1
>> interrupts:
>> + minItems: 1
>> maxItems: 2
>> + description:
>> + mmc controller instance interrupt
>> + optional card detect interrupt
>
> I would instead write:
>
> interrupts:
> minItems: 1
> items:
> - description: mmc controller instance
> - description: card detect
>
> and drop maxItems.
>
Thanks for the hint! Bindings isn't really my area of expertise (yet).
> Neil
>> clocks:
>> maxItems: 3
>
prev parent reply other threads:[~2023-02-16 19:44 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-02-16 11:49 [PATCH] dt-bindings: mmc: meson-gx: fix interrupt binding Heiner Kallweit
2023-02-16 12:52 ` Neil Armstrong
2023-02-16 13:43 ` Krzysztof Kozlowski
2023-02-16 19:44 ` Heiner Kallweit [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3ac1eb14-e39e-066a-8066-a92572d0ba45@gmail.com \
--to=hkallweit1@gmail.com \
--cc=devicetree@vger.kernel.org \
--cc=jbrunet@baylibre.com \
--cc=khilman@baylibre.com \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-amlogic@lists.infradead.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-mmc@vger.kernel.org \
--cc=martin.blumenstingl@googlemail.com \
--cc=neil.armstrong@linaro.org \
--cc=robh+dt@kernel.org \
--cc=ulf.hansson@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).