* [PATCH] dt-bindings: mmc: meson-gx: fix interrupt binding
@ 2023-02-16 11:49 Heiner Kallweit
2023-02-16 12:52 ` Neil Armstrong
0 siblings, 1 reply; 4+ messages in thread
From: Heiner Kallweit @ 2023-02-16 11:49 UTC (permalink / raw)
To: Rob Herring, Ulf Hansson, Krzysztof Kozlowski, Neil Armstrong,
Kevin Hilman, Jerome Brunet, Martin Blumenstingl
Cc: linux-mmc@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
open list:ARM/Amlogic Meson..., devicetree@vger.kernel.org
Reflect in the binding that the cd interrupt is optional,
and add a description of the interrupts.
Fixes: 09b31a610328 ("dt-bindings: mmc: meson-gx: support specifying cd interrupt")
Signed-off-by: Heiner Kallweit <hkallweit1@gmail.com>
---
.../devicetree/bindings/mmc/amlogic,meson-gx-mmc.yaml | 4 ++++
1 file changed, 4 insertions(+)
diff --git a/Documentation/devicetree/bindings/mmc/amlogic,meson-gx-mmc.yaml b/Documentation/devicetree/bindings/mmc/amlogic,meson-gx-mmc.yaml
index c8c30300d..cd3f75821 100644
--- a/Documentation/devicetree/bindings/mmc/amlogic,meson-gx-mmc.yaml
+++ b/Documentation/devicetree/bindings/mmc/amlogic,meson-gx-mmc.yaml
@@ -28,7 +28,11 @@ properties:
maxItems: 1
interrupts:
+ minItems: 1
maxItems: 2
+ description:
+ mmc controller instance interrupt
+ optional card detect interrupt
clocks:
maxItems: 3
--
2.39.1
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] dt-bindings: mmc: meson-gx: fix interrupt binding
2023-02-16 11:49 [PATCH] dt-bindings: mmc: meson-gx: fix interrupt binding Heiner Kallweit
@ 2023-02-16 12:52 ` Neil Armstrong
2023-02-16 13:43 ` Krzysztof Kozlowski
2023-02-16 19:44 ` Heiner Kallweit
0 siblings, 2 replies; 4+ messages in thread
From: Neil Armstrong @ 2023-02-16 12:52 UTC (permalink / raw)
To: Heiner Kallweit, Rob Herring, Ulf Hansson, Krzysztof Kozlowski,
Kevin Hilman, Jerome Brunet, Martin Blumenstingl
Cc: linux-mmc@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
open list:ARM/Amlogic Meson..., devicetree@vger.kernel.org
On 16/02/2023 12:49, Heiner Kallweit wrote:
> Reflect in the binding that the cd interrupt is optional,
> and add a description of the interrupts.
>
> Fixes: 09b31a610328 ("dt-bindings: mmc: meson-gx: support specifying cd interrupt")
> Signed-off-by: Heiner Kallweit <hkallweit1@gmail.com>
> ---
> .../devicetree/bindings/mmc/amlogic,meson-gx-mmc.yaml | 4 ++++
> 1 file changed, 4 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/mmc/amlogic,meson-gx-mmc.yaml b/Documentation/devicetree/bindings/mmc/amlogic,meson-gx-mmc.yaml
> index c8c30300d..cd3f75821 100644
> --- a/Documentation/devicetree/bindings/mmc/amlogic,meson-gx-mmc.yaml
> +++ b/Documentation/devicetree/bindings/mmc/amlogic,meson-gx-mmc.yaml
> @@ -28,7 +28,11 @@ properties:
> maxItems: 1
>
> interrupts:
> + minItems: 1
> maxItems: 2
> + description:
> + mmc controller instance interrupt
> + optional card detect interrupt
I would instead write:
interrupts:
minItems: 1
items:
- description: mmc controller instance
- description: card detect
and drop maxItems.
Neil
>
> clocks:
> maxItems: 3
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] dt-bindings: mmc: meson-gx: fix interrupt binding
2023-02-16 12:52 ` Neil Armstrong
@ 2023-02-16 13:43 ` Krzysztof Kozlowski
2023-02-16 19:44 ` Heiner Kallweit
1 sibling, 0 replies; 4+ messages in thread
From: Krzysztof Kozlowski @ 2023-02-16 13:43 UTC (permalink / raw)
To: neil.armstrong, Heiner Kallweit, Rob Herring, Ulf Hansson,
Krzysztof Kozlowski, Kevin Hilman, Jerome Brunet,
Martin Blumenstingl
Cc: linux-mmc@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
open list:ARM/Amlogic Meson..., devicetree@vger.kernel.org
On 16/02/2023 13:52, Neil Armstrong wrote:
>> interrupts:
>> + minItems: 1
>> maxItems: 2
>> + description:
>> + mmc controller instance interrupt
>> + optional card detect interrupt
>
> I would instead write:
>
> interrupts:
> minItems: 1
> items:
> - description: mmc controller instance
> - description: card detect
>
> and drop maxItems.
+1
Best regards,
Krzysztof
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] dt-bindings: mmc: meson-gx: fix interrupt binding
2023-02-16 12:52 ` Neil Armstrong
2023-02-16 13:43 ` Krzysztof Kozlowski
@ 2023-02-16 19:44 ` Heiner Kallweit
1 sibling, 0 replies; 4+ messages in thread
From: Heiner Kallweit @ 2023-02-16 19:44 UTC (permalink / raw)
To: neil.armstrong, Rob Herring, Ulf Hansson, Krzysztof Kozlowski,
Kevin Hilman, Jerome Brunet, Martin Blumenstingl
Cc: linux-mmc@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
open list:ARM/Amlogic Meson..., devicetree@vger.kernel.org
On 16.02.2023 13:52, Neil Armstrong wrote:
> On 16/02/2023 12:49, Heiner Kallweit wrote:
>> Reflect in the binding that the cd interrupt is optional,
>> and add a description of the interrupts.
>>
>> Fixes: 09b31a610328 ("dt-bindings: mmc: meson-gx: support specifying cd interrupt")
>> Signed-off-by: Heiner Kallweit <hkallweit1@gmail.com>
>> ---
>> .../devicetree/bindings/mmc/amlogic,meson-gx-mmc.yaml | 4 ++++
>> 1 file changed, 4 insertions(+)
>>
>> diff --git a/Documentation/devicetree/bindings/mmc/amlogic,meson-gx-mmc.yaml b/Documentation/devicetree/bindings/mmc/amlogic,meson-gx-mmc.yaml
>> index c8c30300d..cd3f75821 100644
>> --- a/Documentation/devicetree/bindings/mmc/amlogic,meson-gx-mmc.yaml
>> +++ b/Documentation/devicetree/bindings/mmc/amlogic,meson-gx-mmc.yaml
>> @@ -28,7 +28,11 @@ properties:
>> maxItems: 1
>> interrupts:
>> + minItems: 1
>> maxItems: 2
>> + description:
>> + mmc controller instance interrupt
>> + optional card detect interrupt
>
> I would instead write:
>
> interrupts:
> minItems: 1
> items:
> - description: mmc controller instance
> - description: card detect
>
> and drop maxItems.
>
Thanks for the hint! Bindings isn't really my area of expertise (yet).
> Neil
>> clocks:
>> maxItems: 3
>
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2023-02-16 19:44 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-02-16 11:49 [PATCH] dt-bindings: mmc: meson-gx: fix interrupt binding Heiner Kallweit
2023-02-16 12:52 ` Neil Armstrong
2023-02-16 13:43 ` Krzysztof Kozlowski
2023-02-16 19:44 ` Heiner Kallweit
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).