From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=arndb.de header.i=@arndb.de header.b="0qIVkSg7"; dkim=pass (2048-bit key) header.d=messagingengine.com header.i=@messagingengine.com header.b="ZM3RnFwl" Received: from out5-smtp.messagingengine.com (out5-smtp.messagingengine.com [66.111.4.29]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 14B84134; Tue, 5 Dec 2023 05:05:34 -0800 (PST) Received: from compute5.internal (compute5.nyi.internal [10.202.2.45]) by mailout.nyi.internal (Postfix) with ESMTP id 7C7245C01AF; Tue, 5 Dec 2023 08:05:33 -0500 (EST) Received: from imap51 ([10.202.2.101]) by compute5.internal (MEProxy); Tue, 05 Dec 2023 08:05:33 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=arndb.de; h=cc :cc:content-type:content-type:date:date:from:from:in-reply-to :in-reply-to:message-id:mime-version:references:reply-to:sender :subject:subject:to:to; s=fm3; t=1701781533; x=1701867933; bh=zv 8E1tGkz8JRoBtprl3IIFJf3pqYhFYTFABmpiAXWAw=; b=0qIVkSg7ams/DQOYLa AnflRwv69frRRiDu8eF8KOOGrPD+ifn/wUrUqkDFSVze3mG2Bbo49iJXohb3RUIA rdB6N0YhfvfHzRmIlPw22yVtn1fyVhyDdu76q/bE+I3IDUXNBfeVfy1/HbpK8Dbd Iexh4+qFXwGpzu+MyKbhH1imzlSeYtKWXSQahQsRvuk3vEnynrXUm8FNu/IXeKFW a63pD4Z9HAFXyd9H8mJJIfxI7NRXB8i7oByhkiAozdUzrnhb3ONmfSUgBLxT++TU 3bJV7mbTJ5rokIeB1guSHRgI8CXqu7+mGxDyFKNn888aA1MMDa6Kl00PKOBvfFjJ 6QwQ== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-type:content-type:date:date :feedback-id:feedback-id:from:from:in-reply-to:in-reply-to :message-id:mime-version:references:reply-to:sender:subject :subject:to:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm1; t=1701781533; x=1701867933; bh=zv8E1tGkz8JRo Btprl3IIFJf3pqYhFYTFABmpiAXWAw=; b=ZM3RnFwl9Of1m5cnmg+84caA6KjaD k7zpbwa/FXBoK5ZMmtNvv1DDKveEPXNQ2HUUoZ1WENXWwz3l6/fQtQRjhM8Xgt+u LXdCgo8wChxxa8voY3EZL8xgHa1H71+8OoVenr7bVpYW8e8SZsSos/8d4TOscRby IC7ghZPQaZ3BvNnOnYg0CLKZGhvooqOmhI2FdcSdO+mM1pk2SeGYc4OvjrhZ2zzq nXWEOVgQ7km9nYqzXTW9mOZ4/4BNg67kCKmCKoPaaTV1VK5WdZFw2EZsOYKlA6Hb ECVlyj4QbHY/h0Q7XtpGpI3cPGz8iedwm50JaRVPodkc6ZSfypOuKHn/A== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvkedrudejkedggeejucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhepofgfggfkjghffffhvfevufgtsehttdertderredtnecuhfhrohhmpedftehr nhguuceuvghrghhmrghnnhdfuceorghrnhgusegrrhhnuggsrdguvgeqnecuggftrfgrth htvghrnhepffehueegteeihfegtefhjefgtdeugfegjeelheejueethfefgeeghfektdek teffnecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehmrghilhhfrhhomheprg hrnhgusegrrhhnuggsrdguvg X-ME-Proxy: Feedback-ID: i56a14606:Fastmail Received: by mailuser.nyi.internal (Postfix, from userid 501) id B88B2B60089; Tue, 5 Dec 2023 08:05:32 -0500 (EST) X-Mailer: MessagingEngine.com Webmail Interface User-Agent: Cyrus-JMAP/3.9.0-alpha0-1178-geeaf0069a7-fm-20231114.001-geeaf0069 Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Message-Id: <3acae2ba-e91a-46d2-8748-b2cb1b369063@app.fastmail.com> In-Reply-To: References: Date: Tue, 05 Dec 2023 14:05:11 +0100 From: "Arnd Bergmann" To: "Yoshinori Sato" , linux-sh@vger.kernel.org Cc: "Damien Le Moal" , "Rob Herring" , "Krzysztof Kozlowski" , "Conor Dooley" , "Geert Uytterhoeven" , "Michael Turquette" , "Stephen Boyd" , "Dave Airlie" , "Daniel Vetter" , "Maarten Lankhorst" , "Maxime Ripard" , "Thomas Zimmermann" , "Thomas Gleixner" , "Lorenzo Pieralisi" , =?UTF-8?Q?Krzysztof_Wilczy=C5=84ski?= , "Bjorn Helgaas" , "Greg Kroah-Hartman" , "Jiri Slaby" , "Magnus Damm" , "Daniel Lezcano" , "Rich Felker" , "John Paul Adrian Glaubitz" , "Lee Jones" , "Helge Deller" , =?UTF-8?Q?Heiko_St=C3=BCbner?= , "Jernej Skrabec" , "Chris Morgan" , "Linus Walleij" , "Randy Dunlap" , "Hyeonggon Yoo" <42.hyeyoo@gmail.com>, "David Rientjes" , "Vlastimil Babka" , "Baoquan He" , "Andrew Morton" , "Guenter Roeck" , "Stephen Rothwell" , guoren , "Javier Martinez Canillas" , "Azeem Shaikh" , "Palmer Dabbelt" , "Bin Meng" , "Max Filippov" , "Tom Rix" , "Herve Codina" , "Jacky Huang" , "Lukas Bulwahn" , "Jonathan Corbet" , "Biju Das" , =?UTF-8?Q?Uwe_Kleine-K=C3=B6nig?= , "Sam Ravnborg" , "Michael Karcher" , "Sergey Shtylyov" , "Laurent Pinchart" , linux-ide@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Linux-Renesas , linux-clk@vger.kernel.org, dri-devel@lists.freedesktop.org, linux-pci@vger.kernel.org, linux-serial@vger.kernel.org, linux-fbdev@vger.kernel.org Subject: Re: [DO NOT MERGE v5 10/37] sh: Common PCI Framework driver support. Content-Type: text/plain On Tue, Dec 5, 2023, at 10:45, Yoshinori Sato wrote: > + > +#if defined(CONFIG_PCI) && !defined(CONFIG_GENERIC_IOMAP) > +void pci_iounmap(struct pci_dev *dev, void __iomem *addr) > +{ > + iounmap(addr); > +} > +EXPORT_SYMBOL(pci_iounmap); This definition does not work for addresses that are returned by ioport_map(), include pci_iomap() on IORESOURCE_IO. However, the definition in lib/pci_iomap.c should work fine, you just need to #define ARCH_WANTS_GENERIC_PCI_IOUNMAP to get that. Arnd