From: Florian Fainelli <f.fainelli@gmail.com>
To: Andrew Lunn <andrew@lunn.ch>, Fabio Estevam <festevam@gmail.com>
Cc: kuba@kernel.org, davem@davemloft.net, edumazet@google.com,
pabeni@redhat.com, robh+dt@kernel.org,
krzysztof.kozlowski+dt@linaro.org, conor+dt@kernel.org,
netdev@vger.kernel.org, devicetree@vger.kernel.org,
Fabio Estevam <festevam@denx.de>
Subject: Re: [PATCH net-next] dt-bindings: net: snps,dwmac: Do not make 'phy-mode' required
Date: Mon, 13 Nov 2023 14:03:00 -0800 [thread overview]
Message-ID: <3acda2a2-3c99-4a14-ab68-ab166ce08194@gmail.com> (raw)
In-Reply-To: <43d176e2-d95f-40dd-8e42-8d7d5ed6492c@lunn.ch>
On 11/13/23 13:51, Andrew Lunn wrote:
> On Mon, Nov 13, 2023 at 05:40:52PM -0300, Fabio Estevam wrote:
>> From: Fabio Estevam <festevam@denx.de>
>>
>> The property 'phy-connection-type' can also be used to describe
>> the interface type between the Ethernet device and the Ethernet PHY
>> device.
>>
>> Mark 'phy-mode' as a non required property.
>
> Hi Fabio
>
> What does the driver actually require? Will it error out if neither is
> provided?
>
> Maybe we should be changing the condition that one or the other is
> required?
'phy-connection-type' is the deprecated version of 'phy-mode' which
of_get_phy_mode() will fall back to if 'phy-mode' is not provided. It
does not appear that stmmac attempts to use anything other than
of_get_phy_mode() therefore would not it be acceptable to update the
relevant .dts file such that it uses 'phy-mode'?
That really should not have a functional impact given that
of_get_phy_mode() has worked that way for a while.
--
Florian
next prev parent reply other threads:[~2023-11-13 22:03 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-11-13 20:40 [PATCH net-next] dt-bindings: net: snps,dwmac: Do not make 'phy-mode' required Fabio Estevam
2023-11-13 21:51 ` Andrew Lunn
2023-11-13 22:03 ` Florian Fainelli [this message]
2023-11-13 22:23 ` Andrew Lunn
2023-11-13 22:55 ` Fabio Estevam
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3acda2a2-3c99-4a14-ab68-ab166ce08194@gmail.com \
--to=f.fainelli@gmail.com \
--cc=andrew@lunn.ch \
--cc=conor+dt@kernel.org \
--cc=davem@davemloft.net \
--cc=devicetree@vger.kernel.org \
--cc=edumazet@google.com \
--cc=festevam@denx.de \
--cc=festevam@gmail.com \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=kuba@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox